From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6717496001358200832
X-Received: by 2002:a1c:e710:: with SMTP id e16mr119347908wmh.38.1564660117235;
        Thu, 01 Aug 2019 04:48:37 -0700 (PDT)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:adf:97de:: with SMTP id t30ls18971011wrb.11.gmail; Thu, 01
 Aug 2019 04:48:36 -0700 (PDT)
X-Google-Smtp-Source: APXvYqz/83yxr3QEF0i4zzWFdaTf8mAyjIYLWmCpv+W66bK/E9KnSnK81SFiT0qnVXzWh+riwiFm
X-Received: by 2002:adf:cd81:: with SMTP id q1mr139050172wrj.16.1564660116781;
        Thu, 01 Aug 2019 04:48:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1564660116; cv=none;
        d=google.com; s=arc-20160816;
        b=WEN4Ouu0FKGSUKgUuU7AMsepZLDbBiPJGdg24ZM0N4o8ypm97r6Rec0Y4ikSo0Lwmw
         4F60iV0dANR1gBxgpNpmBDQtJRaxJ843kBVDe19iPXXslXHfQZ8DeLsJbF4CJLR7A+IG
         HqvF33kVo9Pnj4L+8pk+ZSS7gHwt2oqFtpEapK+7rvV4VSGcBdNUNSPjEicm8pXwix3N
         YibP1qiXLZzOg7OLNDtLxrbLPJfq83VKn5ZOT+u9elzPfkGSR5QkdFG9AEeSmHUAQ4pK
         9OAaotXmMDTSNWhXkvbeTjT4oUHplnz4PWrt2aWHOK7cNn9Rsm+6CgQ0EOkzF6XhUhKp
         ddLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:to:from:date;
        bh=LQ47RkWQBJpbBYNRV1uWmaA2Vl0iYDLpb9Q8W+FPCW4=;
        b=IEvuHF6ozx9IfbW3yRkKc6fZT9pZBf1wrlkelIgp1hdQgZQ9DzMvo0nVfS8fHEgLVS
         qb+2cIHuM8EIpzSOtTaaJT8xxmtUujkHvUUWtiFzBbWxNENt26vq3IlFFFHyOWK+sFzQ
         dfBbh7h9H7/2MeealageCZxn3Qiy/19WDs5ZyeXOCyihFFMjF//5xbgZF/8wxvgLtYct
         Adww6GFvOk2PEjBnfH6JAWBmF8gPdda/xptWAUujAZHc++0ea3reTtchOnk5443QzCps
         WFTpP516bAHAzJlDDliEJVxea8CjIpuOAFjsZD+ScIOfXeG7eU7rdit9GlFd6UJBtJ8W
         A5ng==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Return-Path: <ibr@radix50.net>
Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166])
        by gmr-mx.google.com with ESMTPS id o4si571359wrp.4.2019.08.01.04.48.36
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Thu, 01 Aug 2019 04:48:36 -0700 (PDT)
Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166;
Authentication-Results: gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52])
	(authenticated bits=0)
	by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x71BmYik023243
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
	for <isar-users@googlegroups.com>; Thu, 1 Aug 2019 13:48:36 +0200
Date: Thu, 1 Aug 2019 13:48:34 +0200
From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] export GNUGPHOME for reprepro
Message-ID: <20190801114834.GK14716@yssyq.m.ilbers.de>
Mail-Followup-To: isar-users <isar-users@googlegroups.com>
References: <20190725071504.24037-1-Vijaikumar_Kangarajan@mentor.com>
 <20190801131219.33274775@md1za8fc.ad001.siemens.net>
 <CALLGG_JbP6NM_=Q4qD1Ypygf__LvjupvoO50H30vtaYcoR85zQ@mail.gmail.com>
 <CALLGG_L8L-o8RHGfKr6s5ruOvxUKiiSjfbHKeeJWNd0TjSEM-A@mail.gmail.com>
 <20190801133818.3915d525@md1za8fc.ad001.siemens.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190801133818.3915d525@md1za8fc.ad001.siemens.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED
	autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de
X-TUID: 414pHWxTQdGz

On Thu, Aug 01, 2019 at 01:38:18PM +0200, Henning Schild wrote:
> > >> Why did you go for conditional append for that one, while the
> > >> others are unconditional?
> > >
> > > GNUPGHOME might not be set in the host and hence went for the
> > > condition. BTW, I don't think having always would cause issues.
> 
> If there is no reason for the condition please drop it.

If I read the patch correctly, all uses of GNUPGHOME are conditional. IIUC, we
need conditions everywhere, because if it is not set in the host environment,
we'd end up setting it to an empty string, which I assume we shouldn't do. Or
have I overlooked anything?

With kind regards,
Baurzhan.