From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6717496001358200832 X-Received: by 2002:a1c:e710:: with SMTP id e16mr119164128wmh.38.1564657942798; Thu, 01 Aug 2019 04:12:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:c411:: with SMTP id k17ls25144145wmi.1.gmail; Thu, 01 Aug 2019 04:12:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8ULoDno6zWJgewepWaXKnhPWgn+NHPzWtYW3rUhXYW9oScEq8QVBHtv3R0xb52m3BJ658 X-Received: by 2002:a1c:c14b:: with SMTP id r72mr100150131wmf.166.1564657941123; Thu, 01 Aug 2019 04:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564657941; cv=none; d=google.com; s=arc-20160816; b=S+PaJh4RU+JLOWzA1wvjjOtbl6CCeLz9inonbV0rnKZ3aRXr1iTEqCp9O2e70F9MaT v1f2FTn9imJvw/Nt7lNY0HMlZ6Bsi7g/YswF0hVc+RUvo2ebiYDH/0kWNgCPGFUeAxv8 gEqS15AVwPIfbLlXZtjB1fazzjJGHNVnDm2csUxjNySExiXFZ9FtLEwUTQlRktgCT1RW DHNoyiXrBglNLuAA5ckgceySbBflXmc8Fi++WWsL0SNpSlTnxNN8OK7vAjr1HxSVg8ew B1oVzhPIOqyha/XB5bX8lA9vZx0gT3bCJYze2YFd9u+2q8IynekFdmfr7l3RUvQW/LC3 +wTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=VfeO0PAt/zBkfLYgAqiBYIQXBJ3h3CRuiXa7ToAO+3Y=; b=ibuGPAP2c8Jn/QcQ1cIDu7UgrTocn0r0jY3EkEKO30b2rheDrRVZ/jUJbzi6GDaPR9 E7/iUGUX5R4Rs7xChJkrxTOo7ar7TEP3xuP+yZiXzhmcANBfXu3O4ND8CwiXdQGrnUwd /q4G9Grr7x0MqEyTYdBsgBzG9RUR+ppg3VjH+QPg5eJCMpYx/besXZvxBninrsVeTW6f Ip/waWRebKGFGAm2IwXi6aRD/jamne4dV0G6CflKypTrw3Jxy2OqDfihxqoPB/UEml4W rrfdnm9zQqDnPp/m8p5fe9jR3Tabwk6017fGadRM2s3r/grThcWrkweh6h9MOGMJmG0p dbRA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id u18si4275418wri.5.2019.08.01.04.12.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 04:12:21 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x71BCKRc000416 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Aug 2019 13:12:20 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.71]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x71BCJ8L007025; Thu, 1 Aug 2019 13:12:19 +0200 Date: Thu, 1 Aug 2019 13:12:19 +0200 From: Henning Schild To: Cc: , , , Vijai Kumar K Subject: Re: [PATCH] export GNUGPHOME for reprepro Message-ID: <20190801131219.33274775@md1za8fc.ad001.siemens.net> In-Reply-To: <20190725071504.24037-1-Vijaikumar_Kangarajan@mentor.com> References: <20190725071504.24037-1-Vijaikumar_Kangarajan@mentor.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 0qK9LtyCkwe0 Am Thu, 25 Jul 2019 12:45:04 +0530 schrieb : > From: Vijai Kumar K > > reprepro doesnot know about GNUPGHOME. If you trigger package feed > creation in a machine that has GNUPGHOME set, reprepro would not > know that it should use the new location and might use the keys it > find in the default ~/.gnupg directory. > > Make GNUPGHOME available for reprepro. > > Signed-off-by: Vijai Kumar K > --- > meta/classes/base-apt-helper.bbclass | 4 ++++ > meta/classes/dpkg-base.bbclass | 3 +++ > meta/recipes-devtools/base-apt/base-apt.bb | 3 +++ > meta/recipes-devtools/isar-apt/isar-apt.bb | 3 +++ > scripts/isar-buildenv-internal | 3 +++ > 5 files changed, 16 insertions(+) > > diff --git a/meta/classes/base-apt-helper.bbclass > b/meta/classes/base-apt-helper.bbclass index ba768da..a8f2a41 100644 > --- a/meta/classes/base-apt-helper.bbclass > +++ b/meta/classes/base-apt-helper.bbclass > @@ -30,6 +30,10 @@ populate_base_apt() { > compare_pkg_md5sums "$package" "$isar_package" && > continue fi > > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > + > # Check if this package is already in base-apt > isar_package=$(find ${REPO_BASE_DIR}/${BASE_DISTRO} -name > $base_name) if [ -n "$isar_package" ]; then > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 3e6ba8c..da13f86 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -120,6 +120,9 @@ repo_clean() { > > # Install package to Isar-apt > do_deploy_deb() { > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > repo_clean > reprepro -b ${REPO_ISAR_DIR}/${DISTRO} \ > --dbdir ${REPO_ISAR_DB_DIR}/${DISTRO} \ > diff --git a/meta/recipes-devtools/base-apt/base-apt.bb > b/meta/recipes-devtools/base-apt/base-apt.bb index 1c0b4c6..ca40b6c > 100644 --- a/meta/recipes-devtools/base-apt/base-apt.bb > +++ b/meta/recipes-devtools/base-apt/base-apt.bb > @@ -28,6 +28,9 @@ do_cache_config() { > path_databases="${REPO_BASE_DB_DIR}/${BASE_DISTRO}" > > if [ ! -d "${path_databases}" ]; then > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > reprepro -b ${path_cache} \ > --dbdir ${path_databases} \ > export ${BASE_DISTRO_CODENAME} > diff --git a/meta/recipes-devtools/isar-apt/isar-apt.bb > b/meta/recipes-devtools/isar-apt/isar-apt.bb index a959691..8f517fe > 100644 --- a/meta/recipes-devtools/isar-apt/isar-apt.bb > +++ b/meta/recipes-devtools/isar-apt/isar-apt.bb > @@ -20,6 +20,9 @@ do_cache_config() { > path_databases="${REPO_ISAR_DB_DIR}/${DISTRO}" > > if [ ! -d "${path_databases}" ]; then > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > reprepro -b ${path_cache} \ > --dbdir ${path_databases} \ > export ${DEBDISTRONAME} > diff --git a/scripts/isar-buildenv-internal > b/scripts/isar-buildenv-internal index 2476d90..7637d41 100755 > --- a/scripts/isar-buildenv-internal > +++ b/scripts/isar-buildenv-internal > @@ -67,4 +67,7 @@ BBPATH="${BUILDDIR}" > export BBPATH > > BB_ENV_EXTRAWHITE="BUILDDIR ISARROOT http_proxy https_proxy > ftp_proxy no_proxy" +if [ ! -z ${GNUPGHOME} ]; then > + BB_ENV_EXTRAWHITE="${BB_ENV_EXTRAWHITE} GNUPGHOME" > +fi Why did you go for conditional append for that one, while the others are unconditional? Henning > export BB_ENV_EXTRAWHITE