From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6717496001358200832 X-Received: by 2002:a5d:62cc:: with SMTP id o12mr2588498wrv.63.1564660338791; Thu, 01 Aug 2019 04:52:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:a557:: with SMTP id o84ls25164853wme.3.gmail; Thu, 01 Aug 2019 04:52:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqyexOZL4q5V6cGwUO6mqSJHIK+jE+xohSMMUoxY7aa2klbPCZd4RV9MTk6MIFFyS40N9ehM X-Received: by 2002:a05:600c:2102:: with SMTP id u2mr119074414wml.105.1564660338311; Thu, 01 Aug 2019 04:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564660338; cv=none; d=google.com; s=arc-20160816; b=lCdLtzReLFXnltKV5orLjXYzJkeiu26IOWBYu/SQMKnUirtaOpRo35qJk5iTHrn38I lbHwV8blZu5Dq5vs/pv9+ElCqXnE9HzdGlRpvg6AJKQPIc/8eBBT4CjnbWMPfUPBjubk XrV18OBzWJKPSQ3UEH5FbOZFF7uCGaWGcoTUti+EkUrRiqyfN2oMjuTftiGmTxU+5MBt 6MTNSuTtaLEtnDJJfIopTsA64tlOxelAprtMhO3SN5zjFPrS0SGxcle1sCTG3EHLuT4F nDsYELyfm9snLms5do5JqJOgB0irdwyNF3LZmWiXIOcjuJ4zTjExwd6kGnoDTWorWTD/ kDRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=1VVB9b/qN7X1Vb7DgL/nUpJQ9gjOLVq6xiLIFMubi/g=; b=QDm10FIByuDieNaEJIrShvtDmj+pJhi2+cU9jipiEOILla57SfGW/By4OjtF/KcvcP LMG0avoiFO5QxCd/4oQ6ZdBi7ot6MasIbg1qqD578tD+Glz6mt39SY9JdrOymFWJzBgN h9+jk9z1zm1/rpyM4fp3yeOKbHLzwis0j/oEuQldIyoGlfQOI7veR1iUmFzynBF1MlPG jNF9SqcupmQA3D2ugEWqULBpGHHVOs7Y0/7RE6ouQ6MNWwRUPH3G+LUiubavn6ZzgwWW HOyc/f8NEXgRYqydAP6whu2Ylr9KyrRn9W79mi+bJ0lvewlewR8yIf1235+rNLHOvLUD YJ2Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id o4si571900wrp.4.2019.08.01.04.52.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 04:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x71BqHuv004695 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Aug 2019 13:52:18 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.71]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x71BqH5C006150; Thu, 1 Aug 2019 13:52:17 +0200 Date: Thu, 1 Aug 2019 13:52:17 +0200 From: Henning Schild To: Baurzhan Ismagulov Cc: isar-users Subject: Re: [PATCH] export GNUGPHOME for reprepro Message-ID: <20190801135217.4c428c40@md1za8fc.ad001.siemens.net> In-Reply-To: <20190801114834.GK14716@yssyq.m.ilbers.de> References: <20190725071504.24037-1-Vijaikumar_Kangarajan@mentor.com> <20190801131219.33274775@md1za8fc.ad001.siemens.net> <20190801133818.3915d525@md1za8fc.ad001.siemens.net> <20190801114834.GK14716@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: IH9bjCNSj1Ty Am Thu, 1 Aug 2019 13:48:34 +0200 schrieb Baurzhan Ismagulov : > On Thu, Aug 01, 2019 at 01:38:18PM +0200, Henning Schild wrote: > > > >> Why did you go for conditional append for that one, while the > > > >> others are unconditional? > > > > > > > > GNUPGHOME might not be set in the host and hence went for the > > > > condition. BTW, I don't think having always would cause > > > > issues. > > > > If there is no reason for the condition please drop it. > > If I read the patch correctly, all uses of GNUPGHOME are conditional. > IIUC, we need conditions everywhere, because if it is not set in the > host environment, we'd end up setting it to an empty string, which I > assume we shouldn't do. Or have I overlooked anything? That variable that is appended has conditional built in, read the bitbake manual. Henning > With kind regards, > Baurzhan. >