From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6722331622445678592 X-Received: by 2002:a2e:9e81:: with SMTP id f1mr340154ljk.29.1565800280993; Wed, 14 Aug 2019 09:31:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:8c0c:: with SMTP id o12ls261099lfd.12.gmail; Wed, 14 Aug 2019 09:31:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/WoqMJRzEWtsR57Cb5eCeFKqncEfiRzmUlh7eNiySWaP0hxQcOIdGM/ubJ8oecHE7IXWq X-Received: by 2002:a19:48c5:: with SMTP id v188mr137566lfa.69.1565800280539; Wed, 14 Aug 2019 09:31:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565800280; cv=none; d=google.com; s=arc-20160816; b=qPsfnxMO03AlK7ZwennTUfqD/ITYyOCVnnY/+ixJcx6WxP1eXaCCQh/ncrZF7doRww e4aPurGeqJOn8Rn38FHlWf7UeVnXo4fjJtDFiOz5cgUL0YtAU6J1M7ihBYXivUcozSDm nrSRDRzqx6/XIwUxot5tk8znG2mLTBVQ5meF0Yz2KtzzkB22sQL+vdOlTJDcNAiIImYI HocRLseeFx71PLuec/H0D5Rx09V5fHSr/kF67LSp0I1mrAsAvAV6d+0jdtlLF6la+93z umiXh5i8F1HzzR9V1HTaYkrmRoxrQCoZpYipravmQqaBVlNeBsG2gcBHexmkeT/r0wCx UrTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=8r6r3QxTaNE1JyS/tSPOgkRhtqqa3xH5/r7hQRICEmg=; b=SIF+9OPlRsNMxA9+sq00Z+v2+516tC49bio8Ku5ddEuF4/l9pK6vsSXamvYVWrAOV7 8/HH0KQT+Zeoe0zA1X1qXtuxDQuKVMNagohqPrGBwPwVJ/5uApOjiXbsuoo4AKBATkgs VPviQNglptokElR45stGoU825EoNv1rZ1Wsp7jkD/bLi51Mxc1PNUFfH9cBpJzw2ysqe JsKyM/FHWsSaakzYSp0UDw2gWA4Aw0yYM4Lqtsqyx/Yzvz0hcVCAuAGvVHrzj6sMsZ7B ugzayXka+uKQQvehOLLv4apr7KgwJ4JUjSDZ2OoRvBgqJ7klRvIIKfwufFaRQRnQKmra 17rg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id q25si13184lfm.4.2019.08.14.09.31.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 09:31:20 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x7EGVJUE002784 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Aug 2019 18:31:19 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.68.225]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7EGVJ34022295; Wed, 14 Aug 2019 18:31:19 +0200 Date: Wed, 14 Aug 2019 18:31:19 +0200 From: Henning Schild To: Jan Kiszka Cc: "[ext] Q. Gylstorff" , , "[ext] Claudius Heine" Subject: Re: [PATCH] recipes-support: add fsck to initramfs Message-ID: <20190814183119.740050e0@md1za8fc.ad001.siemens.net> In-Reply-To: <389814ef-bbb9-32f7-e7b6-d5dba934bcaa@siemens.com> References: <20190807075908.17902-1-Quirin.Gylstorff@siemens.com> <20190813163615.0edcfa7c@md1za8fc.ad001.siemens.net> <389814ef-bbb9-32f7-e7b6-d5dba934bcaa@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: +nF6HmJsc/oJ Am Tue, 13 Aug 2019 17:01:16 +0200 schrieb Jan Kiszka : > On 13.08.19 16:36, [ext] Henning Schild wrote: > > Well it looks like the problem is the missing fstab > > line. /usr/share/initramfs-tools/hooks/fsck is looking for that to > > decide which fsck to include. > > > > There also seems to be /etc/fstab.d/*.fstab that can be used if we > > do not like touching the original fstab. I think Claudius once > > removed / from fstab claiming that it was not required. > > > > The package you get from that changes content based on an image > > variable. That must not be done. The fstypes would have to become > > part of PN or PV ... > > > > I think we should get that fstab line back. > > / is in fstab, but in a generic form. If you add a specific one, you > easily start duplicating wic. It's a chicken-egg thing: You need the > information during package installation, but you only have it after > imaging. > > BTW, there is enable-fsck for partially the same reason (there other > is that you do want to control whether fsck is run in embedded > scenarios). Fair enough. Let is control which fscks go into the initrd. But i am afraid we will need one package per file-system. I guess that should be easy to do with one recipe providing many packages. And which ones to include would be a matter of IMAGE_INSTALL += - And not a new variable. At least that sounds like a viable way to implement it. Henning > Jan >