public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 07/26] base: Clean up build task
Date: Mon, 26 Aug 2019 10:30:09 +0200	[thread overview]
Message-ID: <20190826101816.187e98e5@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <fd098396b7dbf76e71af91d5a2e3e66c6ee99c74.1566800787.git.jan.kiszka@siemens.com>

Am Mon, 26 Aug 2019 08:26:08 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This is now an empty one that should no longer be executed. Align with
> OE in this regard.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/base.bbclass | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 1d2852a..8c7b021 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -181,14 +181,12 @@ python do_unpack() {
>  
>  addtask unpack after do_fetch before do_build
>  
> -addtask build
> -do_build[dirs] = "${TOPDIR}"
> -python base_do_build () {
> -    bb.note("The included, default BB base.bbclass does not define a
> useful default task.")
> -    bb.note("Try running the 'listtasks' task against a .bb to see
> what tasks are defined.") +do_build[noexec] = "1"
> +do_build () {
> +    :
>  }

This actually once came from bitbake/classes/base.bbclass

You might want to compare with that.

the default does not have noexec but it does have nostamp

> -EXPORT_FUNCTIONS do_build
> +addtask build

The default bitbake one has both of these lines.

Henning

>  CLEANFUNCS ?= ""
>  


  reply	other threads:[~2019-08-26  8:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26  6:26 [PATCH 00/26] Tons of fixes and cleanups Jan Kiszka
2019-08-26  6:26 ` [PATCH 01/26] isar-bootstrap: Consider DISTRO_BOOTSTRAP_KEYS for gnupg installation Jan Kiszka
2019-08-26  6:26 ` [PATCH 02/26] isar-bootstrap: Fix keyring generation Jan Kiszka
2019-09-27 12:03   ` Baurzhan Ismagulov
2019-08-26  6:26 ` [PATCH 03/26] isar-bootstrap: Install DISTRO_BOOTSTRAP_KEYS Jan Kiszka
2019-08-26  6:26 ` [PATCH 04/26] Rework STAMP layout and cleaning Jan Kiszka
2019-08-26  8:30   ` Claudius Heine
2019-08-26  8:38     ` Jan Kiszka
2019-08-26  6:26 ` [PATCH 05/26] dpkg: Fix shared-locking of build task Jan Kiszka
2019-08-26  6:38   ` Cedric Hombourger
2019-08-26  8:30   ` Claudius Heine
2019-08-26  8:38     ` Jan Kiszka
2019-08-26  6:26 ` [PATCH 06/26] dpkg-base: Free do_build task Jan Kiszka
2019-08-26  6:26 ` [PATCH 07/26] base: Clean up build task Jan Kiszka
2019-08-26  8:30   ` Henning Schild [this message]
2019-08-26  8:40     ` Jan Kiszka
2019-08-26  6:26 ` [PATCH 08/26] isar-events: Do not start cleanup early Jan Kiszka
2019-08-26  6:26 ` [PATCH 09/26] meta-isar: Move bananapi to buster, remove bogus example Jan Kiszka
2019-09-04  6:53   ` [PATCH v2 " Jan Kiszka
2019-08-26  6:26 ` [PATCH 10/26] bitbake.conf: Reorder PV definition Jan Kiszka
2019-08-26  6:26 ` [PATCH 11/26] example-module: Fix build with mipsel target Jan Kiszka
2019-08-26  6:26 ` [PATCH 12/26] buildchroot: Ignore ISAR_CROSS_COMPILE for i386 on stretch Jan Kiszka
2019-08-26  6:26 ` [PATCH 13/26] buildchroot: Fix downgrades when installing dependencies Jan Kiszka
2019-08-26  6:26 ` [PATCH 14/26] buildchroot: Properly deploy the build result Jan Kiszka
2019-08-26  6:26 ` [PATCH 15/26] sdk: Use clean-package-cache rather than open-coded cleanup Jan Kiszka
2019-08-26  6:26 ` [PATCH 16/26] sdk: Deploy earlier Jan Kiszka
2019-08-26  6:26 ` [PATCH 17/26] Remove unneeded PF tweakings Jan Kiszka
2019-08-26  6:26 ` [PATCH 18/26] image: Stop changing PF, tune WORKDIR and STAMP directly Jan Kiszka
2019-08-26  8:35   ` Henning Schild
2019-08-26  8:40     ` Jan Kiszka
2019-08-26  6:26 ` [PATCH 19/26] image: Make WORKDIR and STAMPs IMAGE_TYPE-specific Jan Kiszka
2019-08-26  6:26 ` [PATCH 20/26] Adjust STAMP variables to use PN, rather than PF Jan Kiszka
2019-08-26  6:26 ` [PATCH 21/26] Align WORKDIR structure with OE Jan Kiszka
2019-08-26  6:26 ` [PATCH 22/26] isar-bootstrap: Clean up and fix rebuild Jan Kiszka
2019-09-21  8:28   ` Jan Kiszka
2019-08-26  6:26 ` [PATCH 23/26] gitlab-ci: Keep logs as artifacts on failure Jan Kiszka
2019-08-26  6:26 ` [PATCH 24/26] Detect false sharing of recipes Jan Kiszka
2019-08-26  6:26 ` [PATCH 25/26] dpkg-base: Move do_deploy_deb before do_build Jan Kiszka
2019-08-28  7:32   ` Claudius Heine
2019-10-01 11:49     ` Baurzhan Ismagulov
2019-08-26  6:26 ` [PATCH 26/26] base-apt: Move do_cache_config " Jan Kiszka
2019-08-26 21:29 ` [PATCH 27/26] wic-img: Use private tmp dir Jan Kiszka
2019-08-27 15:00   ` [PATCH v2 " Jan Kiszka
2019-10-01 14:43 ` [PATCH 00/26] Tons of fixes and cleanups Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826101816.187e98e5@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox