From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6727677240025284608 X-Received: by 2002:a2e:85d4:: with SMTP id h20mr18863330ljj.134.1567497414278; Tue, 03 Sep 2019 00:56:54 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:87d5:: with SMTP id v21ls1790043ljj.5.gmail; Tue, 03 Sep 2019 00:56:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEZmS31u3C4JmkJd7Zoh1xINwsh8VmUqDU1Oq5g/VBkZrbC3THYkWnAI50gRGBPf+yYoy+ X-Received: by 2002:a2e:8747:: with SMTP id q7mr6724307ljj.100.1567497413711; Tue, 03 Sep 2019 00:56:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567497413; cv=none; d=google.com; s=arc-20160816; b=NqUN91UBMRBJDWdlcqRZ8ZaHhXJswnUt9STiNjOfVyD12bSy3TxLoYOKmUi4Go7flL +agHBp8NJCbyfoPkEnjNlOeIbn0r5kIEYexfPsoLhpgffcumf0iQxcijwbIyG1otNQK7 YePYJAxt3eJXnQUaSPjvWOjkDSskOZHS+bGUY4z+t1rZqK226KxwgjxMwpIJ5/HU9P3q JbWDtSzx5nANXs6k2BH1HMDseNdI4WMgrvEzz1mbnb9SgN+gdnjHljhpGCV825KTMdCL hkiGfPf1GXq+tbrvQpPHJaxVft6/ZKiORMvTa5WXV+uOKyok8MVr4adyb4zQSMz2S0eH UQ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=Vd3229YWY5c5k62p0pWuewcGfrDBLOnz2qsJlUWXql4=; b=erio6jU1xTEGI4Lb6cUF2nzsoZdRXtd50OILYzojyoLmbragBAXaJWNlDnwY2612E3 zG3iSE8G/ILFmkg5A8LDmWGeBSSewCX09sF3ycKZKHr9X1i2t/c2WzUoJ/ZDZR3Zj7KZ B2sGY1MQxRNRTT+QA463DS+q6bHAiFPuPEXy1M+2e1cbDD+B81bQkL7aYbMLDUR+IQf+ 0fYp69BGS7QS3JXDwlCyRn/l0ZixsbFW37lOD8AnpQB/xWjd22DMwaFSmh4k+G4v7fAz N34RGZd01LeR3nFYPmEYXPPb1NNKmcXssYrqTyHSNDZ5aBjmn6GAdpXYO8DiiySDQCWr c4KQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Hm3r1r1Z; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com. [2a00:1450:4864:20::441]) by gmr-mx.google.com with ESMTPS id i21si726687ljj.1.2019.09.03.00.56.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2019 00:56:53 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) client-ip=2a00:1450:4864:20::441; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Hm3r1r1Z; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x441.google.com with SMTP id y8so16301295wrn.10 for ; Tue, 03 Sep 2019 00:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Vd3229YWY5c5k62p0pWuewcGfrDBLOnz2qsJlUWXql4=; b=Hm3r1r1Z4+DFzP+Esv8t/+arBOBbtcN+NihStpbRtHjT9L3+rOhW0VsTXzB4mvE4F+ BeTlM2c+pUnT4PLiDGeJAQpiFJLkJRCc+sx/tfTffyh4h6JoJ/dzVblJ3SXyKHGY0wW2 hS1+S9nTgQxfT6BVqyy7IGgKRkxmBWfSYK+gUs9pect/3/rSEL7i7fO4HSbDWkJ6tK65 xVyD5c1DRCxNilEaerJD755FQgI3jL5/XCI8HNTkKlg+lQJ0Rr03XmO48rLitCLH+OIl ofY/DwV6iMgcIZ9W+S0eE0o7RxDAwImr3GADW0g9lJGLvPxXhUDYoUgGopyk8QHWYA66 P/4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Vd3229YWY5c5k62p0pWuewcGfrDBLOnz2qsJlUWXql4=; b=p/PuHdyv3iqy97bqDYh7KHSM1c6IZNTDtjfiuQMGM9uVWMaavokuvw8X7oOSfgDbP7 +g2paHjdJ0DXuNFKRyhuHnVhtUEVqXc7ewDAkSoCvDcP7A0gEt9R673iD51MzBvgSj6x o/1oExnEGIAGQU8cb+xdYTMVRchzC+vhlmPD1O/GzMY2QR/p/gCTUSnDN6NOvQVLgAy5 Lan7Vuua/gv8L3wKdWQ9IAcuuYON8da1nDRbcko2CjkLfiLM/au9svCblcmVP1WtXSJn OQWJ4rVQoKYh4DDQDaExe5i91OU+MI/xOgMTtaxiFLEXZUQuKelzZg11DnGbs31n/Lt3 B5AA== X-Gm-Message-State: APjAAAX/8uOb3hU/JIbTBNy1gN8qfhP6y706w2aV3e5QKvAdNO5qJz/3 AC9ChyCDHBbDeBuABUVnzSg= X-Received: by 2002:adf:82d4:: with SMTP id 78mr38930767wrc.85.1567497413000; Tue, 03 Sep 2019 00:56:53 -0700 (PDT) Return-Path: Received: from chikyu (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id q19sm33470251wra.89.2019.09.03.00.56.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Sep 2019 00:56:52 -0700 (PDT) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Tue, 3 Sep 2019 13:26:46 +0530 To: Jan Kiszka , ibr@radix50.net, claudius.heine.ext@siemens.com Cc: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com Subject: Re: [PATCH v2] scripts: Avoid adding duplicate entries to PATH Message-ID: <20190903075646.GA22407@chikyu> References: <199abc3d-5887-7011-c4be-b08b909c1a04@siemens.com> <20190821184837.7279-1-Vijaikumar_Kangarajan@mentor.com> <85a07645-8597-8db5-bd29-a515a0842f0a@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85a07645-8597-8db5-bd29-a515a0842f0a@siemens.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: v5OIC6O0LNrg On Wed, Aug 21, 2019 at 09:00:28PM +0200, Jan Kiszka wrote: > On 21.08.19 20:48, vijaikumar.kanagarajan@gmail.com wrote: > > From: Vijai Kumar K > > > > If the setup script is run multiple times in the same shell session, > > PATH variable gets overpopulated with duplicate entries. Remove any > > existing entries before adding. > > > > Signed-off-by: Vijai Kumar K > > --- > > Changes in v2: > > - Unset newpath > > > > scripts/isar-buildenv-internal | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-internal > > index 2186e40..72a91ab 100755 > > --- a/scripts/isar-buildenv-internal > > +++ b/scripts/isar-buildenv-internal > > @@ -60,7 +60,15 @@ unset BDIR > > export BUILDDIR > > -PATH=$ISARROOT/bitbake/bin:$ISARROOT/scripts:$PATH > > +for newpath in "$ISARROOT/bitbake/bin" "$ISARROOT/scripts"; do > > + # Remove any existences of $newpath from $PATH > > + PATH=$(echo $PATH | sed -re "s#(^|:)$newpath(:|$)#\2#g;s#^:##") > > + > > + # Add $newpath to $PATH > > + PATH="$newpath:$PATH" > > +done > > +unset newpath > > + > > export PATH > > BBPATH="${BUILDDIR}" > > > > Reviewed-by: Jan Kiszka > > Thanks, > Jan Can this be merged?? Thanks, Vijai Kumar K > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux