Re: [PATCH] Add support for supplying more types of debian package relationships

[Henning Schild <henning.schild@siemens.com>]

Hi Konstantinos,

improving the debianizer is a good idea in general. But i would shy
away from trying to cover special corner cases. Not sure whether your
changes are corner or common cases.

Best practice is that your sources are already debianized, that
benefits everyone, also outside of Isar.

Special cases can already be modeled with deb_debianize if the
generated special-case files are already in WORKDIR. So if is is a rare
case it might be better to just carry that control file in FILESDIR and
SRC_URI. Or you generate the file in your recipe.

Could you explain how "common" that use-case is and why you prefer
using Isar-generated debianization over having a (maybe generated)
debianization in your sources?

Henning

Am Wed, 11 Sep 2019 08:41:45 +0000
schrieb "[ext] Dalamagkidis, Konstantinos"
<konstantinos.dalamagkidis@siemens.com>:

> We need to be able to specify other package relationships, such as
> Pre-Depends or Provides/Replaces/Conflicts.
> 
> This change supports supplying DEBIAN_PREDEPENDS, DEBIAN_REPLACES,
> DEBIAN_CONFLICTS and DEBIAN_PROVIDES, as well as bitbake-style
> RDEPENDS or RDEPENDS_{PN} variables. The DEBIAN_* take priority.
> 
> Signed-off-by: Konstantinos Dalamagkidis
> <konstantinos.dalamagkidis@siemens.com> ---
>  meta/classes/debianize.bbclass | 19 +++++++++++++++++++
>  meta/classes/dpkg-raw.bbclass  |  1 -
>  2 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/debianize.bbclass
> b/meta/classes/debianize.bbclass index ad3a98e..26002c5 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -5,6 +5,21 @@
>  
>  CHANGELOG_V ?= "${PV}"
>  
> +DEBIAN_DEPENDS ??= "${@deb_get_relationship(d, 'RDEPENDS')}"
> +DEBIAN_PREDEPENDS ??= "${@deb_get_relationship(d, 'RPREDEPENDS')}"
> +DEBIAN_CONFLICTS ??= "${@deb_get_relationship(d, 'RCONFLICTS')}"
> +DEBIAN_REPLACES ??= "${@deb_get_relationship(d, 'RREPLACES')}"
> +DEBIAN_PROVIDES ??= "${@deb_get_relationship(d, 'RPROVIDES')}"
> +
> +def deb_get_relationship(d, relationship):
> +    rel = d.getVar(relationship + '_' + d.getVar('PN', True), True)
> +    if rel:
> +        return rel
> +    rel = d.getVar(relationship, True)
> +    if rel:
> +        return rel
> +    return ""
> +
>  deb_add_changelog() {
>  	timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*"
> -printf "%T@\n"|sort -n -r|head -n 1) if [ -n "${timestamp}" ]; then
> @@ -42,6 +57,10 @@ Build-Depends: debhelper (>= ${compat})
>  Package: ${PN}
>  Architecture: any
>  Depends: ${DEBIAN_DEPENDS}
> +Pre-Depends: ${DEBIAN_PREDEPENDS}
> +Replaces: ${DEBIAN_REPLACES}
> +Conflicts: ${DEBIAN_CONFLICTS}
> +Provides: ${DEBIAN_PROVIDES}
>  Description: ${DESCRIPTION}
>  EOF
>  }
> diff --git a/meta/classes/dpkg-raw.bbclass
> b/meta/classes/dpkg-raw.bbclass index ea03ea4..0c484fc 100644
> --- a/meta/classes/dpkg-raw.bbclass
> +++ b/meta/classes/dpkg-raw.bbclass
> @@ -5,7 +5,6 @@
>  
>  inherit dpkg
>  
> -DEBIAN_DEPENDS ?= ""
>  MAINTAINER ?= "Unknown maintainer <unknown@example.com>"
>  
>  D = "${S}"