From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] dpkg-base: Permit multiple clean runs
Date: Tue, 17 Sep 2019 11:11:18 +0200 [thread overview]
Message-ID: <20190917111118.63dc1c4c@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <294fb8c3-d3d0-56be-114f-5738778d78e2@siemens.com>
Am Mon, 16 Sep 2019 08:46:07 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> "find ${S}/.." fails if the is no ${S} anymore.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/dpkg-base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg-base.bbclass
> b/meta/classes/dpkg-base.bbclass index c86d0b3..e814208 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -102,7 +102,7 @@ addtask dpkg_build before do_build
> CLEANFUNCS += "repo_clean"
>
> repo_clean() {
> - DEBS=$( find ${S}/.. -maxdepth 1 -name "*.deb" )
> + DEBS=$( find ${S}/.. -maxdepth 1 -name "*.deb" || true )
"|| true" swallows too many potential errors
go for
[ ! -d ${S} ] && return 0
Henning
> if [ -n "${DEBS}" ]; then
> for d in ${DEBS}; do
> p=$( dpkg-deb --show --showformat '${Package}' ${d} )
prev parent reply other threads:[~2019-09-17 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 6:46 Jan Kiszka
2019-09-17 9:11 ` Henning Schild [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917111118.63dc1c4c@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox