From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] rootfs: Take isar-apt shared lock during repository
Date: Wed, 18 Sep 2019 15:46:41 +0200 [thread overview]
Message-ID: <20190918134641.ygwc32ktdy62gb5k@yssyq.m.ilbers.de> (raw)
In-Reply-To: <96728688-e707-9e8f-4f32-9ded7b5300b4@siemens.com>
On Tue, Sep 03, 2019 at 07:41:40AM +0200, Jan Kiszka wrote:
> We take this lock already for install_imager_deps, but we also need it
> conceptually for the rootfs installation. Also here, pulling from
> isar-apt can race with not-yet finished deployments of parallel builds,
> even if the target package is not shared. See e9a5d8adf6b5 for further
> details.
>
> To avoid holding the lock across the whole lengthy package installation,
> introduce command flags that define the beginning and the end of the
> locked section so that do_rootfs_install can manage that.
Looks good to me.
The title "rootfs: Take isar-apt shared lock during repository" sounds
incomplete. Do you mean something like "rootfs: Take shared lock reading
isar-apt"?
With kind regards,
Baurzhan.
prev parent reply other threads:[~2019-09-18 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 5:41 Jan Kiszka
2019-09-18 13:46 ` Baurzhan Ismagulov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918134641.ygwc32ktdy62gb5k@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox