From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6732315292542697472 X-Received: by 2002:a7b:c3c6:: with SMTP id t6mr2971519wmj.5.1568814405099; Wed, 18 Sep 2019 06:46:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:99d7:: with SMTP id b206ls991903wme.2.canary-gmail; Wed, 18 Sep 2019 06:46:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzjfiSsJVSdBS50eCYH6+jfQQx/mjyU2xS73BuLZZ/EKPqtAt2o9eMYKztwr+9jIAtnZbXE X-Received: by 2002:a1c:f002:: with SMTP id a2mr3228042wmb.113.1568814404563; Wed, 18 Sep 2019 06:46:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568814404; cv=none; d=google.com; s=arc-20160816; b=r1YtQrfc59f5x6x/kZnsNv92irliXSyBEEg4YIOZPac8VWODCC7vqUXSLgPaOND1d/ dV5kR3Ly6xuuyem5N5MopsQ5Qk8Y0pZJDoDUNQvpI47PrRk9mDlBfqKRXjEQPXzNGVxR +phmOe+BGkQu6FqIrZrAiFmmpf38bB0LwZbhfxuFMDLia/4MttK0IDm2pr5Ah2aIDyOd GU8ga3doCANw6kAmqoYcyUUtByKCloXjXPTugXf+nCh5w8rtfq4NvSu/QGUpC/7EIRED agKDLP5K4gCZZWzEw4m1rNku5o4gdHDAj8ugShYyGsJ63P68+6Hqs7NKP1v7wHwtJ/RC ebXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=I6N4ziRGy//ozdxIBCi7eDd+A4ml2kzCYmUDHDfLan4=; b=O/gdIFE7Z5PEWbUEtLYopmXxGfLPSgCf2SpjLBMJPm4kD84sBEbDjrnllyI+0eFUZK eX8QBohd4LDLKifni09zXhs8APh/+wvT+agqwcBk/mGiDfpPRM3gA6mb4H4zZqL3tyAN GTw70nvWtWU9mU4T4OpqUFfX7fpKggbIUSOtaderLMp3pSb5HZJxP2C/h+u66/bh9zy5 IAv2zuza8UkE3hGMI5PFEdPtMKII/mwqjHzFOg//kFO0ah+nuxDewzU0OxQFQqLi8XfU ltTMxBm89INODQw6FXKjOmiFb/oBbbjTedbfWa2jz0YShnuJicYLFwRjzeexxCXt0gTg Iw/Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id s194si262709wme.2.2019.09.18.06.46.44 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2019 06:46:44 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x8IDkfL6015492 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 18 Sep 2019 15:46:43 +0200 Date: Wed, 18 Sep 2019 15:46:41 +0200 From: Baurzhan Ismagulov To: isar-users Subject: Re: [PATCH] rootfs: Take isar-apt shared lock during repository Message-ID: <20190918134641.ygwc32ktdy62gb5k@yssyq.m.ilbers.de> Mail-Followup-To: isar-users References: <96728688-e707-9e8f-4f32-9ded7b5300b4@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96728688-e707-9e8f-4f32-9ded7b5300b4@siemens.com> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: TtS+qs/Os6Kh On Tue, Sep 03, 2019 at 07:41:40AM +0200, Jan Kiszka wrote: > We take this lock already for install_imager_deps, but we also need it > conceptually for the rootfs installation. Also here, pulling from > isar-apt can race with not-yet finished deployments of parallel builds, > even if the target package is not shared. See e9a5d8adf6b5 for further > details. > > To avoid holding the lock across the whole lengthy package installation, > introduce command flags that define the beginning and the end of the > locked section so that do_rootfs_install can manage that. Looks good to me. The title "rootfs: Take isar-apt shared lock during repository" sounds incomplete. Do you mean something like "rootfs: Take shared lock reading isar-apt"? With kind regards, Baurzhan.