From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Henning Schild <henning.schild@siemens.com>
Subject: [PATCH v2 2/3] dpkg-base: ignore binary packages for "apt-get source"
Date: Fri, 20 Sep 2019 09:22:11 +0200 [thread overview]
Message-ID: <20190920072212.7764-3-henning.schild@siemens.com> (raw)
In-Reply-To: <20190920072212.7764-1-henning.schild@siemens.com>
From: Henning Schild <henning.schild@siemens.com>
A buildchroot might already know the new/rebuild version of an upstream
package as a binary coming from isar-apt. Now apt-get source will try
to fetch that one instead of the upstream version that we rebuild to
produce the new one.
Not that ignoring binaries also means we loose the vague version
matching, inform users about that.
This problem can be seen in partial rebuild scenarios and the switch
solves it, at least until we do have sources in isar-apt. Having sources
there, the best idea would probably be to choose the exact upstream
version to rebuild, to not find our own in an incremental build.
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
RECIPE-API-CHANGELOG.md | 7 +++++++
meta/classes/dpkg-base.bbclass | 3 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index bbef1a3..1f29eb2 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -149,6 +149,13 @@ default).
Changes in v0.8
---------------
+### `apt://` SRC_URIs where added and briefly changed their version picking way
+
+Recipes that use SRC_URIs with `apt://` and choose a version with `=` had a
+partial matching feature for a short time between 0.7 and 0.8. In 0.8 the
+version has to be the exact upsteam match.
+It is probably best to not specify a version if you can.
+
### `isar-image.bbclass` class will be deprecated in future version of isar
The content of `isar-image.bbclass` was moved to the `image.bbclass` file.
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 1deccd4..f77eb7b 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -34,8 +34,9 @@ do_apt_fetch() {
-o Dir::Etc::SourceList="sources.list.d/isar-apt.list" \
-o Dir::Etc::SourceParts="-" \
-o APT::Get::List-Cleanup="0"
+
sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
- sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}'
+ sh -c 'cd ${PP} && apt-get -y --only-source source ${SRC_APT}'
dpkg_undo_mounts
}
--
2.21.0
next prev parent reply other threads:[~2019-09-20 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 7:22 [PATCH v2 0/3] test apt:// fetcher Henning Schild
2019-09-20 7:22 ` [PATCH v2 1/3] meta-isar/recipes-app: change SRC_URIs of hello rebuild example Henning Schild
2019-09-20 7:22 ` Henning Schild [this message]
2019-09-20 7:22 ` [PATCH v2 3/3] ci: add rebuilding hello to test apt:// fetching Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920072212.7764-3-henning.schild@siemens.com \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox