From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6741467829768290304 X-Received: by 2002:a2e:88cd:: with SMTP id a13mr11235052ljk.102.1569826023153; Sun, 29 Sep 2019 23:47:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:f613:: with SMTP id x19ls999024lfe.16.gmail; Sun, 29 Sep 2019 23:47:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyT4Kmf+NZmMGGU4wW77yyoDb5MG2rtJ8Ic4GLMpwXjLAivgjTIHJjWZuWqOL55tS2gCm1u X-Received: by 2002:a19:4912:: with SMTP id w18mr9917280lfa.93.1569826022086; Sun, 29 Sep 2019 23:47:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569826022; cv=none; d=google.com; s=arc-20160816; b=sIijuLHqnRlL+kX7wzzTCIXUXrW4lG47mKOCpwm06SamTSuozH5AxeuSWIIZEmnRG7 ttfvm1XQCE4iYt/1OWi+T2l9xwXECNyaFhBNof176hzlyG5w1RaitcwuePLjp1AUJ2zy yjZr8nD+ty2CbgeDqTpTdLKJ8H6ltcPvVxzsYKmrIdg5UZlgd3e3tyg+45rANMlt5pQD HiutMqhxKppF7UYs6Vy0CvMiWwcOvWSgf1+gRXtLunw/eBNCh1no/Dyb7MobRyb6a6lj zEXpqv/dYThA7O09SUXABwaXojCQ98imIgTBVxtIq9/rXImx9br9wJiESCjv357X2u3A ferg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=RbIomA6+CLefq+wvxJV5MjGsmxL00VNkti1jKe/jgUs=; b=oXa3l1AmrYC+DnDNiGy/zH2Dk+gDUDdTqzOT7qTpGoU2RUS+FqQOOsxen3aYd7jl0l X5YRtJLLhIgZD7snyAzmgRzMy0Fp8fda3WTbX9/Dn+TDBcxFlTPxSOoDUkZKYEo0fpG+ kfXCMEDNYrF3+QU+OfOtSGjRdgZJECmBGKQgmVyp1RS3S8kyHSlJIVtzYY3wPw7OLnYl KZ+Xn9EbuVkoJsYGi2RFvSuZhjU1Urc5JKUwpy4FE2iCAwJR8n1v08C5PxxazN/gIwjm VYATCxwX0JP2guYIu62fcHUFEfMe1ulG+zcw4RAz2Y3cN/EqHIe1QL233f+8OTtc08Gn d97Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WGB9yEIJ; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com. [2a00:1450:4864:20::442]) by gmr-mx.google.com with ESMTPS id u24si593869lfg.2.2019.09.29.23.47.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Sep 2019 23:47:02 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) client-ip=2a00:1450:4864:20::442; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WGB9yEIJ; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::442 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x442.google.com with SMTP id n14so9773181wrw.9 for ; Sun, 29 Sep 2019 23:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RbIomA6+CLefq+wvxJV5MjGsmxL00VNkti1jKe/jgUs=; b=WGB9yEIJ13ZdDFqAreRU9bPIM/ovHvmNEiy9G8O9y9hj40aGusuhKQK7sxy1Ll/bo3 wSIGbtCvgIZFqkEeGovQkF9pI2RaDTyTdTTL8CqfN5jfYdYmwhBArR/GGZrfecOe594j Wh0neDjylbh2zPtNyj3KQviz8VY21kp5tLPwxr7HxSDEjfgPGH5mAhi3R78gJBKF/91Y RiAHtAkofmkrb/4INNDtiiba3vNWUO1EgrR3ub5PhGne8AqdlqxsR29CuH8KpAUxK5nv Ar8OrdypjTemAQLxYECTVOwmZqZlXPRkXV8elkLknIFG4I7rhLmOqc7QPbiv1KaNy60u XJmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RbIomA6+CLefq+wvxJV5MjGsmxL00VNkti1jKe/jgUs=; b=mf32pq/Zap6A5FrW8Bz1/sIYJZnF5hUyeCDHrk8JQjcPehfJKbKDgSnJu+UGqdh+94 dqr8dThV2VMPHdC8hEEnjHuWdK/b5OhBrLcssvlw5iEPB2P/YRH3U6e33lS2xEreZJRO lX6JCW8ve4bDHiOUkd8C44alrTWRpvKYxEEemhJyPcBnFYW+4s3Wer8BZqxhI3EzKolS IopWpXLUmGQ0tREHhxsVtABY0LMsVDgDJk+QE6zPW5aUhWgaNu46WqnvCUvBRQTZiOOl 2XEKbyih4SE30cq/amPkbYuEVmBybNYcpK57oXpzJYnMMmPvRuobBZlY4EFVY17qBvaD /1oQ== X-Gm-Message-State: APjAAAUVJs9LUf5ONci8TLSWkpPH39XLsfTiWDYi+372wYk5+j6d7tN0 8SYHCxbggZV35jriVdwGy48/w/wnS4k= X-Received: by 2002:adf:e701:: with SMTP id c1mr12242930wrm.296.1569826021428; Sun, 29 Sep 2019 23:47:01 -0700 (PDT) Return-Path: Received: from lightning (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id d28sm16716533wrb.95.2019.09.29.23.46.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Sep 2019 23:47:00 -0700 (PDT) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Mon, 30 Sep 2019 12:16:55 +0530 To: Jan Kiszka Cc: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Subject: Re: [PATCH v2] isar-init-build-env: Always set ISARROOT Message-ID: <20190930064655.GA10223@lightning> References: <20190927213804.31651-1-Vijaikumar_Kangarajan@mentor.com> <20190927214352.32114-1-Vijaikumar_Kangarajan@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: 8EHPvLRLoWvm On Mon, Sep 30, 2019 at 08:06:14AM +0200, Jan Kiszka wrote: > On 27.09.19 23:43, vijaikumar.kanagarajan@gmail.com wrote: > > From: Vijai Kumar K > > > > When switching between two ISAR workspaces in the same shell > > session, the ISARROOT setting of the previous workspace would be > > picked up for the new workspace resulting in an incorrect > > configuration. > > > > Always set ISARROOT irrespective of whether it is empty or not. > > > > Signed-off-by: Vijai Kumar K > > --- > > Changes in v2: > > - Remove redundant code > > > > isar-init-build-env | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/isar-init-build-env b/isar-init-build-env > > index b08bb59..404efcb 100755 > > --- a/isar-init-build-env > > +++ b/isar-init-build-env > > @@ -42,13 +42,10 @@ if [ -z "$ZSH_NAME" ] && [ "$0" = "$THIS_SCRIPT" ]; then > > exit 1 > > fi > > -if [ -z "$ISARROOT" ]; then > > - ISARROOT=$(dirname "$THIS_SCRIPT") > > - ISARROOT=$(readlink -f "$ISARROOT") > > -fi > > +ISARROOT=$(dirname "$THIS_SCRIPT") > > +ISARROOT=$(readlink -f "$ISARROOT") > > unset THIS_SCRIPT > > -ISARROOT=$(readlink -f "$ISARROOT") > > export ISARROOT > > . "$ISARROOT/scripts/isar-buildenv-internal" "$1" && \ > > TEMPLATECONF="$TEMPLATECONF" "$ISARROOT/scripts/isar-setup-builddir" || { > > > > OE is doing the same, i.e. does not update OEROOT on second execution. This > allows to set OEROOT prior to calling the script (https://github.com/openembedded/openembedded-core/commit/3327e2a9222004d8ac7974cb1d9fe77c81176cfc). Yes. But then OE also unsets OEROOT later in that script. But with our below change we are no longer doing the same. https://github.com/ilbers/isar/commit/b59cf9ef8aae682937e8a4a5cda1c6d080d329b7 Thanks, Vijai Kumar K > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux