From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6741467829768290304 X-Received: by 2002:a17:906:25ca:: with SMTP id n10mr18219603ejb.106.1569829764866; Mon, 30 Sep 2019 00:49:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:f11b:: with SMTP id w27ls1890471edl.1.gmail; Mon, 30 Sep 2019 00:49:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3dXCial34nGkfYdGlCjpOVJNbPmd19ILlg0HZfaNaN5yxDS8bDflOeW/ipl+vxiW15jxu X-Received: by 2002:aa7:c343:: with SMTP id j3mr18265847edr.187.1569829764300; Mon, 30 Sep 2019 00:49:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569829764; cv=none; d=google.com; s=arc-20160816; b=HHgMQzYXdNWiCj7QEww3UBo2SbujWtQvASL1mnBHyHgzA5fWjgXzqBxC2OYUasDumo YabZ4WmoFQ34JZcm8TfuE7qieRqXrmeWJdUfkRGYZSKLUDVfBhUdhZRgCOr91XPjDh5X ObqChu8WvGZl0rCKOOI0RDAHrjIiQfvHC+cI01Wy0I/6X4MMGWoG673IhMnEtHFMM78I NmsdOZL2DNiTaWJViqJasjEhzodXb/+flAVv7tX1LATSGaNDdn+qdlKLj3ksPH1ogPML hYyQ642EwUSdP7bgIT3pwkSui7hcj1xvjtLIcMqGKmBocfY2guddUhCY84hKsYxUxS0U wfvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=sZB2ThHnrXPSmcj9QXVawi50Kr2yKxtlSOa8e2JP6R4=; b=dYAwL/UGU69QmWz5u+fSZnLKzDk2NQMxpGtvRazZKfm+O3Whv8kMOm19LtIWPachh4 MN58ZDVFMW1E0rtIzKnNwrZp1894WDuUtJL8M0wtNb65tW1didTADFGrKIbCRPTFGGh8 VQJ/ddKCeBnQJbBd3rxiJFLMppO8KYhnTq0Hss0EaBCOodaTmF9h6oE2erzLl3PxtukJ nrbBAnn5Qxh8dQfP8stFmxsMDFTReAKQlax3OqLb1ABXz3Ha5bTBcyw7gKiy986Pyhkx gkXQ8um5gZ6+OVrGgWjb8Byf1qzoZ+cM4hOA007Xu6Rd/jY5iZc47DodIY1KVGULQb3q yEAg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KJJINJiH; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com. [2a00:1450:4864:20::343]) by gmr-mx.google.com with ESMTPS id r3si858275eds.2.2019.09.30.00.49.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2019 00:49:24 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) client-ip=2a00:1450:4864:20::343; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KJJINJiH; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x343.google.com with SMTP id r19so12155093wmh.2 for ; Mon, 30 Sep 2019 00:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sZB2ThHnrXPSmcj9QXVawi50Kr2yKxtlSOa8e2JP6R4=; b=KJJINJiHQX6lWMP8UI1mjak6YfHkiie2cjVD30SX3s4AE/EZKaT3ywWeaRFyxnUAft j8FNpKcnczq91QkORV2sO4J+ur3F4a7qgWNK3OD6TTRs1oRMYBJo4eu7bPCvUL0RLGGp MT54pLwhIu9rA+uVu1FzseD+Z2xuwbBfqFzu+7tlEQedd9ITKvBLp+QjTpnUUalGe0pA qZMRg7RtSj4ZfOx98tbx4WSsuZphSbr4p07GT7mMnvYrirCw0Q/Tu4AL59fCq5fmDN/0 dWc6Cb8wMQTrG23lVqlQzUHhtvGIrNMOBEI7hITWLIzFi5TmQz1A8Vxyrjidawe60ILt sGBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sZB2ThHnrXPSmcj9QXVawi50Kr2yKxtlSOa8e2JP6R4=; b=eq4hZdVjyzBl5+H4WZvmvf2q2XJx0/xHXTVekAJlOahfGhqLv0LvyheG5APHgWxOkX 7C4jZmgdtNQEfGozDLOdrRq2jPfrdnec1pBJvS7jpHEro3HnSr2YUyGmNPd5xlqlzKRd dBYAkxqka7oOKzGDxAeU9oAhJ1mHPfJ0F5boKQpV/pspgPyy4ltjwplOfmlVZ6l8bhMg dLrNLdiBZhebif9UJN9HfneFfCFxT5fwrHp9NnzY/PpbH3k3OGkd2mRzWPtEkB0pVR2M GJHyJfG7j2XYbBIj4Na2KRQ9mHnloONd1lvj9BjOUhb5hsuWqqntf0FkqMyLFfeDnaeT IDpQ== X-Gm-Message-State: APjAAAV07BjuqoN+cv2bUki+63ZSUOwPIieJnvPAI0FzVcD3vhpZxH7g immH8C3HgtZYFvJiI6MjhpE= X-Received: by 2002:a05:600c:110a:: with SMTP id b10mr15532703wma.18.1569829763905; Mon, 30 Sep 2019 00:49:23 -0700 (PDT) Return-Path: Received: from lightning (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id h125sm26423880wmf.31.2019.09.30.00.49.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Sep 2019 00:49:23 -0700 (PDT) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Mon, 30 Sep 2019 13:19:17 +0530 To: Jan Kiszka Cc: Vijai Kumar K , isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Subject: Re: [PATCH v2] isar-init-build-env: Always set ISARROOT Message-ID: <20190930074917.GB10223@lightning> References: <20190927213804.31651-1-Vijaikumar_Kangarajan@mentor.com> <20190927214352.32114-1-Vijaikumar_Kangarajan@mentor.com> <20190930064655.GA10223@lightning> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: 0W3ALN6KiXHk On Mon, Sep 30, 2019 at 09:01:57AM +0200, Jan Kiszka wrote: > On 30.09.19 08:46, Vijai Kumar K wrote: > > On Mon, Sep 30, 2019 at 08:06:14AM +0200, Jan Kiszka wrote: > > > On 27.09.19 23:43, vijaikumar.kanagarajan@gmail.com wrote: > > > > From: Vijai Kumar K > > > > > > > > When switching between two ISAR workspaces in the same shell > > > > session, the ISARROOT setting of the previous workspace would be > > > > picked up for the new workspace resulting in an incorrect > > > > configuration. > > > > > > > > Always set ISARROOT irrespective of whether it is empty or not. > > > > > > > > Signed-off-by: Vijai Kumar K > > > > --- > > > > Changes in v2: > > > > - Remove redundant code > > > > > > > > isar-init-build-env | 7 ++----- > > > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/isar-init-build-env b/isar-init-build-env > > > > index b08bb59..404efcb 100755 > > > > --- a/isar-init-build-env > > > > +++ b/isar-init-build-env > > > > @@ -42,13 +42,10 @@ if [ -z "$ZSH_NAME" ] && [ "$0" = "$THIS_SCRIPT" ]; then > > > > exit 1 > > > > fi > > > > -if [ -z "$ISARROOT" ]; then > > > > - ISARROOT=$(dirname "$THIS_SCRIPT") > > > > - ISARROOT=$(readlink -f "$ISARROOT") > > > > -fi > > > > +ISARROOT=$(dirname "$THIS_SCRIPT") > > > > +ISARROOT=$(readlink -f "$ISARROOT") > > > > unset THIS_SCRIPT > > > > -ISARROOT=$(readlink -f "$ISARROOT") > > > > export ISARROOT > > > > . "$ISARROOT/scripts/isar-buildenv-internal" "$1" && \ > > > > TEMPLATECONF="$TEMPLATECONF" "$ISARROOT/scripts/isar-setup-builddir" || { > > > > > > > > > > OE is doing the same, i.e. does not update OEROOT on second execution. This > > > allows to set OEROOT prior to calling the script (https://github.com/openembedded/openembedded-core/commit/3327e2a9222004d8ac7974cb1d9fe77c81176cfc). > > > > Yes. But then OE also unsets OEROOT later in that script. > > > > But with our below change we are no longer doing the same. > > https://github.com/ilbers/isar/commit/b59cf9ef8aae682937e8a4a5cda1c6d080d329b7 > > > > But this is not changing the fact that we can current take ISARROOT from the > caller's environment. If we remove that, in deviation from OE, it should be > a clear decision. And it should be stated somewhere. > > Jan Yes. You are right. I would rather not break that. The first thing that comes to my mind to fix this is to use a different variable in ./meta/classes/wic-img.bbclass and leave ISARROOT alone. Something like ISARHOME which would obviously be the value of ISARROOT. Then we could unset ISARROOT at the end of the script. Thanks, Vijai Kumar K > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux