From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6739560601010307072 X-Received: by 2002:a2e:2bdb:: with SMTP id r88mr11642071ljr.82.1569841654234; Mon, 30 Sep 2019 04:07:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:7d02:: with SMTP id y2ls1435322ljc.8.gmail; Mon, 30 Sep 2019 04:07:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTzZda4FL+G5V8plvjp5iW3fikxMWlSGaaVkiWCIvz9Y0fxlHrnqwv3i0qkRVbSb8QeAgn X-Received: by 2002:a2e:3201:: with SMTP id y1mr11901688ljy.5.1569841653576; Mon, 30 Sep 2019 04:07:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569841653; cv=none; d=google.com; s=arc-20160816; b=Xm3/smRiVkktvSwXsrq+a5DX2g0DCkZp2dTPeq1yYrcrheQAW7UpnqO7HSbGqKQpRG KwsttmWa852rtMB6od+9nvKRF+SintBWFHFw7QHqvPK9BeSWms5MAFMYHckBwQnO7R4x qahQOd1IqO3bEPx+JBbp6XRBFLdTHIW6aTtCPhDg4Ufi3u7VRNybigTzvq3u0ukIGDYW eJNjHlNJ9aII5FstJ+21hK3OAdagvm1lsSXb/hP7dcOZixu5oraN128rAorFtaUxwk3n wyTuNDMF/WZOFgu1NYmdwzbicwsj1Itj9CBQgAzHAHR7JfvSKwUVVTrYUh/1Tgu3s380 Sc/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=oAZZsGxqoF6D76DdrDgBEgTqqs3NMNl5P359yn9RhL0=; b=VrnzUzCP89+fEEp9JjCdtRih0jUUsa9MTm/y8n3Rb/bzDX8al81aG5UDsAEud/RUOb caqJucslM+AmsgHihJh6sWHBCcIGvF9C4Dh45okn3nvE98BEu8gsfWaFmkBP8vVkrIiq VoeXCDLYGkeRBKOV/jxFy2n7RZIfXnFNS1B/2EQ/gmFiKgR6m9qkWNwrvasifGgdN86c NjWLoNysrP8Zq0TVFWFHb7S3uYhW7CbxiPPFvbty/bjtNCyXG8X+5+NuScE62PdWayCR 2+SKyQabQT9MxcKdLY26DOxIzeq9q3TsBKrPx0z1K/9/FWDu1Teob11tBqhOUjNigBKY wC1g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id k24si829467lji.3.2019.09.30.04.07.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Sep 2019 04:07:33 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x8UB7VNC005941 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Sep 2019 13:07:32 +0200 Date: Mon, 30 Sep 2019 13:07:30 +0200 From: Baurzhan Ismagulov To: isar-users Subject: Re: [PATCH v5 19/27] dpkg-base: Wait for umount to succeed Message-ID: <20190930110730.q4zxjwubhl53vtgi@yssyq.m.ilbers.de> Mail-Followup-To: isar-users References: <94b59dd0e5a14ece5f2d6b7131984ba944350b08.1569176231.git.jan.kiszka@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94b59dd0e5a14ece5f2d6b7131984ba944350b08.1569176231.git.jan.kiszka@siemens.com> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: SqYI3LOWGGOP On Sun, Sep 22, 2019 at 08:17:03PM +0200, Jan Kiszka wrote: > Rather than ignoring a still busy BUILDROOT mount point, wait for it to > become free. If that should ever get stuck, the user can still forcibly > terminate. But normally, this is just about giving some detached > processes time to finish. ... > dpkg_undo_mounts() { > - sudo umount ${BUILDROOT} 2>/dev/null || true > - sudo rmdir ${BUILDROOT} 2>/dev/null || true > + while ! sudo umount ${BUILDROOT} 2>/dev/null; do > + sleep 0.1 > + done > + sudo rmdir ${BUILDROOT} I agree that we shouldn't ignore failing umounts. However, hanging forever leads to bad user experience. I suggest to introduce a timeout or a number of attempts and fail. With kind regards, Baurzhan.