[PATCH 0/3] various random style fixes

[PATCH 0/3] various random style fixes

[Henning Schild]

From: Henning Schild <henning.schild@siemens.com>

Small things i found along the way, no functional change.

Henning Schild (3):
  ci_build: cosmetic change to increase readability
  CI: make gitlab-ci build verbose instead of quiet
  meta: rootfs: align the name of the apt preferences file for isar-apt

 .gitlab-ci.yml              | 2 +-
 meta/classes/rootfs.bbclass | 2 +-
 scripts/ci_build.sh         | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.21.0

[PATCH 1/3] ci_build: cosmetic change to increase readability

[Henning Schild]

From: Henning Schild <henning.schild@siemens.com>

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 scripts/ci_build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
index a69cc51..4914279 100755
--- a/scripts/ci_build.sh
+++ b/scripts/ci_build.sh
@@ -163,7 +163,7 @@ while [ -e bitbake.sock ]; do sleep 1; done
 bitbake $BB_ARGS -c do_populate_sdk multiconfig:qemuarm-stretch:isar-image-base
 while [ -e bitbake.sock ]; do sleep 1; done
 
-if [ ! -n "$FAST_BUILD" ]; then
+if [ -z "$FAST_BUILD" ]; then
     # Cleanup and disable cross build
     sudo rm -rf tmp
     sed -i -e 's/ISAR_CROSS_COMPILE ?= "1"/ISAR_CROSS_COMPILE ?= "0"/g' conf/local.conf
-- 
2.21.0

Re: [PATCH 1/3] ci_build: cosmetic change to increase readability

[Baurzhan Ismagulov]

On Thu, Sep 19, 2019 at 07:04:01PM +0200, Henning Schild wrote:
> --- a/scripts/ci_build.sh
> +++ b/scripts/ci_build.sh
> @@ -163,7 +163,7 @@ while [ -e bitbake.sock ]; do sleep 1; done
>  bitbake $BB_ARGS -c do_populate_sdk multiconfig:qemuarm-stretch:isar-image-base
>  while [ -e bitbake.sock ]; do sleep 1; done
>  
> -if [ ! -n "$FAST_BUILD" ]; then
> +if [ -z "$FAST_BUILD" ]; then

Applied to next, thanks.

With kind regards,
Baurzhan.

[PATCH 2/3] CI: make gitlab-ci build verbose instead of quiet

[Henning Schild]

From: Henning Schild <henning.schild@siemens.com>

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 1c6fa84..cfd5f91 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -10,4 +10,4 @@ all:
     - export https_proxy=$HTTPS_PROXY
     - export ftp_proxy=$FTP_PROXY
     - export no_proxy=$NO_PROXY
-    - scripts/ci_build.sh -q -f
+    - scripts/ci_build.sh -f
-- 
2.21.0

Re: [PATCH 2/3] CI: make gitlab-ci build verbose instead of quiet

[Jan Kiszka]

On 19.09.19 19:04, [ext] Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   .gitlab-ci.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 1c6fa84..cfd5f91 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -10,4 +10,4 @@ all:
>       - export https_proxy=$HTTPS_PROXY
>       - export ftp_proxy=$FTP_PROXY
>       - export no_proxy=$NO_PROXY
> -    - scripts/ci_build.sh -q -f
> +    - scripts/ci_build.sh -f
> 

Now I remember the reason...

NACK, at least until non-verbose mode is fixed to not interleave the output of 
parallel tasks.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH 2/3] CI: make gitlab-ci build verbose instead of quiet

[Baurzhan Ismagulov]

On Sat, Sep 21, 2019 at 12:36:39PM +0200, Jan Kiszka wrote:
> > -    - scripts/ci_build.sh -q -f
> > +    - scripts/ci_build.sh -f
...
> NACK, at least until non-verbose mode is fixed to not interleave the output
> of parallel tasks.

I've enabled that on ci.isar-build.org, since it's the only way to see the
concurrency. This may help debugging sporadic races. I agree that the output is
very hard to read.

IIRC, I had a discussion with DEBOS (?) people regarding the logs, but we
didn't go into depth. One approach could be to always log everything (even
messages that don't go to the console), e.g. into a database (with timestamps,
task name and number, etc.), and have a tool to display and filter the output.

With kind regards,
Baurzhan.

Re: [PATCH 2/3] CI: make gitlab-ci build verbose instead of quiet

[Jan Kiszka]

On 15.10.19 12:48, Baurzhan Ismagulov wrote:
> On Sat, Sep 21, 2019 at 12:36:39PM +0200, Jan Kiszka wrote:
>>> -    - scripts/ci_build.sh -q -f
>>> +    - scripts/ci_build.sh -f
> ...
>> NACK, at least until non-verbose mode is fixed to not interleave the output
>> of parallel tasks.
> 
> I've enabled that on ci.isar-build.org, since it's the only way to see the
> concurrency. This may help debugging sporadic races. I agree that the output is
> very hard to read.

Sigh... If you really think you can read anything out of the resulting
logs in practice (I seriously doubt this), please confine this to your
private Jenkins runs. For gitlab-ci, we neither need this - because of
[1] - nor is it desired as I explained clearly. Believe me, I've
debugged a number of races seen in CI originally just recently.

Thanks,
Jan

> 
> IIRC, I had a discussion with DEBOS (?) people regarding the logs, but we
> didn't go into depth. One approach could be to always log everything (even
> messages that don't go to the console), e.g. into a database (with timestamps,
> task name and number, etc.), and have a tool to display and filter the output.
> 
> With kind regards,
> Baurzhan.
> 

[1]
https://github.com/ilbers/isar/commit/e5b7d62f91b233f85361d49871cf9a3dad5b2436

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH 2/3] CI: make gitlab-ci build verbose instead of quiet

[Baurzhan Ismagulov]

On Tue, Oct 15, 2019 at 01:31:24PM +0200, Jan Kiszka wrote:
> Sigh... If you really think you can read anything out of the resulting
> logs in practice (I seriously doubt this), please confine this to your
> private Jenkins runs. For gitlab-ci, we neither need this - because of
> [1] - nor is it desired as I explained clearly.

The patch is not applied. You raised the question of fixing interleaved output,
and I shared my opinion. I'm aware of [1], but it doesn't show concurrency in
the same way.


> Believe me, I've
> debugged a number of races seen in CI originally just recently.

Could you perhaps share your experience, what was the key to finding them?


> [1]
> https://github.com/ilbers/isar/commit/e5b7d62f91b233f85361d49871cf9a3dad5b2436


With kind regards,
Baurzhan.

[PATCH 3/3] meta: rootfs: align the name of the apt preferences file for isar-apt

[Henning Schild]

From: Henning Schild <henning.schild@siemens.com>

This is a purely cosmetic change. We always call that thing "isar-apt"
so do not call it just "isar" here.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/classes/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index 83c2475..d32c8f8 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -83,7 +83,7 @@ rootfs_configure_isar_apt() {
         '${ROOTFSDIR}/etc/apt/sources.list.d/isar-apt.list'
 
     mkdir -p '${ROOTFSDIR}/etc/apt/preferences.d'
-    cat << EOF > '${ROOTFSDIR}/etc/apt/preferences.d/isar'
+    cat << EOF > '${ROOTFSDIR}/etc/apt/preferences.d/isar-apt'
 Package: *
 Pin: release n=${DEBDISTRONAME}
 Pin-Priority: 1000
-- 
2.21.0

Re: [PATCH 3/3] meta: rootfs: align the name of the apt preferences file for isar-apt

[Baurzhan Ismagulov]

On Thu, Sep 19, 2019 at 07:04:03PM +0200, Henning Schild wrote:
> This is a purely cosmetic change. We always call that thing "isar-apt"
> so do not call it just "isar" here.

Applied to next, thanks.

With kind regards,
Baurzhan.

Re: [PATCH 0/3] various random style fixes

[Jan Kiszka]

On 19.09.19 19:04, [ext] Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> Small things i found along the way, no functional change.
> 
> Henning Schild (3):
>    ci_build: cosmetic change to increase readability
>    CI: make gitlab-ci build verbose instead of quiet
>    meta: rootfs: align the name of the apt preferences file for isar-apt
> 
>   .gitlab-ci.yml              | 2 +-
>   meta/classes/rootfs.bbclass | 2 +-
>   scripts/ci_build.sh         | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 

Look all good to me.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux