public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH v2] meta: Add support for FILESEXTRAPATHS
Date: Tue, 15 Oct 2019 15:11:18 +0530	[thread overview]
Message-ID: <20191015094118.GA15374@lightning> (raw)
In-Reply-To: <cb3e47d9-800d-45c5-0a50-52cf05a2c7c5@siemens.com>

On Mon, Oct 14, 2019 at 09:49:47AM +0200, Jan Kiszka wrote:
> On 14.10.19 08:40, Vijai Kumar K wrote:
> > On Mon, Oct 07, 2019 at 11:37:38AM +0200, Baurzhan Ismagulov wrote:
> >> Hello Vijai Kumar,
> >>
> >> On Fri, Oct 04, 2019 at 02:15:06PM +0530, vijaikumar.kanagarajan@gmail.com wrote:
> >>> OE-core provides FILESEXTRAPATHS to extend the search path for
> >>> files and patches. This is particularly useful when you want to
> >>> add more files or replace existing files using bbappend.
> >>>
> >>> Bring in support for FILESEXTRAPATHS from OE-core.
> >>
> >> Thanks. What are the possibilities of adding a test case for this?
> > 
> > 
> > Baurzhan,
> > 
> > Sorry for the late reply. I was on vacation.
> > 
> > Is there some test suite in ISAR to test features like these? Just wondering
> > where would the test cases go.
> 
> - add a use case of the new feature a some recipe in meta-isar
> - make sure that recipe is built as part of scripts/ci_build.sh, ideally
>   the fast variant if the feature is not taking too much extra time

I believe we could replace FILESPATH with FILESEXTRAPATHS in the below files.
That should give a test case also would make it easier to override the files
using bbappends. 

meta/recipes-bsp/u-boot/u-boot-custom.inc
meta/recipes-kernel/linux-module/module.inc
meta/recipes-kernel/linux/linux-custom.inc

-FILESPATH =. "${LAYERDIR_core}/recipes-kernel/linux/files:"
+FILESEXTRAPATHS_prepend := "${FILE_DIRNAME}/files:"

Will test and send a v2 with an additional patch for review.

Thanks,
Vijai Kumar K

> 
> Jan
> 
> -- 
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux

      parent reply	other threads:[~2019-10-15  9:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 13:54 [PATCH] " vijaikumar.kanagarajan
2019-10-04  7:30 ` Jan Kiszka
2019-10-04  7:42   ` Vijai Kumar K
2019-10-04  8:45   ` [PATCH v2] " vijaikumar.kanagarajan
2019-10-07  9:37     ` Baurzhan Ismagulov
2019-10-14  6:40       ` Vijai Kumar K
2019-10-14  7:49         ` Jan Kiszka
2019-10-14  7:51           ` Jan Kiszka
2019-10-15  9:41           ` Vijai Kumar K [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015094118.GA15374@lightning \
    --to=vijaikumar.kanagarajan@gmail.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox