From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750639733816164352 X-Received: by 2002:a19:8c05:: with SMTP id o5mr20586246lfd.53.1571807767834; Tue, 22 Oct 2019 22:16:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9450:: with SMTP id o16ls124629ljh.16.gmail; Tue, 22 Oct 2019 22:16:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUxy8nhdYEFNPsEcPD0ZWRqlHPZ6JZoAapQafgE+ZNah4us7iAOgcbJrRBFaTHuXPzunwZ X-Received: by 2002:a2e:700f:: with SMTP id l15mr3750031ljc.69.1571807766963; Tue, 22 Oct 2019 22:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571807766; cv=none; d=google.com; s=arc-20160816; b=ShBBSlqnp56paic0EddmIVorZmnU7TMwNdXLRhr53sAtAtmKZaa9glr6DQjtfXVpa3 GZ4KH2xww8q5Wz2E5CkBaTdV+0l0ClVO3R0GWo9yz8tqw3Vw1Ge92qTVJ/Z+JJxzUp3b lXHKIZZCPmYsOiyCxNeV0xtMjVeHL8cxALuutRN7CK84dXhyKvqzHOn1IyCGwruj9w6g AGU4CsRb5s6dbHrQOYXCLcWePYf1ZGB92MfBHkki2a3w8SI7fpNje9WZkP3lCuIKLEi+ 4jmJgVVGHWzEBVVk7mfc+r98CYQR4nxoZXvS444GCSIpTQ+HT80w/yGaE4wJwJgCk+mU /KlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=Aud6ib4orW7/MWAyAaC9OUXmGfbVoK4k71G9ZSrCDjk=; b=jOiKDfNC6OA/CltLOInQgj6dhwyz3oglfNJckQsnpvuChlNrL01jqRc5ipiR/+ZXNx bOL8SMaxkqXUBiI/P2kneLh9C5MSsSP+DaXOtoa1ZPPsiMZbR5hCiDP1xrP434t1O24R ndt7J/OU5v2MkC6ObBQSrgu5/mU1kOEbOzUTtZNQNQ8fcqH7a10RmkPaLcjTkCkFEWZh sXvHg15qtWJkW6xzju/KetnEuFE1z4md7EnjbXEJgxB6QiF/YMgoRrbuCOXmqFcMABJY 6x9adkl8+uywC9J4H5CypgOch5x1wqsrA5XZx5cUHVO1/c7XWPC58sCTG/DnXYyRp6vV 31YQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OsXfGDjS; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::331 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com. [2a00:1450:4864:20::331]) by gmr-mx.google.com with ESMTPS id k24si984148lji.3.2019.10.22.22.16.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 22:16:06 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::331 as permitted sender) client-ip=2a00:1450:4864:20::331; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OsXfGDjS; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::331 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x331.google.com with SMTP id r141so8622843wme.4 for ; Tue, 22 Oct 2019 22:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Aud6ib4orW7/MWAyAaC9OUXmGfbVoK4k71G9ZSrCDjk=; b=OsXfGDjS2+IxrPL9kDDCGqfYqiqPVRrT6RylbQXOCoh7DprG28R9WFyIw7JESdLKkH EVytx1SC7018wAG+s5Ln+AgCXHx5a8rR9O4ik640iiDwrM6JkJK+GIv4Duf9hV/0JWnl 75SWGIgPWjrFOnfn7uJNM835mAJSSkiOoLkOQJoalsVsQ04BEAkOENm1+SLCHa8fbs33 rxx4RO9tSyaPutDiHS82cAPSXAqS33sZd2UtNeeAVlzQN/nJFQN6eowpG8mr1fM7NZ4e PqpfrmhEeYw1SETIX7hA+O9t+209J5ZnJFFnDaaFYEtH41FJoJN294bCSElzYjN+qzK/ buMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Aud6ib4orW7/MWAyAaC9OUXmGfbVoK4k71G9ZSrCDjk=; b=XSwuAbG2dQH1kaL2es2/YTUBJiDrNFYQwVez86lXKvEXSRiMRy1dh8IokcqYrGQVEv S2Ya5fz3Z1iEN8V6HwxtnwLIOlXARnzFCh0ETOi/4MkesV4gRZOgJZl7Jjed/v0j2s6F v2Um+YdwOsgQFetvZfU49QQiOHSk+eR7oBK3uDBvFKmvGIJZurTd8RpfGYGhULbIilxl SOLltCpOZR4tmZ8nLVuTVMdMylosiTH7+oskQLzbSRjpeTwS/QXsXWlKMSPL5oS16iT+ 0bwG6waPnhL3o30W1OrtY+YycbvzYnP6qMuc5JxRctZSyoRYgMFVeP4B+061Huwys3Ih ALYg== X-Gm-Message-State: APjAAAUAhh8X4X4ru8vd6lJH49Tn+9ncm4IKE70o4m5YCUPkD2APO8DX 3rb25o6mWJZJpQFbaFUJrn+7h470ICo= X-Received: by 2002:a1c:e40b:: with SMTP id b11mr5939080wmh.152.1571807766198; Tue, 22 Oct 2019 22:16:06 -0700 (PDT) Return-Path: Received: from lightning (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id w15sm12565074wro.65.2019.10.22.22.16.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Oct 2019 22:16:05 -0700 (PDT) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Wed, 23 Oct 2019 10:46:00 +0530 To: Gylstorff Quirin Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2] meta: rootfs: Fix manifest generation Message-ID: <20191023051600.GA3125@lightning> References: <20191022144930.3458-1-Vijaikumar_Kangarajan@mentor.com> <20191022145336.3873-1-Vijaikumar_Kangarajan@mentor.com> <28666b08-fc78-8ad3-083b-f94a345b98ce@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28666b08-fc78-8ad3-083b-f94a345b98ce@siemens.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: EGCajQFJwGrX On Tue, Oct 22, 2019 at 06:28:57PM +0200, Gylstorff Quirin wrote: > > > On 10/22/19 4:53 PM, vijaikumar.kanagarajan@gmail.com wrote: > > From: Vijai Kumar K > > > > finalize-rootfs task removes qemu-*-static. It is needed for > > rootfs_generate_manifest to work when HOST_ARCH != DISTRO_ARCH. > > > > Make sure a proper chroot environment is available when > > generating manifest. > > > > Signed-off-by: Vijai Kumar K > > --- > > Changes in v2: > > - Updated commit message. > > > > meta/classes/rootfs.bbclass | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > > index da66b3f..1da27ff 100644 > > --- a/meta/classes/rootfs.bbclass > > +++ b/meta/classes/rootfs.bbclass > > @@ -9,8 +9,8 @@ ROOTFS_PACKAGES ?= "" > > # available features are: > > # 'deploy-package-cache' - copy the package cache ${WORKDIR}/apt_cache > > # 'clean-package-cache' - delete package cache from rootfs > > -# 'finalize-rootfs' - delete files needed to chroot into the rootfs > > # 'generate-manifest' - generate a package manifest of the rootfs into ${ROOTFS_MANIFEST_DEPLOY_DIR} > > +# 'finalize-rootfs' - delete files needed to chroot into the rootfs > > ROOTFS_FEATURES ?= "" > > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > > @@ -185,6 +185,15 @@ rootfs_postprocess_clean_package_cache() { > > sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* > > } > > +ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" > > +rootfs_generate_manifest () { > > + mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR} > > + sudo -E chroot --userspec=$(id -u):$(id -g) '${ROOTFSDIR}' \ > > + dpkg-query -W -f \ > > + '${source:Package}|${source:Version}|${binary:Package}|${Version}\n' > \ > > + ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest > > +} > > + > > ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs', 'rootfs_postprocess_finalize', '', d)}" > > rootfs_postprocess_finalize() { > > sudo -s <<'EOSUDO' > > @@ -223,15 +232,6 @@ rootfs_postprocess_finalize() { > > EOSUDO > > } > > Is it possible to add a guard to finalize to check that it is the last > command in ROOTFS_POSTPROCESS_COMMAND. We could use _append instead of += for finalize-rootfs. May be add a comment as well to warn developers that any postprocess function that needs chroot should go before finalize-rootfs. Thanks, Vijai Kumar K > > > -ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" > > -rootfs_generate_manifest () { > > - mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR} > > - sudo -E chroot --userspec=$(id -u):$(id -g) '${ROOTFSDIR}' \ > > - dpkg-query -W -f \ > > - '${source:Package}|${source:Version}|${binary:Package}|${Version}\n' > \ > > - ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest > > -} > > - > > do_rootfs_postprocess[vardeps] = "${ROOTFS_POSTPROCESS_COMMAND}" > > python do_rootfs_postprocess() { > > # Take care that its correctly mounted: > > > > Thanks. > > This should have been found in the CI build. > Is the CrossBuild not part of the CI configuration? > > Quirin > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/28666b08-fc78-8ad3-083b-f94a345b98ce%40siemens.com.