Re: [PATCH v2] meta: rootfs: Fix manifest generation

[Baurzhan Ismagulov <ibr@radix50.net>]

On Wed, Oct 23, 2019 at 10:46:00AM +0530, Vijai Kumar K wrote:
> > Is it possible to add a guard to finalize to check that it is the last
> > command in ROOTFS_POSTPROCESS_COMMAND.
> 
> We could use _append instead of += for finalize-rootfs. May be add a comment as well to warn developers
> that any postprocess function that needs chroot should go before finalize-rootfs.

Thanks for heads-up. I've indeed let this slip in after it worked on a
different machine. If the patch works, I'm going to apply it.

That said, we've traced the skeleton problem to a similar issue with qemu in
meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py. I think we should:

1. Move finalize-rootfs out of ROOTFS_FEATURES and hard-code the call to e.g.
   do_rootfs_postprocess() as the last step, and

2. Centralize qemu cp / rm in global functions using bb.persist_data.persist()
   to copy it at the first request and remove at the last one.

Comments and other suggestions welcome.

With kind regards,
Baurzhan.