From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750639733816164352 X-Received: by 2002:a19:ee05:: with SMTP id g5mr11424449lfb.70.1571847941452; Wed, 23 Oct 2019 09:25:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9246:: with SMTP id v6ls396619ljg.6.gmail; Wed, 23 Oct 2019 09:25:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzACcIEa3s0yqutMjhKgQuHqan2bg08M1riyf1hCRQtm+JuS9uATZxTCpsDtf66awmRpjFV X-Received: by 2002:a2e:4751:: with SMTP id u78mr22768805lja.210.1571847940345; Wed, 23 Oct 2019 09:25:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571847940; cv=none; d=google.com; s=arc-20160816; b=vSW5Dh4DqBmfRUWOKVx4yWrRppmMqLcdJumzgAvrC1kfgxSp+DMIiq/wlgXvgKXKmx 4uTQX/lCMYhBTLqyuaoPSnFk9HxsQGHBQ6QzPdoH4E+Uf0ajFZEiccCSMPgen8TzHaLx yNdLzzMBH6QOTI9pSpiXoO0148vni31tYRrMVrcsls3wtATs5siBnihKJTbqPAeCxJc0 KUNaNYy+vi4RDO/cWaqahyP1MbqsEwMYtk8ozq6OcmldqOeLeweSJ/r3bT+2D844S11P zX3XthYD0gpQr4GI1hC45irla8jmziRFbgxhMb12/S2x8bhGwnRzvGMp+/NfsEMWD9X/ 20nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=3ZKdYUrVRcIC9nyVZKeuQfG/BxIpEMkncnQgMatVH34=; b=xGedsX3SOwfFhM5pqFy7jQ5qkShhpPDLGZjaWN1mSJ1EkLV7VGWfnLnrGlsnIhJ31H KjvNdl/0np3nQYgu0KfH+iqDEk7lcDgwK85nHVFrlfRaMdhtlgcR/2vWArJH4D86HymF 4ySFTps7lpiP21uuAiocBv6oO2Qk5uE5jKol3BfpD7Pk0Bry90+9Lq2LrqxzRebl9gC3 7xIVHgiJebTTuIQESWC0kUTgLHhZEJPY/mjprDahW8OwB/amfSgeNBKE9jpxnREYzg0F TaWYyGzQVTgA2T+COxu6KQeTO0pD1UyWF/ZzKFhQmCm5FshdWzprfO6VrxH6nvIbnPcs qAnA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id d3si1157382lfq.1.2019.10.23.09.25.40 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2019 09:25:40 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x9NGPZZ1012297 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 23 Oct 2019 18:25:36 +0200 Date: Wed, 23 Oct 2019 18:25:35 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH v2] meta: rootfs: Fix manifest generation Message-ID: <20191023162534.lo5mwc3nqexmqme7@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20191022144930.3458-1-Vijaikumar_Kangarajan@mentor.com> <20191022145336.3873-1-Vijaikumar_Kangarajan@mentor.com> <28666b08-fc78-8ad3-083b-f94a345b98ce@siemens.com> <20191023051600.GA3125@lightning> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023051600.GA3125@lightning> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: pTf2I6wTb7md On Wed, Oct 23, 2019 at 10:46:00AM +0530, Vijai Kumar K wrote: > > Is it possible to add a guard to finalize to check that it is the last > > command in ROOTFS_POSTPROCESS_COMMAND. > > We could use _append instead of += for finalize-rootfs. May be add a comment as well to warn developers > that any postprocess function that needs chroot should go before finalize-rootfs. Thanks for heads-up. I've indeed let this slip in after it worked on a different machine. If the patch works, I'm going to apply it. That said, we've traced the skeleton problem to a similar issue with qemu in meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py. I think we should: 1. Move finalize-rootfs out of ROOTFS_FEATURES and hard-code the call to e.g. do_rootfs_postprocess() as the last step, and 2. Centralize qemu cp / rm in global functions using bb.persist_data.persist() to copy it at the first request and remove at the last one. Comments and other suggestions welcome. With kind regards, Baurzhan.