From: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
To: isar-users@googlegroups.com
Subject: Re: [PATCH v2] meta: rootfs: Fix manifest generation
Date: Thu, 24 Oct 2019 11:07:30 +0530 [thread overview]
Message-ID: <20191024053730.GA21783@lightning> (raw)
In-Reply-To: <20191023162534.lo5mwc3nqexmqme7@yssyq.m.ilbers.de>
On Wed, Oct 23, 2019 at 06:25:35PM +0200, Baurzhan Ismagulov wrote:
> On Wed, Oct 23, 2019 at 10:46:00AM +0530, Vijai Kumar K wrote:
> > > Is it possible to add a guard to finalize to check that it is the last
> > > command in ROOTFS_POSTPROCESS_COMMAND.
> >
> > We could use _append instead of += for finalize-rootfs. May be add a comment as well to warn developers
> > that any postprocess function that needs chroot should go before finalize-rootfs.
>
> Thanks for heads-up. I've indeed let this slip in after it worked on a
> different machine. If the patch works, I'm going to apply it.
Yes, it works. Tested with qemuarm-stretch and rpi-stretch.
>
> That said, we've traced the skeleton problem to a similar issue with qemu in
> meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py. I think we should:
>
> 1. Move finalize-rootfs out of ROOTFS_FEATURES and hard-code the call to e.g.
> do_rootfs_postprocess() as the last step, and
>
> 2. Centralize qemu cp / rm in global functions using bb.persist_data.persist()
> to copy it at the first request and remove at the last one.
>
> Comments and other suggestions welcome.
>
> With kind regards,
> Baurzhan.
>
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20191023162534.lo5mwc3nqexmqme7%40yssyq.m.ilbers.de.
next prev parent reply other threads:[~2019-10-24 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 14:49 [PATCH] " vijaikumar.kanagarajan
2019-10-22 14:53 ` [PATCH v2] meta: rootfs: " vijaikumar.kanagarajan
2019-10-22 16:28 ` Gylstorff Quirin
2019-10-22 16:36 ` Henning Schild
2019-10-23 5:16 ` Vijai Kumar K
2019-10-23 16:25 ` Baurzhan Ismagulov
2019-10-24 5:37 ` Vijai Kumar K [this message]
2019-10-24 12:26 ` Henning Schild
2019-10-24 10:54 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024053730.GA21783@lightning \
--to=vijaikumar.kanagarajan@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox