From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750639733816164352 X-Received: by 2002:aa7:c257:: with SMTP id y23mr41400963edo.39.1571895456974; Wed, 23 Oct 2019 22:37:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:b54b:: with SMTP id z11ls1091727edd.6.gmail; Wed, 23 Oct 2019 22:37:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzj/IU5pe1NXiWmO8mceY1/jUqvR64KaL9MXSKfn8WnkOdn6EnSJNgdrCHdSuwyqog9iVsd X-Received: by 2002:a05:6402:110c:: with SMTP id u12mr12198674edv.127.1571895456318; Wed, 23 Oct 2019 22:37:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571895456; cv=none; d=google.com; s=arc-20160816; b=P3ZKgpw53W0qQEPHDeiCn7DCZ0BdLa0/qT9gTCgzWpVgy4CvFcT7tCoAWlPMFkC5gn lZnrJkQWBt9T3Lh4kx7V0zMYQd4i5mZI9WM1ZcCnFCEX8ZU7jd2wZ5y/jB6yXIrhL6MP t82Dy9xqO5tNQcaP827jAPb/Np0ZFiMbj864a2edVloIQvU0zJZtuCLpEpZCEAwHASIO JBfl+4r/RuOF6B5dO4ZAjeGl5pCOvR4eYgbT0mTX/ehGNTax4hOFn2S7FxiuD06xzccC aXMnpeCpWjk4ObNoRrnFQ+t7FSKB9Ndu/8BfitnH3TD5A8xgxNRFSNhgIG3zwJBmjMVh 3Myg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:to:date:from:dkim-signature; bh=1GbF+s+KPvrk5fn5r8lFtXO4uqtzyRyZWdWtehXlL/U=; b=W3qe4Ch7X/WA0zmO4NBZg1OiGyQRVEUOi06nB+slMK4wdI5AV7EAWb70yM8SBil3vl 9wFsHZdIRjpmHJ1vblJhTPpMAQtSxSH79yHmRfsiXuFfnDG+d6X36uqVQt0P8VZmpesm iEKdqu9+XDGr4SiCpktqKpaFTcY4q6gXLSL3zo4Fj0QgMIZCY7lOJBQZuB9+vaX7wwz2 rgodCmbnKnHjkV5wYoD2hWQyWaRBj/z/z+9BgMbyCn0rTmZtkAcnvT5aTrhYF6cEjD1O SbzI30xCQbiDGJj0g1ggjdjEgsa4gv2k0bAahanp/xpHu5p/GV1H5upmbuFjDfyBqgV/ S/qA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=i9RkiTxT; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::344 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com. [2a00:1450:4864:20::344]) by gmr-mx.google.com with ESMTPS id z18si1061418edd.5.2019.10.23.22.37.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2019 22:37:36 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::344 as permitted sender) client-ip=2a00:1450:4864:20::344; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=i9RkiTxT; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::344 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x344.google.com with SMTP id r141so1157511wme.4 for ; Wed, 23 Oct 2019 22:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1GbF+s+KPvrk5fn5r8lFtXO4uqtzyRyZWdWtehXlL/U=; b=i9RkiTxTMO6n3BrSiRBnRuH2RT3GNTxCox+EQjSxXZyLb7N9FcUBP+9964hNv4lQue BBDlWo6IaJ7qogSMpxEdT5NGiNiF1C5Rn18qqxckv3MLE4j809q1Onel4Z6jsMvpbqPi QE1PeO9299lgO3Ydm78r8YPuDG2s+T7sMKTQwpCb9ufqgbuEiKLwU/cKOwskGrSEMiBv qwVYhHP5svl7U/wF8+1S/aOBWtsvWIjOOM1+XaqJXmqvzgtyZ1oVpjGMAAvMUAi0Y98P XX0dGS+KibjOvu6zKow+AnWHdQSGtSVaGKwZQQNPKZT/k6/MHJrcaMzAz4iw7HKLckys Q2pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1GbF+s+KPvrk5fn5r8lFtXO4uqtzyRyZWdWtehXlL/U=; b=d080BKlh6sWuIvkUZU8WOWw+6jDRyQXWObD2q2+xoTNk4UpUEeQkQTwHf+0CixNh6h 5ouaw8SYCvwHz2aKwTv9GoneX2FuCy1zihX/4sjS52Cm+MGWFbYJYJbMu6FVvliWAB2u O82M4Td0P8MuMG4wCqTzkUMol4AyweOh4vcQzFC/O3qh0PfxfqM7IGDEsU7QRF75MI4A czFgGbgOrr9/QXNQsM8B2fjs6Vj3qrPrpMz8mq7ZN0JnVOdSiVaI/8qizlfyfBCLPE6R AyDq7rGPvQwkU/SjMU81TVJEap/xmvzbZMQXCZWRU8sxDi3kQ7EFwQDZGmxMfSp+BiJT y31w== X-Gm-Message-State: APjAAAXVjNFlm95txtxQ15vM4bxqgvJQTNMMlapt6o/AavN1+jkYeiat zjYEW3pIFgydXjtuKix4M57m5hM4Z6k= X-Received: by 2002:a1c:e40b:: with SMTP id b11mr3055638wmh.152.1571895455687; Wed, 23 Oct 2019 22:37:35 -0700 (PDT) Return-Path: Received: from lightning (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id a5sm9737747wrm.78.2019.10.23.22.37.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2019 22:37:35 -0700 (PDT) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Thu, 24 Oct 2019 11:07:30 +0530 To: isar-users@googlegroups.com Subject: Re: [PATCH v2] meta: rootfs: Fix manifest generation Message-ID: <20191024053730.GA21783@lightning> References: <20191022144930.3458-1-Vijaikumar_Kangarajan@mentor.com> <20191022145336.3873-1-Vijaikumar_Kangarajan@mentor.com> <28666b08-fc78-8ad3-083b-f94a345b98ce@siemens.com> <20191023051600.GA3125@lightning> <20191023162534.lo5mwc3nqexmqme7@yssyq.m.ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023162534.lo5mwc3nqexmqme7@yssyq.m.ilbers.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: sC0CzwFD9KeU On Wed, Oct 23, 2019 at 06:25:35PM +0200, Baurzhan Ismagulov wrote: > On Wed, Oct 23, 2019 at 10:46:00AM +0530, Vijai Kumar K wrote: > > > Is it possible to add a guard to finalize to check that it is the last > > > command in ROOTFS_POSTPROCESS_COMMAND. > > > > We could use _append instead of += for finalize-rootfs. May be add a comment as well to warn developers > > that any postprocess function that needs chroot should go before finalize-rootfs. > > Thanks for heads-up. I've indeed let this slip in after it worked on a > different machine. If the patch works, I'm going to apply it. Yes, it works. Tested with qemuarm-stretch and rpi-stretch. > > That said, we've traced the skeleton problem to a similar issue with qemu in > meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py. I think we should: > > 1. Move finalize-rootfs out of ROOTFS_FEATURES and hard-code the call to e.g. > do_rootfs_postprocess() as the last step, and > > 2. Centralize qemu cp / rm in global functions using bb.persist_data.persist() > to copy it at the first request and remove at the last one. > > Comments and other suggestions welcome. > > With kind regards, > Baurzhan. > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20191023162534.lo5mwc3nqexmqme7%40yssyq.m.ilbers.de.