From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750962531146137600 X-Received: by 2002:a5d:4803:: with SMTP id l3mr2833384wrq.381.1571908584353; Thu, 24 Oct 2019 02:16:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:9c90:: with SMTP id d16ls2925647wre.14.gmail; Thu, 24 Oct 2019 02:16:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6DKigCJyJ3erFaiMFZNvI/0tiu3nWjkHLYDh/Sm+mqnIcsoYl4vR55dcn6ZUNhB9InGsd X-Received: by 2002:a5d:55c2:: with SMTP id i2mr2910140wrw.176.1571908583849; Thu, 24 Oct 2019 02:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571908583; cv=none; d=google.com; s=arc-20160816; b=hdW3uU+fafRGsSMCZznc9tWAxGTtFn4MWe8bXdNguktgLeNZGZIMiGozjsiv3xlNd+ 7zpsHL+T62C7XuAHH9uFMtKd+rlj1cYuo5dg6cmd2Past86gzYiF0yx2qagLCHyHlbg7 ECI6XzEnrtBAhzu+2/J8dvTSONEZRNhFqosF58h9f9xZ++SHfoBByKBu17bD0Nqn8pRv /qzhg3WICRSbDncQRYl6mxnNN6FmJsyj5b7j5JBZyrkCUCdbL9iXLpq2H+NN8rAr4ffn M4M2iTO97hVS1f18jSG6HBxxH8X1SndWRJ/eP6GMyjXpa/GkojgkxIrnYI2urbTwuxsk S3gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=rAWbKNDRLC7bUq/LEI3oHU4Qh0OERwEfc4QZMuCygiU=; b=OLPJ3ZjnjulKpxde1ojH/vwuxeViqVMWmFBZYUAcBUXfsGCYwmjCklcDRnY8p4MwMt HdRvAGH4BqAE6RpLsFLQT6zj6re3NAcswcPMbIfZTJZv1VHFC++59vlNJQ/EpQ6SwvwH 65mKJVz2QDNKZeffKAJ1fkl3l1Txjskm88uyvMx93nCHcfhCTkVa0dlsEuzw21EmklcP EHy04LqlT5hDUktpS92/QQQemQDE6s9Bd3+Nk19C6QTqZ7im3R3o8zX9UOqJlry2pgVQ qvYvNiLAa+vQszorBZEfOWM5LHobUgxMqNwzVu7pKQettqiVaBkheJcdkG0YmFp4QW2A /gHA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id o185si103892wme.1.2019.10.24.02.16.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Oct 2019 02:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x9O9GNk1013826 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2019 11:16:23 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.8]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x9O9GNU8022933; Thu, 24 Oct 2019 11:16:23 +0200 Date: Thu, 24 Oct 2019 11:16:22 +0200 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCHv2 2/9] base-apt: use the "basename" command instead of pattern substitution Message-ID: <20191024111622.3d478a6b@md1za8fc.ad001.siemens.net> In-Reply-To: <20191023203604.4fnnttjymfypiktg@yssyq.m.ilbers.de> References: <20191023114227.31308-1-henning.schild@siemens.com> <20191023114227.31308-3-henning.schild@siemens.com> <20191023203604.4fnnttjymfypiktg@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: eaZCQ5eSQm/A Am Wed, 23 Oct 2019 22:36:04 +0200 schrieb Baurzhan Ismagulov : > On Wed, Oct 23, 2019 at 01:42:20PM +0200, Henning Schild wrote: > > Cosmetic and not functional. Let us not reinvet the wheel and > > possibly make mistakes. > ... > > --- a/meta/classes/base-apt-helper.bbclass > > +++ b/meta/classes/base-apt-helper.bbclass > > @@ -26,7 +26,7 @@ populate_base_apt() { > > # robust than querying reprepro by name. > > > > # Check if this package is taken from Isar-apt, if so - > > ingore it. > > - base_name=${package##*/} > > + base_name=$( basename "${package}") > > I'm not in favor of this one. The suggested replacement spawns a > subshell and executes a binary, which is much more expensive than > shell's builtin operation, and that is executed in a loop. The > current code is correct. The variable name explains what it does. In a loop that executes a lot of commands anyways, but i will drop it from v3. Henning > With kind regards, > Baurzhan. >