Re: [PATCH v2] meta: rootfs: Fix manifest generation

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 24 Oct 2019 11:07:30 +0530
schrieb Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>:

> On Wed, Oct 23, 2019 at 06:25:35PM +0200, Baurzhan Ismagulov wrote:
> > On Wed, Oct 23, 2019 at 10:46:00AM +0530, Vijai Kumar K wrote:  
> > > > Is it possible to add a guard to finalize to check that it is
> > > > the last command in ROOTFS_POSTPROCESS_COMMAND.  
> > > 
> > > We could use _append instead of += for finalize-rootfs. May be
> > > add a comment as well to warn developers that any postprocess
> > > function that needs chroot should go before finalize-rootfs.  
> > 
> > Thanks for heads-up. I've indeed let this slip in after it worked
> > on a different machine. If the patch works, I'm going to apply it.  
> 
> Yes, it works. Tested with qemuarm-stretch and rpi-stretch.

I had to apply it on my ilbers-ci branch as well, which fixed the build
of the series i sent yesterday.

Henning

> > 
> > That said, we've traced the skeleton problem to a similar issue
> > with qemu in meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py.
> > I think we should:
> > 
> > 1. Move finalize-rootfs out of ROOTFS_FEATURES and hard-code the
> > call to e.g. do_rootfs_postprocess() as the last step, and
> > 
> > 2. Centralize qemu cp / rm in global functions using
> > bb.persist_data.persist() to copy it at the first request and
> > remove at the last one.
> > 
> > Comments and other suggestions welcome.
> > 
> > With kind regards,
> > Baurzhan.
> > 
> > -- 
> > You received this message because you are subscribed to the Google
> > Groups "isar-users" group. To unsubscribe from this group and stop
> > receiving emails from it, send an email to
> > isar-users+unsubscribe@googlegroups.com. To view this discussion on
> > the web visit
> > https://groups.google.com/d/msgid/isar-users/20191023162534.lo5mwc3nqexmqme7%40yssyq.m.ilbers.de.  
>