From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750639733816164352 X-Received: by 2002:a19:9144:: with SMTP id y4mr20936174lfj.168.1571920019410; Thu, 24 Oct 2019 05:26:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:4349:: with SMTP id m9ls561717lfj.8.gmail; Thu, 24 Oct 2019 05:26:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqzO8suq6tLZPhLsc39adONZ/dR712v4ts8N964YIH5YrdtZh4UcYXUoh5UTx8ItUz6xU85k X-Received: by 2002:a19:5201:: with SMTP id m1mr19204255lfb.56.1571920018783; Thu, 24 Oct 2019 05:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571920018; cv=none; d=google.com; s=arc-20160816; b=Sx6FzWv2qoP+c9impRTaCByPxiY8s6nVnsI7Zv7kiz632v+I0fVyJUv9+kZ61qhdJa EAbALDFmHslaKj9CzqxvO1+LHUBdZ//qob2F2I+4YShbv1s2LtRP0FoYr6dCn4OwGZ+1 hvWZ8j43Pwo9vyAkoP3eCRu0ms1dcbgZLrSd9tFD4yrbuuuq48h1CLQPMq1g6TLrHCRX Dk7BiBbqMfR0MjxIQLiprZ3Ummhf9v6/Ksz45ypQfpCso5IRdowok7gipiMVQgQnlRlP 3PRxcCyDGq+q86zEyN8ZDTdr9YO93aA59HfXg2eyopiMuJUDGZYWfKY/GFiWdjcgAZn/ WF9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=NQ0e5qyN8lKRhhMmUImrN0C4jGPJZIE2lBAARNG/n98=; b=WGesbwBpQ6ZnBE4OoVoitLPemmYJ++JXu0ChHz0Ab/6B3DroQWUANh6lk2csAaNZpw 5GfDSwk6VuGfZ+qMBH2+Jz/gI2xh159Z7cLhHd93ozO7Bu88UUXsl9583cankm1kfFoV EN0ELhPfQzedj6OGRA+ceo7KDejmp09IhXaK7a+VfQ0yPinNM5I+z9I/y6VcCP2ogacl Ox51bj/0pm2hMvAXo64wk8LivFv5t49vkm/SD/3scXjAHg4WdANMwJLNDshGpLuP1ctz 2LN4W0OnOqsci2dQLXKfIJSBs0H47+b8njz7M64vhHKKlMpTaXg/hlbfW/2fIcpvxNCH PnDg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id x14si83182lfe.2.2019.10.24.05.26.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Oct 2019 05:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x9OCQvP7029809 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2019 14:26:57 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.8]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x9OCQvYK029499; Thu, 24 Oct 2019 14:26:57 +0200 Date: Thu, 24 Oct 2019 14:26:56 +0200 From: Henning Schild To: Vijai Kumar K Cc: Subject: Re: [PATCH v2] meta: rootfs: Fix manifest generation Message-ID: <20191024142656.0687b162@md1za8fc.ad001.siemens.net> In-Reply-To: <20191024053730.GA21783@lightning> References: <20191022144930.3458-1-Vijaikumar_Kangarajan@mentor.com> <20191022145336.3873-1-Vijaikumar_Kangarajan@mentor.com> <28666b08-fc78-8ad3-083b-f94a345b98ce@siemens.com> <20191023051600.GA3125@lightning> <20191023162534.lo5mwc3nqexmqme7@yssyq.m.ilbers.de> <20191024053730.GA21783@lightning> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: X+hzziZsoKiL Am Thu, 24 Oct 2019 11:07:30 +0530 schrieb Vijai Kumar K : > On Wed, Oct 23, 2019 at 06:25:35PM +0200, Baurzhan Ismagulov wrote: > > On Wed, Oct 23, 2019 at 10:46:00AM +0530, Vijai Kumar K wrote: > > > > Is it possible to add a guard to finalize to check that it is > > > > the last command in ROOTFS_POSTPROCESS_COMMAND. > > > > > > We could use _append instead of += for finalize-rootfs. May be > > > add a comment as well to warn developers that any postprocess > > > function that needs chroot should go before finalize-rootfs. > > > > Thanks for heads-up. I've indeed let this slip in after it worked > > on a different machine. If the patch works, I'm going to apply it. > > Yes, it works. Tested with qemuarm-stretch and rpi-stretch. I had to apply it on my ilbers-ci branch as well, which fixed the build of the series i sent yesterday. Henning > > > > That said, we've traced the skeleton problem to a similar issue > > with qemu in meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py. > > I think we should: > > > > 1. Move finalize-rootfs out of ROOTFS_FEATURES and hard-code the > > call to e.g. do_rootfs_postprocess() as the last step, and > > > > 2. Centralize qemu cp / rm in global functions using > > bb.persist_data.persist() to copy it at the first request and > > remove at the last one. > > > > Comments and other suggestions welcome. > > > > With kind regards, > > Baurzhan. > > > > -- > > You received this message because you are subscribed to the Google > > Groups "isar-users" group. To unsubscribe from this group and stop > > receiving emails from it, send an email to > > isar-users+unsubscribe@googlegroups.com. To view this discussion on > > the web visit > > https://groups.google.com/d/msgid/isar-users/20191023162534.lo5mwc3nqexmqme7%40yssyq.m.ilbers.de. >