public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 07/10] image: add CUSTOM_IMAGE_EXTENSIONS for user layers/machines to use
Date: Thu, 24 Oct 2019 20:09:03 +0200	[thread overview]
Message-ID: <20191024200903.6743650a@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <1571907744-1121-8-git-send-email-Cedric_Hombourger@mentor.com>

Very smelly and hacky ;). There is no such way since there is a strict
policy to try and solve everything with packages ... except for where
this is not possible ...

I am strongly against that, it will be abused. If you need to inherit
image.bbclass in your own funny-image.bbclass and add the hack in a
layer.

Henning

Am Thu, 24 Oct 2019 11:02:21 +0200
schrieb Cedric Hombourger <Cedric_Hombourger@mentor.com>:

> Some machines may require additional post-processing on the image
> before the actual file-system image is created. The image extension
> mechanism was designed for this purpose but does not seem to provide
> any way for user layers/machines to use. Add a
> CUSTOM_IMAGE_EXTENSIONS variable to fill this gap.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/classes/image.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 7690bc5..633b514 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -30,6 +30,9 @@ BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}"
>  BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}"
>  BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}"
>  
> +# Default to no custom image extensions
> +CUSTOM_IMAGE_EXTENSIONS ?= ""
> +
>  python(){
>      if (d.getVar('IMAGE_TRANSIENT_PACKAGES')):
>          bb.warn("IMAGE_TRANSIENT_PACKAGES is set and no longer
> supported") @@ -71,6 +74,7 @@ inherit image-tools-extension
>  inherit image-postproc-extension
>  inherit image-locales-extension
>  inherit image-account-extension
> +inherit ${CUSTOM_IMAGE_EXTENSIONS}
>  
>  # Extra space for rootfs in MB
>  ROOTFS_EXTRA ?= "64"


  reply	other threads:[~2019-10-24 18:09 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  9:02 [PATCH 00/10] add ci40 machine support + new Isar features Cedric Hombourger
2019-10-24  9:02 ` [PATCH 01/10] ci_build.sh: delay "set -x" for a clean --help output Cedric Hombourger
2019-10-24  9:02 ` [PATCH 02/10] linux-custom: honor KERNEL_FILE setting Cedric Hombourger
2019-10-24 17:57   ` Henning Schild
2019-10-24  9:02 ` [PATCH 03/10] bitbake.conf: set name of the qemu-static binary to use for mipsel Cedric Hombourger
2019-10-24  9:02 ` [PATCH 04/10] recipes-kernel/linux: make KERNEL_DEFCONFIG support in-tree defconfigs Cedric Hombourger
2019-10-24 18:02   ` Henning Schild
2019-11-06 16:03     ` Jan Kiszka
2019-11-06 16:17       ` Cedric Hombourger
2019-10-24  9:02 ` [PATCH 05/10] linux-mainline: fix stripping of .0 from the kernel version Cedric Hombourger
2019-11-06 16:04   ` Jan Kiszka
2019-10-24  9:02 ` [PATCH 06/10] linux-mainline: update from 4.19.0 to 4.19.80 Cedric Hombourger
2019-10-24  9:02 ` [PATCH 07/10] image: add CUSTOM_IMAGE_EXTENSIONS for user layers/machines to use Cedric Hombourger
2019-10-24 18:09   ` Henning Schild [this message]
2019-11-06 16:08     ` Jan Kiszka
2019-11-06 16:11       ` Cedric Hombourger
2019-11-06 16:16         ` Jan Kiszka
2019-11-06 16:19           ` Cedric Hombourger
2019-11-06 16:32             ` Jan Kiszka
2019-10-24  9:02 ` [PATCH 08/10] linux-custom: add support for kernel config fragments Cedric Hombourger
2019-10-24 18:21   ` Henning Schild
2019-10-24 18:25     ` Cedric Hombourger
2019-10-24 18:29       ` Henning Schild
2019-10-25  9:45     ` Cedric Hombourger
2019-10-24  9:02 ` [PATCH 09/10] linux-mainline: disable support for HFS to demonstrate use of " Cedric Hombourger
2019-10-24  9:02 ` [PATCH 10/10] meta-isar: add creator-ci40-marduk machine (mipsel + mainline kernel) Cedric Hombourger
2019-10-24 18:13   ` Henning Schild
2019-10-24 18:26     ` Henning Schild
2019-11-06 16:11     ` Jan Kiszka
2019-10-24 18:15 ` [PATCH 00/10] add ci40 machine support + new Isar features Henning Schild
2019-10-24 18:17   ` Cedric Hombourger
2019-10-25 17:39 ` [PATCH v2 0/7] custom kernel recipes enhancements (was Ci40 support) Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 1/7] linux-custom: honor KERNEL_FILE setting Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 2/7] bitbake.conf: set name of the qemu-static binary to use for mipsel Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 3/7] recipes-kernel/linux: make KERNEL_DEFCONFIG support in-tree defconfigs Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 4/7] linux-mainline: fix stripping of .0 from the kernel version Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 5/7] linux-mainline: update from 4.19.0 to 4.19.80 Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 6/7] linux-custom: add support for kernel config fragments Cedric Hombourger
2019-10-25 17:39   ` [PATCH v2 7/7] linux-mainline: disable support for HFS to demonstrate use of " Cedric Hombourger
2019-11-05 20:25     ` chombourger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024200903.6743650a@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox