From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6751292434813026304 X-Received: by 2002:a17:906:4d06:: with SMTP id r6mr39496079eju.90.1571940544798; Thu, 24 Oct 2019 11:09:04 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c719:: with SMTP id i25ls1599225edq.11.gmail; Thu, 24 Oct 2019 11:09:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwl1+So/5V9/I3qqay9wvRcCRzv5tTkUcfJ1YmYphFx848VQW2Db9gi8Atj0NIcKxadpmi X-Received: by 2002:a50:eacc:: with SMTP id u12mr4015168edp.290.1571940544371; Thu, 24 Oct 2019 11:09:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571940544; cv=none; d=google.com; s=arc-20160816; b=lP5kVDXtmJKxEX+cY/MEDg9Zqq5oa9sCmSbsCEgs1xM1daZpHTcFYbTBbkIuqQ/ICd JJxIuU2ByYwy3BZlbSksMWqykVpJimnVRw6s4cn1kqxbmUjFXBxqv/MZu89F8F+oJlh/ HKhS3ImFytz/fnWClXJ7f+4xVgjahplwzH8xqr/UNkRRaXEaTqRSJgEfnKhfEC/mZWgW qIZElmlQ4AFcGXgABlaaX/waaqse0BtW9dJp+Cil2+yNrlyYJVMRWVEOZSkoW+TwRp7U JQgfO37+IbIBP1xwOx6Vd9xkucSiwCK/Zdj1QgtxO+nWCVQFjhVrAlFTvoxnJVVuecZt 0PtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=iAXjY3Wmlxc4Wu53GjdssbSuqRReTmdCLydjIK+y0F4=; b=WWhRocTvsXFtFLigYVOwWlSmUhTAm4Da2pkl6dH682qe1oe3E1jts9gtnkj7KLAtfk ZHeapui8h5T+spRHd4HPDGGwJD9wnSfkejNwgU0OWgPlO0fpRi3MatpSTZDZSAiSl7mT vfjN9TXJe/UsQopXHzwdmiI0w58LVkkInOzsMBeUAJBuCYCmnQZXb+3SVp8hbx/9shxw DpSjCoZhHbuMqhzL5o0M11P35wUZlhK0d3NoOSarsxb8L3R4AMDCXKK+/HP2NFvNRUdO K+cLlxzVgRWDaBE/heS2VJllAuckUstJ8MnI+LcKg45r7Hqoes5CisfVAYBsmA3U8lLV jWYw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id q17si832901edi.1.2019.10.24.11.09.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Oct 2019 11:09:04 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x9OI93lW024957 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Oct 2019 20:09:03 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.0.8]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x9OI93NK007794; Thu, 24 Oct 2019 20:09:03 +0200 Date: Thu, 24 Oct 2019 20:09:03 +0200 From: Henning Schild To: Cedric Hombourger Cc: Subject: Re: [PATCH 07/10] image: add CUSTOM_IMAGE_EXTENSIONS for user layers/machines to use Message-ID: <20191024200903.6743650a@md1za8fc.ad001.siemens.net> In-Reply-To: <1571907744-1121-8-git-send-email-Cedric_Hombourger@mentor.com> References: <1571907744-1121-1-git-send-email-Cedric_Hombourger@mentor.com> <1571907744-1121-8-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: DQvb4Ycr/HS5 Very smelly and hacky ;). There is no such way since there is a strict policy to try and solve everything with packages ... except for where this is not possible ... I am strongly against that, it will be abused. If you need to inherit image.bbclass in your own funny-image.bbclass and add the hack in a layer. Henning Am Thu, 24 Oct 2019 11:02:21 +0200 schrieb Cedric Hombourger : > Some machines may require additional post-processing on the image > before the actual file-system image is created. The image extension > mechanism was designed for this purpose but does not seem to provide > any way for user layers/machines to use. Add a > CUSTOM_IMAGE_EXTENSIONS variable to fill this gap. > > Signed-off-by: Cedric Hombourger > --- > meta/classes/image.bbclass | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 7690bc5..633b514 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -30,6 +30,9 @@ BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}" > BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}" > BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}" > > +# Default to no custom image extensions > +CUSTOM_IMAGE_EXTENSIONS ?= "" > + > python(){ > if (d.getVar('IMAGE_TRANSIENT_PACKAGES')): > bb.warn("IMAGE_TRANSIENT_PACKAGES is set and no longer > supported") @@ -71,6 +74,7 @@ inherit image-tools-extension > inherit image-postproc-extension > inherit image-locales-extension > inherit image-account-extension > +inherit ${CUSTOM_IMAGE_EXTENSIONS} > > # Extra space for rootfs in MB > ROOTFS_EXTRA ?= "64"