From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6753266854416875520 X-Received: by 2002:a50:970e:: with SMTP id c14mr28429039edb.20.1572861714840; Mon, 04 Nov 2019 02:01:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c790:: with SMTP id n16ls3964232eds.5.gmail; Mon, 04 Nov 2019 02:01:54 -0800 (PST) X-Google-Smtp-Source: APXvYqzXlg2bjphauxIHCG/6NGgOhzuFKn3TqOQfFKXReOpwiQ4R2A50zC5qKReHPgGtMgNrqG39 X-Received: by 2002:a50:90a8:: with SMTP id c37mr11528486eda.153.1572861714227; Mon, 04 Nov 2019 02:01:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572861714; cv=none; d=google.com; s=arc-20160816; b=IQ/WLqkTh2yVAfsE4hWnjZId92EowScGUPUAEbLmC46ooSIaOQDCXj4qurrrQHc3eb MCX1E4IM8IgqFb2iGnzYykfpldTQD5V3EVznYqHxLUln/TS8xjQz4DmyN8/7ma4grrLl UXzRxtmenSljCk5LPPsW7i8j9nK6bczlwVczdT7fZYktIwIvzuwB4C2I5C16MPPGc1Ow jEwuS1MVg+qBkjKyFSXeolQcoz658jg7s8K3a+dmpMDhu+2N/Ud4uah5LUSyvTGgwGVm Y90vN8mKK5u+o97sYYfndJ0gsEtzt2RzNuwoS9K/jmnUpo1uk8SOA3hfXlUpppjh6GlZ mGPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=D/fY78byW0ZTjc+fdbG7dR5RkWaNYVrY5jk+sg6Jozo=; b=cYxbF8KjYmH6cu0bJd1bFd0Xjde5SyShX4KcERMLN1jTuM4Jgt0Y7jG3P0NDhL9X9u uomFvrqFNuC1TPnCv6qWJRvD8D/ER7pZD5Zf+Tj6qEqNGh2CaKGKuYXRla4B90It/SCe qfC9lO4X8P0O+KlIx0vuT8Evef4nU/vnohFvBYZQDNnB0TC+sohE4ES9HjASHKT32go0 WNjm9oGPY/RX24usmfxYOngeksgcvSWY5ur06Gl9qgfI707nY5/qtXqmevWs0zjy5MA/ riA4v1ZWdTP/hehTerEdj+hJp3FW7018CiuzoDZ5ynBJGQZE9FSc/odI7p8YxVniOBST bXjA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id q17si1398607edi.1.2019.11.04.02.01.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2019 02:01:54 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id xA4A1rEf013799 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Nov 2019 11:01:53 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.153]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xA4A1rMY010336; Mon, 4 Nov 2019 11:01:53 +0100 Date: Mon, 4 Nov 2019 11:01:52 +0100 From: Henning Schild To: Cc: isar-users Subject: Re: [PATCH 4/5] doc: write something about "debianize" Message-ID: <20191104110152.3f709f04@md1za8fc.ad001.siemens.net> In-Reply-To: <783feb0f-41d0-46fa-95a3-aa9ce9b0a5f9@googlegroups.com> References: <20191029164424.14681-1-henning.schild@siemens.com> <20191029164424.14681-5-henning.schild@siemens.com> <783feb0f-41d0-46fa-95a3-aa9ce9b0a5f9@googlegroups.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: rpDWphpzXdBI On Fri, 1 Nov 2019 00:08:35 -0700 wrote: > On Tuesday, October 29, 2019 at 5:44:28 PM UTC+1, Henning Schild > wrote: > > > > From: Henning Schild > > > > > Also add some comments to the implementation and extend the example > > recipe with some pre- and post-processing. > > > > Signed-off-by: Henning Schild > > > --- > > doc/user_manual.md | 19 > > ++++++++++++++++++- .../recipes-app/samefile/samefile_2.14.bb | > > 14 ++++++++++++++ meta/classes/debianize.bbclass | > > 6 ++++++ 3 files changed, 38 insertions(+), 1 deletion(-) > > > > diff --git a/doc/user_manual.md b/doc/user_manual.md > > index 34f50df..7c23fcc 100644 > > --- a/doc/user_manual.md > > +++ b/doc/user_manual.md > > @@ -583,7 +583,7 @@ Isar currently supports two ways of creating > > custom packages. > > > > The `deb` packages are built using `dpkg-buildpackage`, so the > > sources should contain the `debian` directory with necessary meta > > information. This way is the default way of adding software that > > needs to be compiled from source. The bbclass for this approach is > > called `dpkg`. > > -**NOTE:** If the sources do not contain a `debian` directory your > > recipe can fetch, create, or ship that. > > +**NOTE:** If the sources do not contain a `debian` directory your > > recipe can fetch, create, or ship that. You might want to read the > > the next section before returning here. > > > > This is also what you do if you want to rebuild/modify an upstream > > package. > > Isar does understand `SRC_URI` entries starting with "apt://". For > > an example > > @@ -624,6 +624,23 @@ This approach prevents duplication of the > > license files in different packages. > > > > The last line in the example above adds recipe to the Isar work > > chain. > > +### Compilation of sources missing the debian/-directory > > + > > +The `debian` directory contains meta information on how to build a > > package from source. This is roughly speaking "configure", > > "compile", "install" all described in a Debian-specific way. > > +Isar expects your sources to contain the `debian` folder and the > > above steps need to be described in it, not in a task in a recipe. > > + > > +So once you have sources you always need to combine them with a > > `debian` folder before Isar can build a package for you. > > +You might be able to find a debianization for a component on the > > internet, i.e. Ubuntu does package an open source component while > > Debian does not. Your recipe could download the `debian` folder > > from Ubuntu and the sources from the open source project. > > + > > +You can write it yourself, which can be pretty easy but requires a > > bit of studying. > > > > + > > +Isar does actually contain a helper that aims to "debianize" > > sources for your. If your package uses a build-system that Debian > > knows and follows the well known "configure", "compile", "install" > > scheme that debianization might just fit your needs without reading > > Debian manuals. +If it does not fully fit your needs, it probably > > gives you a good starting point for your manual tuning. > > + > > +The shell function `deb_debianize` creates a `debian` folder. But > > it will not overwrite files that already are in WORKDIR. So you can > > either just call it to fully generate the `debian` folder. Or you > > combine it with pre-existing parts. > > + > > +Have a look at meta-isar/recipes-app/samefile/samefile_2.14.bb and > > meta/classes/debianize.bbclass for an example and the > > implementation. > > + > > ### Packages without source > > > > If your customization is not about compiling from source there is > > a second way of creating `deb` packages. That way can be used for > > cases like: diff --git > > a/meta-isar/recipes-app/samefile/samefile_2.14.bb > > b/meta-isar/recipes-app/samefile/samefile_2.14.bb index > > a24d574..0ace85a 100644 --- > > a/meta-isar/recipes-app/samefile/samefile_2.14.bb +++ > > b/meta-isar/recipes-app/samefile/samefile_2.14.bb @@ -12,5 +12,19 > > @@ SRC_URI[md5sum] = "0b438249f3549f18b49cbb49b0473f70" > > do_prepare_build[cleandirs] += "${S}/debian" > > do_prepare_build() { > > + # you could also create parts of your debianization before > > + # pre-exisiting files will not be recreated > > + # 42 is not actually valid ... this is just a stupid example > > + echo 42 > "${WORKDIR}"/compat > > + > > + # this step creates everything dpkg-buildpackage needs, compat > > will not be > > + # overwritten > > deb_debianize > > + > > > > do we want to "read compat <${S}/compat" before we overwrite it just > to make sure it is still 42? and bbfatal if it isn't? > in other words is this recipe more of a test or of an example? > (either way is fine by me) It is an example that is abused for partial testing. Good testing would make it a bad example, so i will not change it. If we ever get a testing layer, thorough testing of debianization would be something to potentially add there. Henning > > > + # now if you are not happy you can post-process the result > > + # now let us "repair" the compat > > + echo 9 > "${S}/debian/compat" > > + # compat happens to be used by this step, so do that again > > + # see debianize.bbclass > > + deb_create_control > > } > > diff --git a/meta/classes/debianize.bbclass > > b/meta/classes/debianize.bbclass > > index fb9c234..e1c79ab 100644 > > --- a/meta/classes/debianize.bbclass > > +++ b/meta/classes/debianize.bbclass > > @@ -76,23 +76,29 @@ EOF > > } > > > > deb_debianize() { > > + # create the compat-file if there is no file with that > > name in WORKDIR > > if [ -f ${WORKDIR}/compat ]; then > > install -v -m 644 ${WORKDIR}/compat > > ${S}/debian/compat else > > deb_create_compat > > fi > > + # create the control-file if there is no contro-file in > > WORKDIR if [ -f ${WORKDIR}/control ]; then > > install -v -m 644 ${WORKDIR}/control > > ${S}/debian/control else > > deb_create_control > > fi > > + # create rules if WORKDIR does not contain a rules-file > > if [ -f ${WORKDIR}/rules ]; then > > install -v -m 755 ${WORKDIR}/rules > > ${S}/debian/rules else > > deb_create_rules > > fi > > + # prepend a changelog-entry unless an existing changelog > > file already > > + # contains an entry with CHANGELOG_V > > deb_add_changelog > > > > + # copy all hooks from WORKDIR into debian/, hooks are not > > generated > > for t in pre post > > do > > for a in inst rm > > -- > > 2.23.0 > > > > >