public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Baurzhan Ismagulov <ibr@radix50.net>,
	chombourger@gmail.com,
	Henning Schild <henning.schild@siemens.com>
Subject: [PATCHv3 8/9] bootstrap: fix debootstrap gpg issue when base-apt is not signed
Date: Thu,  7 Nov 2019 19:56:02 +0100	[thread overview]
Message-ID: <20191107185603.9077-9-henning.schild@siemens.com> (raw)
In-Reply-To: <20191107185603.9077-1-henning.schild@siemens.com>

From: Henning Schild <henning.schild@siemens.com>

DISTRO_BOOTSTRAP_KEYRING will not exist if DISTRO_BOOTSTRAP_KEYFILES is empty.
So the debootstrap argument will not work.
Simplify the logic to depend on the existance of the keyring-file.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index 203a557..b506f30 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -231,14 +231,10 @@ isar_bootstrap() {
         shift
     done
     debootstrap_args="--verbose --variant=minbase --include=${DISTRO_BOOTSTRAP_BASE_PACKAGES}"
-    if [ ! "x${DISTRO_BOOTSTRAP_KEYS}" = "x" ] || \
-       [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
+    if [ -f "${DISTRO_BOOTSTRAP_KEYRING}" ]; then
         debootstrap_args="$debootstrap_args --keyring=${DISTRO_BOOTSTRAP_KEYRING}"
-    fi
-    if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
-        if [ -z "${BASE_REPO_KEY}" ] ; then
-            debootstrap_args="$debootstrap_args --no-check-gpg"
-        fi
+    else
+        debootstrap_args="$debootstrap_args --no-check-gpg"
     fi
     E="${@ isar_export_proxies(d)}"
     export IS_HOST debootstrap_args E
-- 
2.23.0


  parent reply	other threads:[~2019-11-07 18:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 18:55 [PATCHv3 0/9] a few cleanups a bug and a feature Henning Schild
2019-11-07 18:55 ` [PATCHv3 1/9] rootfs: fix incorrect feature name in comment Henning Schild
2019-11-07 18:55 ` [PATCHv3 2/9] base_apt_helper: change variable names to increase readability Henning Schild
2019-11-07 18:55 ` [PATCHv3 3/9] rootfs: rename ROOTFS_INSTALL_COMMAND lock to "isar-apt-lock" Henning Schild
2019-11-07 18:55 ` [PATCHv3 4/9] dpkg-base: remove pointless ";" s at end of line Henning Schild
2019-11-07 18:55 ` [PATCHv3 5/9] dpkg-base: fix indentation from tabs to spaces Henning Schild
2019-11-07 18:56 ` [PATCHv3 6/9] base: implement BB_NO_NETWORK for apt-get Henning Schild
2019-11-07 18:56 ` [PATCHv3 7/9] meta: do not equip rootfss with resolv.conf when BB_NO_NETWORK Henning Schild
2019-11-07 18:56 ` Henning Schild [this message]
2019-11-14 20:11   ` [PATCHv3 8/9] bootstrap: fix debootstrap gpg issue when base-apt is not signed Jan Kiszka
2019-11-14 21:45     ` Henning Schild
2019-11-15  6:07       ` Baurzhan Ismagulov
2019-11-07 18:56 ` [PATCHv3 9/9] meta: dpkg-gbp: remove unneeded proxy export Henning Schild
2019-11-12 16:39 ` [PATCHv3 0/9] a few cleanups a bug and a feature Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107185603.9077-9-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=chombourger@gmail.com \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox