From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6753266853568577536 X-Received: by 2002:a05:600c:212:: with SMTP id 18mr4448885wmi.93.1573152035066; Thu, 07 Nov 2019 10:40:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4050:: with SMTP id w16ls2914347wrp.13.gmail; Thu, 07 Nov 2019 10:40:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyGm1oD/hDevWHlN09bTuqOvG/EGl42buh3u4S2fO2GKh8DYz0hv1ojyx3hmOKPsls5/DOW X-Received: by 2002:adf:f490:: with SMTP id l16mr4365006wro.77.1573152034423; Thu, 07 Nov 2019 10:40:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573152034; cv=none; d=google.com; s=arc-20160816; b=Q4Qy9E2rw0j5Wn5Nspuf1pYdvAuC2xHzOBBi6NpP4fEYlWgNgmOhxKV2J0T1D3WXCj N/oAtAEcyQlfsVOcLgqZzlgSjUWjEsq48pBmNIyZF/k6jx8XDxIB1ksbtDGXCF1xY2qw aoXpN7hXWx3LP7xQnCWftSyI8qmXyzItWsRedbSH8eiLjIUY0gNIs0f00fvA0KDDLRDn 9n9bOi2MJU3LGKyUeNOeBHvt3/d6TT4Hr7euT55pF1CanBk3wqBn6M6jL8UseMINzX9e aEJxuWsZoBp8/FyGkWLM6XvVQfgl7iXi5z88Hf3wDi/3H3Tw0LcyrF8VwRZWTVk7nvrt GjZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=qabF7zXPi8rSj7eO1MTK2KLtAl27J5g7M9gqvrOEq0Y=; b=zziYpvRWy9kHS+KxsgklLVvonuuk3gwFEhjZ5nYW6qUlcwSockmhYkjaxnykT1Xp6J sbapvKqRkJwg5/D3BcEZXDqS8UV+/3coKAuvdis5PCL5tX1g2FqKPcVrznPZ99SRT1u6 6TZYIP5mLtwMn0wcuuwYYi0E0XDdFZTJRYWG/IXsPIl2ss/8HtslenlVI6h4vez0vaPR f9cm5tsOs7GKEN1Ia5say5QTaF/r7EQ0vhnfG4QFAeFCmxy9g/rfu7WHdkDy0eZ2ILxl aaAQ1hkIvnkjNHpvOh7Lko6z0cJVBXPNVLLlFoEC2ZdZVZBRsNfCaOF3aKN1f5OI7Vwg i3Hw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id b198si476882wmd.4.2019.11.07.10.40.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Nov 2019 10:40:34 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id xA7IeYQ0020830 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 Nov 2019 19:40:34 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.32]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xA7IeWsZ015041; Thu, 7 Nov 2019 19:40:32 +0100 Date: Thu, 7 Nov 2019 19:40:32 +0100 From: Henning Schild To: Jan Kiszka Cc: , "Dalamagkidis, Konstantinos" Subject: Re: [PATCH 2/5] debianize: move variable defaults to the class that needs them Message-ID: <20191107194032.046acb41@md1za8fc.ad001.siemens.net> In-Reply-To: <822ff1c8-77c7-3835-8722-f8b07f026c23@siemens.com> References: <20191029164424.14681-1-henning.schild@siemens.com> <20191029164424.14681-3-henning.schild@siemens.com> <822ff1c8-77c7-3835-8722-f8b07f026c23@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Ss0CUdNrMIGa Am Wed, 6 Nov 2019 17:20:10 +0100 schrieb Jan Kiszka : > On 29.10.19 17:44, Henning Schild wrote: > > From: Henning Schild > > > > Signed-off-by: Henning Schild > > --- > > meta/classes/debianize.bbclass | 3 +++ > > meta/classes/dpkg-raw.bbclass | 3 --- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/meta/classes/debianize.bbclass > > b/meta/classes/debianize.bbclass index 33ab4f7..fb9c234 100644 > > --- a/meta/classes/debianize.bbclass > > +++ b/meta/classes/debianize.bbclass > > @@ -5,6 +5,9 @@ > > > > CHANGELOG_V ?= "${PV}" > > DPKG_ARCH ??= "any" > > +DEBIAN_DEPENDS ?= "" > > +DESCRIPTION ?= "must not be empty" > > Then, shouldn't we rather leave it empty here and fail if it remains > so? Not sure, and guess not. We have working but incorrect defaults for all values, see the silly MAINTAINER below. Will keep it like that for now. Henning > > +MAINTAINER ?= "Unknown maintainer " > > > > deb_add_changelog() { > > timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*" > > -printf "%T@\n"|sort -n -r|head -n 1) diff --git > > a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass > > index 3f19f8e..8c01a46 100644 --- a/meta/classes/dpkg-raw.bbclass > > +++ b/meta/classes/dpkg-raw.bbclass > > @@ -5,9 +5,6 @@ > > > > inherit dpkg > > > > -DEBIAN_DEPENDS ?= "" > > -MAINTAINER ?= "Unknown maintainer " > > - > > D = "${S}" > > > > # Populate folder that will be picked up as package > > > > Jan >