From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6756899790246641664 X-Received: by 2002:adf:ea07:: with SMTP id q7mr9791692wrm.78.1573234914806; Fri, 08 Nov 2019 09:41:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f091:: with SMTP id n17ls6954377wro.4.gmail; Fri, 08 Nov 2019 09:41:54 -0800 (PST) X-Google-Smtp-Source: APXvYqzTNtYzwtfcUe+J2kQgWxVqE4wVEXLaHh2wupfVRuTVf3KA/No+uhq+ugXi5UGsrFgM4CJs X-Received: by 2002:adf:91e1:: with SMTP id 88mr10246486wri.16.1573234914113; Fri, 08 Nov 2019 09:41:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573234914; cv=none; d=google.com; s=arc-20160816; b=Qkhj4uLIqSCpN1lfQ3tRCnhawL2U7Y9e2FfGzjHU2mMOH+S0xwDOWCZpDlrdOyf4Gf aAxRUVmvheJOGZi95RNWZpD09xPY1DV86HCW/Uzhjre4gk9zK4t+5bL+IjyBRTv241+G lryOnaAEVU74WhO9fcKJAGgYt1aytDJk4I4g866hHJ6GKlMyZ5ueOwDL0yjfbKqkD9Xi e1sCTtHaZKW+OEbTIUHmxeqA0JK3nevc0ki4IL2yZj7CqJV3YyLAeward3aBrma8HNwN QcHMphhGE84YfnZ6n5iIYpPBP5WKgL8p6xU8CVTpb3Zvwv5J9YBVIxDUeDuba0bdYnUV YPRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=87kHC+hSc/htl311f3fXm6UHF90mr/tE8b3Z+GdqiBU=; b=Y6VpN1bYPYlBnS7ga/VzpFe+EcSSofJAdpu0eQZmS8NEkc0bb6T71DbuUHmsHJHWOX G8zxW9C2YfUsRnjgIHMI6ThmOmX6hfOWmuQnGsO5P0LuMxrxf4Hrz5fRSg3xa67myMR+ BqOxLOs0+YSiks2z+iMpp3F+4se8KSryX1v4BTIJ1zgNb/HMRgdJBFtVCkhR1+ucBTmb 27cSuyy0YDaU4XXapx+TfsWCUlqy8rdxjyOHKW9keJBOfJ0EDim+ykYSM1qtdmrzH3Hh 0lg9Wm8/uYucaXt+3KIn7Yww8U/WmVXPYZJMDXlW2Z+GNlxCaZfidIHMX/RPfKoTVwMo 2POg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DvXqAbaG; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com. [2a00:1450:4864:20::343]) by gmr-mx.google.com with ESMTPS id y188si409618wmc.0.2019.11.08.09.41.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 09:41:54 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) client-ip=2a00:1450:4864:20::343; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DvXqAbaG; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x343.google.com with SMTP id z26so7009647wmi.4 for ; Fri, 08 Nov 2019 09:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=87kHC+hSc/htl311f3fXm6UHF90mr/tE8b3Z+GdqiBU=; b=DvXqAbaGi3w7g13fFzNnSOqfzH3IQzrZ2jntQmb8JSdzyWAAbYhscuL3Fo7dsFY2pP GGMJE0elZlxzZinhtp5LXY3RPsBE7ka7UHKw/58QIL/S7GhfV2mByPKgTC3zPx0wjOGM 1c4gxT11nglLP1ewTWh9lRAwMBRzfWZFKwCzZZefMUAxg54agluNSOS1TCaMsvcuPXzn vSK2uZ43cswwHqU2+XiTkmr5SE1RlJQKwCeazM3bq71HwgqrZQULWZuy96YUI3zmRXxl BfAbejbvqfxHaPit5wOzA1tR4DonW1bAFsaVyGoyLJ55L7NVjAHXncpFEsP3s7ZyZp+X dFKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=87kHC+hSc/htl311f3fXm6UHF90mr/tE8b3Z+GdqiBU=; b=Q4dBj/nPRHtaXqdCZejzTyjicRsiagiNApXpFMjvFlo/3E2a8YERVuCZy5SOaHo2hX NC92riKrtNUU5wcM/MP8omecEJwJOZxydQ+H61MePaHs0YR801F5XFkJtUvl/S5UsOyA cEbi+6uW0Plwe1iT5dlKq8NHCxMJymQRk82X9RHpy1hkSXFiTSc5Djnt2pc0UWtBl6vc Q1OFOmIYbKa1yZcpxSNmko8rsITqYI18HmhClMyRK3k24iPzNXrVVuX1SPHCtFEF6Eks /NgRHixdXHjBtO8ptYq0pxROiItgUBrUr+8/fJqm4n728EB+zpHO874FG0MWWROY/9ow BeCQ== X-Gm-Message-State: APjAAAVqCoBZ3IGDrU3XFwjJrULMNA0htpMyi+WBIM+pIc7hHQ6uIA1J fZnRgoUE3GWY5wVgvqHQvJI= X-Received: by 2002:a7b:c0c3:: with SMTP id s3mr9028268wmh.20.1573234913618; Fri, 08 Nov 2019 09:41:53 -0800 (PST) Return-Path: Received: from oxygen (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id b17sm6748082wrr.37.2019.11.08.09.41.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Nov 2019 09:41:53 -0800 (PST) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Fri, 8 Nov 2019 23:11:48 +0530 To: Henning Schild Cc: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com Subject: Re: [PATCH] meta/classes: Make sure the files exists before copying Message-ID: <20191108174148.GA9643@oxygen> References: <20191108114158.30076-1-Vijaikumar_Kangarajan@mentor.com> <20191108181055.16316147@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108181055.16316147@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: HiSDNwj+hmXQ On Fri, Nov 08, 2019 at 06:10:55PM +0100, Henning Schild wrote: > Am Fri, 8 Nov 2019 17:11:58 +0530 > schrieb : > > > From: Vijai Kumar K > > > > By default realpath doesnot check if the file exists and hence > > might return an invalid path. Use -e to check if the file actually > > exists. > > > > Signed-off-by: Vijai Kumar K > > --- > > meta/classes/image.bbclass | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > > index 8384b71..5b2eee0 100644 > > --- a/meta/classes/image.bbclass > > +++ b/meta/classes/image.bbclass > > @@ -128,12 +128,12 @@ EOF > > > > do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" > > do_copy_boot_files() { > > - kernel="$(realpath -q '${IMAGE_ROOTFS}/${KERNEL_FILE}')" > > + kernel="$(realpath -eq '${IMAGE_ROOTFS}/${KERNEL_FILE}')" > > if [ -n "$kernel" ]; then > > cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}' > > fi > > > > - initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')" > > + initrd="$(realpath -eq '${IMAGE_ROOTFS}/initrd.img')" > > if [ -n "$initrd" ]; then > > cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}' > > fi > > I would rather convert the "-n" checks into "-f". It is the same but i > think more readable. People are more likely to know test -f than > realpath -q ... i guess. I had that dilemma. Decided to go with -e since realpath had that provision. We could use -f as well, if that makes code more readable. Will send a v2. Thanks, Vijai Kumar K > > Henning