From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6756899790246641664 X-Received: by 2002:aa7:d44c:: with SMTP id q12mr11648281edr.108.1573235265091; Fri, 08 Nov 2019 09:47:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:907:2175:: with SMTP id rl21ls67015ejb.3.gmail; Fri, 08 Nov 2019 09:47:44 -0800 (PST) X-Google-Smtp-Source: APXvYqwTLy6B7eGhrsKQFKuFd64M0ElnsYsPRm/pPPy8omAxvx29Dvq62nMBh12uXZvVeNT+mIlq X-Received: by 2002:a17:906:c30a:: with SMTP id s10mr3485072ejz.9.1573235264647; Fri, 08 Nov 2019 09:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573235264; cv=none; d=google.com; s=arc-20160816; b=ePu/1nlUlOXsAZ7rlE4Xffd3ZNW5+FXNsQY5b95qonz4LXlX2ELHgUgsOImJHBJQCF +FYgh+fTtxweTjJP/PBhCv9ih+EDtv+YRG4ORkbHP5qkDBqPPcKIcP2ESUlc1D3FIyMb /5hP7nWGkr9rFwXvN4CREuySNE5l3h6vKasoNVpBOyMSz/HiIkq939WSJIcT/KnxLQYs YJtKBnsDTMD7GCV91fqvf+a7tKTZRziEGQC8Cl5GvIJ0HTKCEk1fQW7KfCoYVkGU31T4 mF/Mab3spKtGfx7Zq5zlOCV3mbo2aH/KgN4VuX0lV52cCPd7Dz9kmZnXGQrB+3LvX8jp d4DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VmOLjxfy125qx9QSpTn38229vCf3/X6gIIat/XZS9ds=; b=IYFqaUaBCBrkF747dlqV/aUAOkLWnJQpHiJGnprFhX/uwCcVX/Hbjdb6/HgQ3u86LN WfM93vhFs4I/roIwxtb/8212nL22HAcpX6Xe2ijspgvTKB8uAY8P7DDbXFQsHOcnZMZN 4saoDwwi3n8ME5szYM6zBO+S5qqNXHMSCTyJNcP3RE9KSJP1TREuF1ulvap/QPnN1JkX KJ9QSoMuopnycgngmNPJ/N3RTYekfSXXN/Ex5TZnLv86pY/rYuncabUlLiFMQe0f/Ogx BqUDWzgbRazyIfdnegEloi8gOdqUzGvx2bJzd7u5d0X7Kf56yYqzeUwhCvcmAYEPDzLw 5LIg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GU+rVDxD; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com. [2a00:1450:4864:20::441]) by gmr-mx.google.com with ESMTPS id v57si671010edc.3.2019.11.08.09.47.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 09:47:44 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) client-ip=2a00:1450:4864:20::441; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GU+rVDxD; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x441.google.com with SMTP id p2so8054464wro.2 for ; Fri, 08 Nov 2019 09:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VmOLjxfy125qx9QSpTn38229vCf3/X6gIIat/XZS9ds=; b=GU+rVDxDXiPMNsFkpX/3P5oWxvaBjHXMDJx1oVwCEiKYLkfJjxtRdnkNPtcvqvVYnZ NO281ah2xY218Z5NmCfJRlYEeLg0OvBjbjoyFKxuRJApMi+lSGX3h8eeR5F4BP3Th2g8 ih6qsT77pV97SNFDL8lkxNRRFLuPlxwElBqiXY494sYsJE7gyT9xLGZ0Xkt5ka/sA9k4 4AKngO49fKahpZtLShLz+1qPTXJ42A2o3EpdnLumG5/2fAX9af+B2SVn+qae9Le2PKQP Faw8EKMUnLpAR5Xq8Molqsm+Bmossei+SJC+keX3uVyJcWoq+WZWh3TKOCK85rs6n3gC x1xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VmOLjxfy125qx9QSpTn38229vCf3/X6gIIat/XZS9ds=; b=Yz7CrBxU3DVgTFrkh1RHkeLSadOdilD/1Z31bqB9/QqhrBQvTcndg3r1Tp7VB5L56Y bUMUTEGyK3tIURnnW7CJmZxN3XOUHdOHGDZA/02LfedJUfx1tYYtJLzbKcvdNM3ucqFA 7yJOcWo/VKPs4IH8WVHzKVit0UG7EbREzPBeZPMThH5tpXA24IMLBdG9+1TDaY0kbq7p 8lLmloOHI1LZR/sLx/A2klSEyZtYOUlriXjrL3cuqTWApPRWYjx527nthllSbVvKsxli Sy17zZnvfVL7HoNHuG2Y02OMgR6nrz08N17u0heF/Fs7srxzbByZY84HRRTK2m+rd66B srVw== X-Gm-Message-State: APjAAAVOrSbHKsM18rdLLbat929iqNgXBjS2oP8LzEUNuZqFUflRhg6U Mi2ePxrLDNtDvOYkmClw6nmBinJ7I6I= X-Received: by 2002:a5d:444b:: with SMTP id x11mr9701313wrr.207.1573235264094; Fri, 08 Nov 2019 09:47:44 -0800 (PST) Return-Path: Received: from oxygen.mgc.mentorg.com (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id g11sm6194679wmh.27.2019.11.08.09.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 09:47:43 -0800 (PST) From: vijaikumar.kanagarajan@gmail.com X-Google-Original-From: Vijaikumar_Kangarajan@mentor.com To: isar-users@googlegroups.com, henning.schild@siemens.com Cc: Vijai Kumar K Subject: [PATCH v2] meta/classes: Make sure the files exists before copying Date: Fri, 8 Nov 2019 23:17:35 +0530 Message-Id: <20191108174735.9998-1-Vijaikumar_Kangarajan@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191108174148.GA9643@oxygen> References: <20191108174148.GA9643@oxygen> X-TUID: N0ISTQdhUxf5 From: Vijai Kumar K By default realpath doesnot check if the file exists and hence might return an invalid path. Check if file exists before copying. Signed-off-by: Vijai Kumar K --- Changes in v2: - Use -f in if condition instead of realpath -e to make code more readable. meta/classes/image.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 8384b71..c845eab 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -129,12 +129,12 @@ EOF do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" do_copy_boot_files() { kernel="$(realpath -q '${IMAGE_ROOTFS}/${KERNEL_FILE}')" - if [ -n "$kernel" ]; then + if [ -f "$kernel" ]; then cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}' fi initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')" - if [ -n "$initrd" ]; then + if [ -f "$initrd" ]; then cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}' fi -- 2.17.1