Re: [PATCH] meta/classes: Make sure the files exists before copying

[Henning Schild <henning.schild@siemens.com>]

Am Fri, 8 Nov 2019 17:11:58 +0530
schrieb <vijaikumar.kanagarajan@gmail.com>:

> From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> 
> By default realpath doesnot check if the file exists and hence
> might return an invalid path. Use -e to check if the file actually
> exists.
> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
>  meta/classes/image.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 8384b71..5b2eee0 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -128,12 +128,12 @@ EOF
>  
>  do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}"
>  do_copy_boot_files() {
> -    kernel="$(realpath -q '${IMAGE_ROOTFS}/${KERNEL_FILE}')"
> +    kernel="$(realpath -eq '${IMAGE_ROOTFS}/${KERNEL_FILE}')"
>      if [ -n "$kernel" ]; then
>          cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}'
>      fi
>  
> -    initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')"
> +    initrd="$(realpath -eq '${IMAGE_ROOTFS}/initrd.img')"
>      if [ -n "$initrd" ]; then
>          cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}'
>      fi

I would rather convert the "-n" checks into "-f". It is the same but i
think more readable. People are more likely to know test -f than
realpath -q ... i guess.

Henning