From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6756899790246641664 X-Received: by 2002:adf:fec7:: with SMTP id q7mr9711188wrs.267.1573233065605; Fri, 08 Nov 2019 09:11:05 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4b43:: with SMTP id w3ls3089629wrs.5.gmail; Fri, 08 Nov 2019 09:11:05 -0800 (PST) X-Google-Smtp-Source: APXvYqztHStR4aGDo3Ls8HN94FIeTv1AZsbBEfbryb3KENpUPIP5edWeNpwyHTwNt67fOxklZaRL X-Received: by 2002:a5d:4a45:: with SMTP id v5mr10042328wrs.288.1573233064996; Fri, 08 Nov 2019 09:11:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573233064; cv=none; d=google.com; s=arc-20160816; b=0beegKcc5HqYsh1D+qkn9ZGCHYOSi0SZyxFlfkDgdpxfZZdyVhXl+eF7uwjtsWJ/B9 VP3nNoiQpnGGdIKv4iNTdsSRjj6PcL1oWOi96FZ2d6mJw6QQYCi5iXX0lC6EB4yMEge7 gksHDRRXShD8JPSga2Yq0gw1WfVWfwlVJRfeKQs76S2K/TKKetpWxhV9j9zBz90gBCdK dNXw8sARcbpzMmsgg3/TjY2MPkL75QF26QYJtZZ/kHxUsTrHmZL3L9BWmBs+wi8VB08Z tzPyyAKrbI4YCHpIjd9XrHHX8EiHf5oPTViFggJUxz39rETZfqrzx8p60A6K6rINVv0b OAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=AE2qDArsAbcyAG4ZNnGULANnLuZ4TDFGE0mSYLNc4N4=; b=hWiYyg+d3W41g1UGi2aoSKR7scIFqT8nkmQZUNfLNpQktBwQ45MFzM+3LKI7k9K6eZ iN71XeLdkoHLAIaksy+x0/4jqgMSCwh1JrEuc3MJ2xodOvr8hv1ke7/GVaBr9/OtURJj aSkzKydORN+wcji3K1hMYz+PTbz2ocH3lHyx7ISNizBTaoSkO0iPZxiGtLIcsWSIrMUC 4G/bZK4rpczD/RvzH2ZOwUHX4V6o7pilPvm29nU+6tNaI4MixE9215cU52Uv2YAZR4r9 fIj6uH17kAU29L0tGNUlGxnGdivrEogNlFIJtH2ofR+oiWe+vIKIMPBSKjzO+Z010J9H C9mg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id y188si403786wmc.0.2019.11.08.09.11.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Nov 2019 09:11:04 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xA8HB4NQ005312 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Nov 2019 18:11:04 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.32]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xA8HB4IS022936; Fri, 8 Nov 2019 18:11:04 +0100 Date: Fri, 8 Nov 2019 18:10:55 +0100 From: Henning Schild To: Cc: , Vijai Kumar K Subject: Re: [PATCH] meta/classes: Make sure the files exists before copying Message-ID: <20191108181055.16316147@md1za8fc.ad001.siemens.net> In-Reply-To: <20191108114158.30076-1-Vijaikumar_Kangarajan@mentor.com> References: <20191108114158.30076-1-Vijaikumar_Kangarajan@mentor.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: HyBdSXMInxLX Am Fri, 8 Nov 2019 17:11:58 +0530 schrieb : > From: Vijai Kumar K > > By default realpath doesnot check if the file exists and hence > might return an invalid path. Use -e to check if the file actually > exists. > > Signed-off-by: Vijai Kumar K > --- > meta/classes/image.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 8384b71..5b2eee0 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -128,12 +128,12 @@ EOF > > do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" > do_copy_boot_files() { > - kernel="$(realpath -q '${IMAGE_ROOTFS}/${KERNEL_FILE}')" > + kernel="$(realpath -eq '${IMAGE_ROOTFS}/${KERNEL_FILE}')" > if [ -n "$kernel" ]; then > cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}' > fi > > - initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')" > + initrd="$(realpath -eq '${IMAGE_ROOTFS}/initrd.img')" > if [ -n "$initrd" ]; then > cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}' > fi I would rather convert the "-n" checks into "-f". It is the same but i think more readable. People are more likely to know test -f than realpath -q ... i guess. Henning