[PATCH] isar-events: Hook into BuildStarted for task-once cleanup

[PATCH] isar-events: Hook into BuildStarted for task-once cleanup

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

The Parse* events are unfortunately only fired when there is no cache.
Hooking into the BuildStarted does not have this shortcoming, just
implies multiple events (one per multiconfig), but that is harmless.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/isar-events.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
index cad1d57..4c49635 100644
--- a/meta/classes/isar-events.bbclass
+++ b/meta/classes/isar-events.bbclass
@@ -4,12 +4,12 @@
 # Copyright (C) 2015-2017 ilbers GmbH
 # Copyright (c) Siemens AG, 2018
 
-addhandler parse_completed
+addhandler build_started
 
-python parse_completed() {
+python build_started() {
     bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*")
 }
-parse_completed[eventmask] = "bb.event.ParseCompleted"
+build_started[eventmask] = "bb.event.BuildStarted"
 
 def task_once_stamp(d):
     return "{temp}/once.{task}".format(temp=d.getVar('T'),
-- 
2.16.4


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] isar-events: Hook into BuildStarted for task-once cleanup

[Jan Kiszka]

On 05.11.19 18:23, [ext] Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> The Parse* events are unfortunately only fired when there is no cache.
> Hooking into the BuildStarted does not have this shortcoming, just
> implies multiple events (one per multiconfig), but that is harmless.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta/classes/isar-events.bbclass | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
> index cad1d57..4c49635 100644
> --- a/meta/classes/isar-events.bbclass
> +++ b/meta/classes/isar-events.bbclass
> @@ -4,12 +4,12 @@
>   # Copyright (C) 2015-2017 ilbers GmbH
>   # Copyright (c) Siemens AG, 2018
>   
> -addhandler parse_completed
> +addhandler build_started
>   
> -python parse_completed() {
> +python build_started() {
>       bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*")
>   }
> -parse_completed[eventmask] = "bb.event.ParseCompleted"
> +build_started[eventmask] = "bb.event.BuildStarted"
>   
>   def task_once_stamp(d):
>       return "{temp}/once.{task}".format(temp=d.getVar('T'),
> 

I think this should take a fast-path as it resolves many wrong and 
misleading error messages.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] isar-events: Hook into BuildStarted for task-once cleanup

[Baurzhan Ismagulov]

On Tue, Nov 05, 2019 at 06:23:34PM +0100, Jan Kiszka wrote:
> The Parse* events are unfortunately only fired when there is no cache.
> Hooking into the BuildStarted does not have this shortcoming, just
> implies multiple events (one per multiconfig), but that is harmless.

Applied to next, thanks.

With kind regards,
Baurzhan.