From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750962531146137600 X-Received: by 2002:a7b:ce08:: with SMTP id m8mr10609216wmc.68.1573767934149; Thu, 14 Nov 2019 13:45:34 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1:: with SMTP id g1ls12295323wmc.2.canary-gmail; Thu, 14 Nov 2019 13:45:32 -0800 (PST) X-Google-Smtp-Source: APXvYqylDscUCAyfHpuROSyv0670P78jRggpw1D5xd3C1OQC2G/irf4pDP3JcOxc1qFjJByC+WE+ X-Received: by 2002:a1c:7d94:: with SMTP id y142mr11395256wmc.168.1573767932854; Thu, 14 Nov 2019 13:45:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573767932; cv=none; d=google.com; s=arc-20160816; b=MOsRAdy8N+dvzYESXa8pKoxHgIi03RV1g7lbId8RB+UEK+I9Zqz1XARp19V8sJ9pf5 FxJWHeIDlpfoYKY1ILItqqedOmHDfB2CbzCuF1UFmbddCdSd2nvgbUICIUB3q3FlWwEy wz2LlKyr7wha0sWeMEbT/vaR/uhCnKa4MaZ2saKMfbhz/CDbtvfiX/yu4EJGfRfkq8HJ 1LxARl2wMhIRMKmEFGhH9lotKLmVrSGXxK3eiJGsGV6LjQkGD62MbEIxNEvCFDUPMLro sqCmT0CzAy2hFn2nfl+P7CNWAkBfHWMZ7f2Si3bZYWBk0Gb4P6gCZXYeZneYi0r7SIGZ sTbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Q1W4pgUtGsGJnRq6OwnGAyMLWuAsbPLZDbDs508ctmo=; b=AL4DVfBJzL4zjB1rdX7XmtVI+/PajLE6lYQ2JmjXwAOjlexB5EaOt7ztG3q9WEf+Ss PVBxLt39kSawoVQ0lwybIs2ERJRkd1stSxLdzWo9AL9ZRnIovCaB4OQavsR4KGatEqlU fWwoVZTitbnXNDaQKGwewtVrG7s/KaFyd8it4Tc7qSpTokjjFYIwGprj9I6eQrWjNCpb d+swBZH4Kv+fKyX9qXXqmtIUcaphym0Z3RzH9vgpONGlj0eSFE/OoNFAPBU086t9NsdN RseUmEyvHRiRV9Gzo8jVg/V5A2zNuNYST4ohQz4A96KlLqzf3jyu+dQMpjPsE3f5eITx +jmg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id c12si254950edy.1.2019.11.14.13.45.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 13:45:32 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xAELjVeb006199 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2019 22:45:31 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.134.236]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xAELjTiv026010; Thu, 14 Nov 2019 22:45:30 +0100 Date: Thu, 14 Nov 2019 22:45:25 +0100 From: Henning Schild To: Jan Kiszka Cc: , Baurzhan Ismagulov , Subject: Re: [PATCHv3 8/9] bootstrap: fix debootstrap gpg issue when base-apt is not signed Message-ID: <20191114224525.697987ee@md1za8fc.ad001.siemens.net> In-Reply-To: <6825fdd8-f85f-e71c-6f63-ad3ddf1ffc8e@siemens.com> References: <20191107185603.9077-1-henning.schild@siemens.com> <20191107185603.9077-9-henning.schild@siemens.com> <6825fdd8-f85f-e71c-6f63-ad3ddf1ffc8e@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: nhroyAwf8ovw On Thu, 14 Nov 2019 21:11:23 +0100 Jan Kiszka wrote: > On 07.11.19 19:56, Henning Schild wrote: > > From: Henning Schild > > > > DISTRO_BOOTSTRAP_KEYRING will not exist if > > DISTRO_BOOTSTRAP_KEYFILES is empty. So the debootstrap argument > > will not work. Simplify the logic to depend on the existance of the > > keyring-file. > > > > Signed-off-by: Henning Schild > > --- > > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 10 > > +++------- 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > > 203a557..b506f30 100644 --- > > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -231,14 > > +231,10 @@ isar_bootstrap() { shift > > done > > debootstrap_args="--verbose --variant=minbase > > --include=${DISTRO_BOOTSTRAP_BASE_PACKAGES}" > > - if [ ! "x${DISTRO_BOOTSTRAP_KEYS}" = "x" ] || \ > > - [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then > > + if [ -f "${DISTRO_BOOTSTRAP_KEYRING}" ]; then > > debootstrap_args="$debootstrap_args > > --keyring=${DISTRO_BOOTSTRAP_KEYRING}" > > - fi > > - if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then > > - if [ -z "${BASE_REPO_KEY}" ] ; then > > - debootstrap_args="$debootstrap_args --no-check-gpg" > > - fi > > + else > > + debootstrap_args="$debootstrap_args --no-check-gpg" > > fi > > E="${@ isar_export_proxies(d)}" > > export IS_HOST debootstrap_args E > > > > Breaks with non-empty DISTRO_BOOTSTRAP_KEYS and a non-signed base-apt. Thanks. I will come up with a fix ASAP. The key problem is that ci_build.sh has too many knobs and does not test the repo build in all its beauty. In fact this fix should have come with a test that shows the problem it fixed in the first place. So i guess my fix will come with another change that simplifies the build script and reduces the number of knobs. Maybe in the end just one, fast|full. Where full would do the offline build signed, unsigned, with other keys and without, and with+out any other variation i find on the way. Henning > Jan >