public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH v3 0/2] Fix gpg bootstrap when not signed
Date: Mon, 18 Nov 2019 18:55:03 +0100	[thread overview]
Message-ID: <20191118185503.16f26b06@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20191118170850.12861-1-ibr@radix50.net>

Thanks for the fixes. Looks good to me.

Am Mon, 18 Nov 2019 18:08:48 +0100
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> Changes in v3:
> 
> - 0001:
>   - Remove trailing white space.
>   - Change tabs to spaces.
>   - Added "signed" / "unsigned" to the comments, identical comments
> before different code is confusing.
> - 0002:
>   - Call test once.

I recently started linting my shell code with shellcheck. It would not
like that, but it is fine with me.

Henning

>   - Fix a typo in the commit message.
> 


      parent reply	other threads:[~2019-11-18 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 17:08 Baurzhan Ismagulov
2019-11-18 17:08 ` [PATCH v3 1/2] ci: always test signed and unsigned repo builds Baurzhan Ismagulov
2019-11-18 17:08 ` [PATCH v3 2/2] bootstrap: really fix gpg bootstrap when not signed Baurzhan Ismagulov
2019-11-18 17:55 ` Henning Schild [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118185503.16f26b06@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox