Re: [PATCH v4 - misc fixes 0/6] miscellaneous (minor) fixes

[Baurzhan Ismagulov <ibr@radix50.net>]

On Fri, Nov 15, 2019 at 08:59:15AM -0800, chombourger@gmail.com wrote:
> Rebased locally (it did apply cleanly for me) - will anyway send v5

Yes, I've seen this behavior -- rebase is fine, git am fails. Usually that was
due the changes in the context lines (git am is possibly pickier than rebase
for whatever reason), but in this case I couldn't identify any changes in the
context lines, either.


> I can check what upstream does but to answer the other question, clean 
> unfortunately leaves them behind

Isar -- yes, I had checked. The question was about the Yocto clean. Just in
case anyone has an answer.


> WICTMP is created with mktemp -d so I wonder if we would have to store it 
> somewhere if we wanted to keep files in the buildchroot
> but delete them when we run do_clean
>  
> should we introduce WIC_DEBUG?= "0" and keep them if it was set to "1"?

To make it clear, overall I'm willing to apply the series as is in v4. I'll
check v5 and let you know. I had thought about WIC_DEBUG, but I think it isn't
worth the effort. We don't modify the file, so having copies is useful only for
rare cases. OTOH, it eats space and the user might not be aware of that.


> that sounds like a good idea but do we want to expand the scope of this 
> patch series?

No, I'd also like to avoid expanding the scope.


> As an aside, do we have a central TODO list where we can record things we 
> really want to
> get done before we release something like 1.0? I recall seeing e-mails from 
> different people
> with own lists. Should we have it in the repo so it's easy to find?

We used to have it. We've removed it after a discussion here and possibly
offline. Some issues have been moved to GitHub. Feel free to create new issues
there.


With kind regards,
Baurzhan.