Re: [PATCH 00/17] base-apt rework

[Baurzhan Ismagulov <ibr@radix50.net>]

Hello Henning,

On Mon, Oct 28, 2019 at 06:01:15PM +0100, Henning Schild wrote:
> base-apt has two main issues that this series fixes:
>  - it relied on the rootfs /var/cache/apt to contain all *.debs
>   - this is only true of nobody cleaned up, could happen with hooks
>     like used in "isar-disable-apt-cache" or similar mechanisms
>  - it did not handle "dsc"s (source packages)
> 
> It had other minor issues that are described in the individual patches.
> 
> The series fixes those issues and extends CI to fully test base-apt.
> 
> The general mechanism used in the end is:
>  - split all apt-gets into a download and an execution phase
>  - copy out all download inbetween the two phases
>  - execution phase can now go ahead and possibly delete cached files
>    from the rootfs
>  - actually copy in everything "old" before the download phase
>  - that means the download phase potentially becomes a noop and we speed
>    up by using already downloaded files (new feature)

Thanks for the series and the clear annotation. While I haven't yet checked
every detail, overall, I think this is a good step. I think proper separation
of base-apt and isar-apt is important; I hope we manage to find a way to handle
that. I'll be sending other comments to the respective patches.

With kind regards,
Baurzhan.