From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6752900179667451904
X-Received: by 2002:a2e:94d6:: with SMTP id r22mr18797510ljh.7.1574609712350;
        Sun, 24 Nov 2019 07:35:12 -0800 (PST)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a19:790c:: with SMTP id u12ls1050362lfc.4.gmail; Sun, 24 Nov
 2019 07:35:11 -0800 (PST)
X-Google-Smtp-Source: APXvYqwxRzNynymUZPYbvoxQ6P2DRip+ygT/sjNu9BY5zMd/mK57nsAbuZ7mlq0pyej5dFjvpSo+
X-Received: by 2002:ac2:51a6:: with SMTP id f6mr7192354lfk.174.1574609711659;
        Sun, 24 Nov 2019 07:35:11 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1574609711; cv=none;
        d=google.com; s=arc-20160816;
        b=ceAHafKRISV0jG8DsouWzZ2J6nkax61IIvHB5rqElVjivrwwTtZ/9ELNYR0v713Mri
         Pz6PKdMCKeyfyhWQMWFwWhUJqxTxe9MAoerDRfDUfcfq/vr8L2cwb4J7OIWQxCVLSpqH
         uDhjkiuLoj9js2dLvMghThJ0dNKaTNKzm0/5MdgGfH+hOwf3c3EmkcKL4ekT0Qx83iFe
         Cdlbg3NoV2btug1nuphE3YaLHGivtnFdsAjwfaAlTaUtj/PA4jz/udQSVM0a4cmD5iQW
         v4T26Xah5NP0ZZ2cNCKFYm7ycrcN8eytneQmHN8NzY3zHwXD+RgAKB+oHBleRUAKvBDS
         FHFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:to:from:date;
        bh=n6Ms3/u5f8rVE4u07dQwR0SAi+Kh8+IcYQsLyk5aYyI=;
        b=U/zpq15foVcYJeTNZokoBLtfVNqFyxS9OyvJiFpAERa1e4hq91qS0AHUeOOaUmxOWM
         V/vvBeWPQMWuuZ3JPqgFd0DWu0IrV8liECozF6+4HHjucwB8HHCw09udZO50DEtzCACI
         a+ImaBRmSvmJUDdYxrtoEWH/i/Snzv8GSAaRFJmV2oziD+fBYAr3n9y6yH7Dfr+ror4F
         vmOaP18ms0Aq4rdrkqb09LY2yVfZAck/AuuXIuCORCEC8iKfauLbd1julCfDf0FgI8uL
         58LOESh2SA0ZkM2eOOXjoDtKCZ8gslnDBBGD21Xy+Q/l1xfgql45MxTQ8lAQvSt5b6Kg
         0dWw==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Return-Path: <ibr@radix50.net>
Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166])
        by gmr-mx.google.com with ESMTPS id f11si269634lfm.2.2019.11.24.07.35.11
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Sun, 24 Nov 2019 07:35:11 -0800 (PST)
Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166;
Authentication-Results: gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Received: from yssyq.m.ilbers.de (dslb-084-061-174-101.084.061.pools.vodafone-ip.de [84.61.174.101])
	(authenticated bits=0)
	by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id xAOFZ9UR000639
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
	for <isar-users@googlegroups.com>; Sun, 24 Nov 2019 16:35:10 +0100
Date: Sun, 24 Nov 2019 16:35:04 +0100
From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Subject: Re: [PATCH 05/17] base-apt: do not skip gpg check when it is signed
Message-ID: <20191124153503.uycztnr2r3rwtrlr@yssyq.m.ilbers.de>
Mail-Followup-To: isar-users@googlegroups.com
References: <20191028170132.28072-1-henning.schild@siemens.com>
 <20191028170132.28072-6-henning.schild@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191028170132.28072-6-henning.schild@siemens.com>
User-Agent: NeoMutt/20180716
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de
X-TUID: zamDSvv73bFr

On Mon, Oct 28, 2019 at 06:01:20PM +0100, Henning Schild wrote:
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
...
> -BASEAPTSRCS = "${WORKDIR}/base-apt-sources"
...
>              if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
> -                sed -e "s#{BASE_DISTRO}#"${BASE_DISTRO}"#g" \
> -                    -e "s#{BASE_DISTRO_CODENAME}#"${BASE_DISTRO_CODENAME}"#g" \
> -	            -i ${BASEAPTSRCS}
> +                line="file:///base-apt/${BASE_DISTRO} ${BASE_DISTRO_CODENAME} main"
> +                if [ -z "${BASE_REPO_KEY}" ]; then
> +                    line="[trusted=yes] ${line}"
> +                fi
> +                echo "deb ${line}" >  "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"
> +                echo "deb-src ${line}" >>  "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"

The same question w.r.t. hard-coding vs. operating on data depending on the
config. Suggest keeping base-apt-sources, renaming it to base-apt-sources.in on
this occasion.

With kind regards,
Baurzhan.