From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6752900179667451904
X-Received: by 2002:a17:906:da04:: with SMTP id fi4mr12884188ejb.24.1574611070111;
        Sun, 24 Nov 2019 07:57:50 -0800 (PST)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a05:6402:548:: with SMTP id i8ls627662edx.9.gmail; Sun, 24
 Nov 2019 07:57:49 -0800 (PST)
X-Google-Smtp-Source: APXvYqx65hNC1bdZQfZNWNB0pnC4TTaIeVC2UgdsPogjZK+1yWOiw14ryYbCCCvRRPI9G547MYTG
X-Received: by 2002:a50:a691:: with SMTP id e17mr13248673edc.151.1574611069692;
        Sun, 24 Nov 2019 07:57:49 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1574611069; cv=none;
        d=google.com; s=arc-20160816;
        b=m0xxTGqGpKFZsA+3LcugnnDyt86aL6kWoRJla28EtnJduzt9rrxqRzsZQ6q6oeJnZe
         67cqRe8S7pjr6WHvO/n9VxtkQ7glimGebVsv6aftJv2y+QAw8dcOz2KNb+xOZKC+nF/i
         Vk+OhCutCKWMeo4IxJdk4YBcd6E0BfSDe9HNT6ikzxghU6ZCcMS2AHpvKepkIrMTeG0B
         sose7FiX4lZQtRxzIAjJpsH4MYmC4tuTFLnbIxMbQU5/+aS0HPLS379tGWZ97jxqK92f
         B/xYRYDJG75Xm4imQzaCqOpVnBNnwXq7d+DEqXPayNyqHBYHc88/Wi5EXuk1lwBwbljb
         kxEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:to:from:date;
        bh=5v84Yqnj+1rYBAAhlzQpNo7Q0+w21ss5gOml9zTslF8=;
        b=LcYkoj5cp0KEe6sEwOGRGUqVg5Ecp9udXhg+gZMXgWc6ee4QxJcK9llfxM7NuSUH8M
         lEZvKuccequc4IMk+DooJZ+B/rRpuVbXJOUHh5AtWZgeI285vuNWaiietVYveWQkTUjt
         1GobbnTNkb1FhK6PWw3M6709cYnCwXKB+ubkmYlRB+3wE4a8G8qXeDWmc8uKJuM57LFb
         8CzNKQLLkVsG7K+WkuVw0QDDMFH1FWu7B6TeuEiqXUBrTx2chIzmibxlWL/ynlgAzMz3
         j5O4NEl2ESd55JwHIdkQgQpPqlhUpxS6TZKZihL6qICHL+OQe00ls/ZS4txAG6VAlpZO
         Swpg==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Return-Path: <ibr@radix50.net>
Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166])
        by gmr-mx.google.com with ESMTPS id c12si119805edy.1.2019.11.24.07.57.49
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Sun, 24 Nov 2019 07:57:49 -0800 (PST)
Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166;
Authentication-Results: gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Received: from yssyq.m.ilbers.de (dslb-084-061-174-101.084.061.pools.vodafone-ip.de [84.61.174.101])
	(authenticated bits=0)
	by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id xAOFvmFS000725
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
	for <isar-users@googlegroups.com>; Sun, 24 Nov 2019 16:57:49 +0100
Date: Sun, 24 Nov 2019 16:57:42 +0100
From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Subject: Re: [PATCH 08/17] meta: create DL_DIR support for all apt-get
 downloaded .debs
Message-ID: <20191124155742.o7mq2mkclb564avi@yssyq.m.ilbers.de>
Mail-Followup-To: isar-users@googlegroups.com
References: <20191028170132.28072-1-henning.schild@siemens.com>
 <20191028170132.28072-9-henning.schild@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191028170132.28072-9-henning.schild@siemens.com>
User-Agent: NeoMutt/20180716
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED
	autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de
X-TUID: ghIKfFgMhS5t

On Mon, Oct 28, 2019 at 06:01:23PM +0100, Henning Schild wrote:
> diff --git a/meta/classes/deb-dl-dir.bbclass b/meta/classes/deb-dl-dir.bbclass
...
> +    flock "${pc}".lock -c ' \
> +        sudo find "${rootfs}"/var/cache/apt/archives/ -type f -iname '*\.deb' \
> +            -exec cp -f '{}' "${pc}" \;
> +    '

If this stays in the code, some thoughts:

* The trailing escapes seem to be unnecessary with single quotes.

* Escaping dot in a glob should be unnecessary.

* The single quotes around "{}" seem to close and re-open the flock '...'
  argument. So, the "{}" seems to be not quoted and seems to work fine. find(1)
  does recommend quoting "{}", but I failed to identify a case where it would
  be interpreted by the shell. I'd suggest to drop quoting unless I overlook
  anything.

With kind regards,
Baurzhan.