From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6752900179667451904 X-Received: by 2002:aa7:dd9a:: with SMTP id g26mr17511841edv.85.1574676909248; Mon, 25 Nov 2019 02:15:09 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:80ca:: with SMTP id a10ls5596877ejx.0.gmail; Mon, 25 Nov 2019 02:15:08 -0800 (PST) X-Google-Smtp-Source: APXvYqzn37JWM6jMjPS7VyLiEvHWWKARA8lsOy8+SUUCpt8JquiSwvmY6G5p/17Dpd4x6MeYQG71 X-Received: by 2002:a17:906:7042:: with SMTP id r2mr35990261ejj.166.1574676908767; Mon, 25 Nov 2019 02:15:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574676908; cv=none; d=google.com; s=arc-20160816; b=ImUGrf1G8Ly/SUfaZbzsvPAsJX1mKH9QiWxtKGVeHazLACuNH/F7eiQ6opiFCitFye 20WDH0eQDiaVPpIzaiTB9KuKrcxrMaavU/ZDwx51dU/xEn4kF8QWHWkGjBXNwhENWdGs JkkKjupHBpdMPwrasb1smrufGJ/+X9f2y4rba9el5kedeiBGth71oPyH4Tv1WJUUBRiB PbBLmgT3yiZX3C0o9z97FHnlkJcZ/HCpopW4COOPE4U1+JzqZ85hVj03LzDW4JGF2PVW N01XsPtinh6Ww+LCq9P8JNdchAalMuGKN6WjI+MRIycsF/0MZm1Jo65Of754VpWZCV8m G4YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=XGltsT5At5vCEALsCQYSlDTSMbjBhvEUuxKl6MtbUJg=; b=mVAa+UJyqvBnKNGW/zpuPRw+aAVCDdILJ8B+nCAgc4hfURtmDlGVfEyRQYXH+piKOW HrAGfWUVJwxnU+0MzHiibGgGkBCKL3I2U+voD8Z0zNX+A9RbmxekHPaFvKlOHc/Qzceg KWapHFZj/WrLzJfWU5GKWgv0RNMv9NO5PgH8LRxRT7ctvpJFd3yHpxw9dMU1ABQvzKIG kuzyZJa3O5p3ui4IuY89MK63jTH/TxwCSC2Fq7YERNnbDyH5DEbm4umR/7D5hbZmh+Hf DiQ1RLn5HBwvA3E4veeutP26xMyOVElPZhbqSTwuLRnQLB0QM4hQhjgTJv1oJbXKWlZu qqmA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id x16si248166eds.5.2019.11.25.02.15.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2019 02:15:08 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id xAPAF870013519 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Nov 2019 11:15:08 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.65]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xAPAF8GU013819; Mon, 25 Nov 2019 11:15:08 +0100 Date: Mon, 25 Nov 2019 11:15:05 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCH 08/17] meta: create DL_DIR support for all apt-get downloaded .debs Message-ID: <20191125111505.64330d2e@md1za8fc.ad001.siemens.net> In-Reply-To: <20191124155742.o7mq2mkclb564avi@yssyq.m.ilbers.de> References: <20191028170132.28072-1-henning.schild@siemens.com> <20191028170132.28072-9-henning.schild@siemens.com> <20191124155742.o7mq2mkclb564avi@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 3Ro0VO8tEYNC On Sun, 24 Nov 2019 16:57:42 +0100 Baurzhan Ismagulov wrote: > On Mon, Oct 28, 2019 at 06:01:23PM +0100, Henning Schild wrote: > > diff --git a/meta/classes/deb-dl-dir.bbclass > > b/meta/classes/deb-dl-dir.bbclass > ... > > + flock "${pc}".lock -c ' \ > > + sudo find "${rootfs}"/var/cache/apt/archives/ -type f > > -iname '*\.deb' \ > > + -exec cp -f '{}' "${pc}" \; > > + ' > > If this stays in the code, some thoughts: It will not stay. This loop is where i plan to detect whether the debs came from isar-apt and exclude them from extraction. They are not downloaded and should not be cached as such. Henning > * The trailing escapes seem to be unnecessary with single quotes. > > * Escaping dot in a glob should be unnecessary. > > * The single quotes around "{}" seem to close and re-open the flock > '...' argument. So, the "{}" seems to be not quoted and seems to work > fine. find(1) does recommend quoting "{}", but I failed to identify a > case where it would be interpreted by the shell. I'd suggest to drop > quoting unless I overlook anything. > > With kind regards, > Baurzhan. >