From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 07/17] meta: split all apt-get invocations into download and execution
Date: Mon, 25 Nov 2019 11:20:33 +0100 [thread overview]
Message-ID: <20191125112033.5b03d5ae@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20191124154124.nmgqaake3s62opqd@yssyq.m.ilbers.de>
On Sun, 24 Nov 2019 16:41:24 +0100
Baurzhan Ismagulov <ibr@radix50.net> wrote:
> On Mon, Oct 28, 2019 at 06:01:22PM +0100, Henning Schild wrote:
> > diff --git a/meta/classes/image-tools-extension.bbclass
> > b/meta/classes/image-tools-extension.bbclass index 7ea7557..243fa11
> > 100644 --- a/meta/classes/image-tools-extension.bbclass
> > +++ b/meta/classes/image-tools-extension.bbclass
> > @@ -30,6 +30,11 @@ do_install_imager_deps() {
> > -o Dir::Etc::SourceList="sources.list.d/isar-apt.list"
> > \ -o Dir::Etc::SourceParts="-" \
> > -o APT::Get::List-Cleanup="0"
> > + apt-get -o Debug::pkgProblemResolver=yes
> > --no-install-recommends -y \
> > + --allow-unauthenticated --allow-downgrades
> > --download-only install \
> > + ${IMAGER_INSTALL}'
> > +
> > + sudo -E chroot ${BUILDCHROOT_DIR} sh -c ' \
>
> Is the first apt-get (and the preceding statement) indented one level
> deeper than necessary? Suggest fixing the original while at it.
Yes, they are both under the same "sudo".
>
> > diff --git a/meta/recipes-devtools/buildchroot/files/deps.sh
> > b/meta/recipes-devtools/buildchroot/files/deps.sh
> ...
> > +if [ "$3" == "--download-only" ]; then
>
> "==" isn't POSIX and fails e.g. in dash. Suggest "=".
Right, thanks.
Henning
>
> With kind regards,
> Baurzhan.
>
next prev parent reply other threads:[~2019-11-25 10:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 17:01 [PATCH 00/17] base-apt rework Henning Schild
2019-10-28 17:01 ` [PATCH 01/17] repository: new class to deal with repos Henning Schild
2019-11-24 15:29 ` Baurzhan Ismagulov
2019-11-25 12:03 ` Henning Schild
2019-10-28 17:01 ` [PATCH 02/17] dpkg-base: add download caching of apt:// downloads Henning Schild
2019-10-29 12:57 ` chombourger
2019-10-29 16:03 ` Henning Schild
2019-11-08 11:39 ` Henning Schild
2019-11-24 15:30 ` Baurzhan Ismagulov
2019-11-25 10:32 ` Henning Schild
2019-10-28 17:01 ` [PATCH 03/17] base-apt: change the sources.list to also offer deb-src Henning Schild
2019-10-28 17:01 ` [PATCH 04/17] base-apt: add deb-src packages as well Henning Schild
2019-10-30 19:23 ` Henning Schild
2019-10-28 17:01 ` [PATCH 05/17] base-apt: do not skip gpg check when it is signed Henning Schild
2019-11-24 15:35 ` Baurzhan Ismagulov
2019-11-25 10:30 ` Henning Schild
2019-10-28 17:01 ` [PATCH 06/17] ci: conf: add "hello" to the sample config and every build Henning Schild
2019-10-28 17:01 ` [PATCH 07/17] meta: split all apt-get invocations into download and execution Henning Schild
2019-11-24 15:41 ` Baurzhan Ismagulov
2019-11-25 10:20 ` Henning Schild [this message]
2019-10-28 17:01 ` [PATCH 08/17] meta: create DL_DIR support for all apt-get downloaded .debs Henning Schild
2019-10-29 12:48 ` chombourger
2019-10-29 16:02 ` Henning Schild
2019-11-06 13:19 ` Henning Schild
2019-11-24 15:57 ` Baurzhan Ismagulov
2019-11-25 10:15 ` Henning Schild
2019-10-28 17:01 ` [PATCH 09/17] meta: import DL_DIR debs before apt-get download steps Henning Schild
2019-10-30 19:21 ` Henning Schild
2019-11-06 13:17 ` Henning Schild
2019-11-24 20:20 ` Baurzhan Ismagulov
2019-11-25 10:13 ` Henning Schild
2019-10-28 17:01 ` [PATCH 10/17] base-apt: populate from DEBDIR as well Henning Schild
2019-10-28 17:01 ` [PATCH 11/17] base-apt: drop the "apt_cache" feature Henning Schild
2019-10-28 17:01 ` [PATCH 12/17] base-apt: do not copy debs directly out of rootfss anymore Henning Schild
2019-10-28 17:01 ` [PATCH 13/17] base-apt: rework base-apt population Henning Schild
2019-10-28 17:01 ` [PATCH 14/17] base-apt: move class "base-apt-helper" into only user Henning Schild
2019-10-28 17:01 ` [PATCH 15/17] CI: include "isar-disable-apt-cache" into all CI images Henning Schild
2019-10-28 17:01 ` [PATCH 16/17] CI: include "cowsay" into default build to test dpkg-gbp Henning Schild
2019-10-28 17:01 ` [PATCH 17/17] CI: set BB_NO_NETWORK for cached rebuild Henning Schild
2019-11-06 16:00 ` [PATCH 00/17] base-apt rework Jan Kiszka
2019-11-24 13:21 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125112033.5b03d5ae@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox