From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6752900179667451904 X-Received: by 2002:ac2:4882:: with SMTP id x2mr1160208lfc.103.1574677237461; Mon, 25 Nov 2019 02:20:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4c01:: with SMTP id t1ls604700lfq.3.gmail; Mon, 25 Nov 2019 02:20:36 -0800 (PST) X-Google-Smtp-Source: APXvYqxXsKAwe5m4AfwBroxhBHwAYy4lhRrbQgTFVfigq9SnerY6B9SslzjjgbhYy+bhb8Tg41PR X-Received: by 2002:a19:ac08:: with SMTP id g8mr21333600lfc.112.1574677236850; Mon, 25 Nov 2019 02:20:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574677236; cv=none; d=google.com; s=arc-20160816; b=GjhPV2v3mPC58aAQpOKo+UwQWQRAJ9oyiYQPbEvYd6l48qXd3XQt355m535KllVWhF 32OyBloLXHUZ6VeQmCEwl7L7VFfbIuJgx0FoBtKwSL9kzUhhfACnPEo7HVEzuO5y1KxM iixD44G37Ivk39bbtCBukPIAJGJGOZvP9vOiGcz+1ZZaLANFp2ufIg+DsFiEUwe/ELab fe4YMn8SwGWamV4BhVXH5Cvqppnz4WKZs0+aH9wTTDXReTfCFaCTxPkPB4Vi4Lf04kOQ 5xddDSe9oz3MNzRfyAwye88zhr/z23L+AdBZSY1GvqnkQQiFs96HG8vOn6WfIOOVolEr /hXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=wwQmujOnRLuLChipsf+D18wDRIqipnQE+YBrasEGKpc=; b=KT6tm+qPz18X3E18Cpno6+HLgWqNRrFW59VVk9sTvEBqaU4O23i3fAv6JAoCOZHh+m iP2EgkoJROd4TK2jNYGZgQhEnU1Z/xZIm/PwvuzmcW8jNpdjuw8iFbRoKinvI7cviVLo ziDw/qvXLESpPDDBbrlChpK6z3vNxE5IHWKcCbT0F14YNeFVqDKO/bqrbLHTDbQi0ava O3yLDRNnMkCcS2CIL6gcQ3GGSIyOjIimQ/WCkdTAb+tH0W1qDjAISUymF1HDLSW9t2FW SfQpWvoh1txsUsjfR3lkrz4lLyRDQ6LRKEcq3GAEF/untADvKsvN8gqP6mZu4WVBJsER goCg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id t3si207358ljj.1.2019.11.25.02.20.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2019 02:20:36 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id xAPAKZDV024053 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Nov 2019 11:20:36 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.65]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xAPAKZnK012821; Mon, 25 Nov 2019 11:20:35 +0100 Date: Mon, 25 Nov 2019 11:20:33 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCH 07/17] meta: split all apt-get invocations into download and execution Message-ID: <20191125112033.5b03d5ae@md1za8fc.ad001.siemens.net> In-Reply-To: <20191124154124.nmgqaake3s62opqd@yssyq.m.ilbers.de> References: <20191028170132.28072-1-henning.schild@siemens.com> <20191028170132.28072-8-henning.schild@siemens.com> <20191124154124.nmgqaake3s62opqd@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: LF0nddLFq3jq On Sun, 24 Nov 2019 16:41:24 +0100 Baurzhan Ismagulov wrote: > On Mon, Oct 28, 2019 at 06:01:22PM +0100, Henning Schild wrote: > > diff --git a/meta/classes/image-tools-extension.bbclass > > b/meta/classes/image-tools-extension.bbclass index 7ea7557..243fa11 > > 100644 --- a/meta/classes/image-tools-extension.bbclass > > +++ b/meta/classes/image-tools-extension.bbclass > > @@ -30,6 +30,11 @@ do_install_imager_deps() { > > -o Dir::Etc::SourceList="sources.list.d/isar-apt.list" > > \ -o Dir::Etc::SourceParts="-" \ > > -o APT::Get::List-Cleanup="0" > > + apt-get -o Debug::pkgProblemResolver=yes > > --no-install-recommends -y \ > > + --allow-unauthenticated --allow-downgrades > > --download-only install \ > > + ${IMAGER_INSTALL}' > > + > > + sudo -E chroot ${BUILDCHROOT_DIR} sh -c ' \ > > Is the first apt-get (and the preceding statement) indented one level > deeper than necessary? Suggest fixing the original while at it. Yes, they are both under the same "sudo". > > > diff --git a/meta/recipes-devtools/buildchroot/files/deps.sh > > b/meta/recipes-devtools/buildchroot/files/deps.sh > ... > > +if [ "$3" == "--download-only" ]; then > > "==" isn't POSIX and fails e.g. in dash. Suggest "=". Right, thanks. Henning > > With kind regards, > Baurzhan. >