Re: [PATCH 05/17] base-apt: do not skip gpg check when it is signed

[Henning Schild <henning.schild@siemens.com>]

On Sun, 24 Nov 2019 16:35:04 +0100
Baurzhan Ismagulov <ibr@radix50.net> wrote:

> On Mon, Oct 28, 2019 at 06:01:20PM +0100, Henning Schild wrote:
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc  
> ...
> > -BASEAPTSRCS = "${WORKDIR}/base-apt-sources"  
> ...
> >              if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
> > -                sed -e "s#{BASE_DISTRO}#"${BASE_DISTRO}"#g" \
> > -                    -e
> > "s#{BASE_DISTRO_CODENAME}#"${BASE_DISTRO_CODENAME}"#g" \
> > -	            -i ${BASEAPTSRCS}
> > +                line="file:///base-apt/${BASE_DISTRO}
> > ${BASE_DISTRO_CODENAME} main"
> > +                if [ -z "${BASE_REPO_KEY}" ]; then
> > +                    line="[trusted=yes] ${line}"
> > +                fi
> > +                echo "deb ${line}" >
> > "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"
> > +                echo "deb-src ${line}" >>
> > "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"  
> 
> The same question w.r.t. hard-coding vs. operating on data depending
> on the config. Suggest keeping base-apt-sources, renaming it to
> base-apt-sources.in on this occasion.

I guess you are talking about the template file vs. the echos? I am not
sure the file can actually be overridden, because BASEAPTSRCS is
assigned with "=". But a lot of things are possible within bitbake ...

As far as i understand it, the template file was never supposed to be
an interface for users to change things, but just an implementation of
"hard-coding". But in an imho not very readable way. Since there is
just one user i decided to pull it inside that one.

If it is an interface to tweak, renaming the template to .in would also
break expectations.

Henning

> With kind regards,
> Baurzhan.
>