From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6752900179667451904 X-Received: by 2002:a1c:9e58:: with SMTP id h85mr29147410wme.77.1574677838581; Mon, 25 Nov 2019 02:30:38 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4c17:: with SMTP id z23ls96844wmf.5.gmail; Mon, 25 Nov 2019 02:30:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxvVeZHp7jSBtGLf67e7xe/Z6kRF44Ca+J3htprrkgwuBJ7IaWFEmENkQfTDPbLQ6Awv70B X-Received: by 2002:a1c:c906:: with SMTP id f6mr16419538wmb.14.1574677838095; Mon, 25 Nov 2019 02:30:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574677838; cv=none; d=google.com; s=arc-20160816; b=Yy3Su78Kr/Ofd5oJ4VVlYvN8Gqbuw7S9f1bXpjyoX0sCKMvCjATx+YbWKlia9M/Gle KM0LD+srgK+dAnai+MYkP8QS50d0US1p7Ln+KMPP+FlJB7L8FPKfnFm1x+cWVV2efA0p UhIwHET/Z6piJ5N5/owSrWk7DuC43kUXceOw2Wtd2lvICNnpMYwxsw/L37lPKbkcG6nF SrXqYV9Ehxwa0N/RRZiWCs7wZKG0EJ2iL87CK6BMAPoT4Xt12qtsSfwy5uxfXvgSqQil wU55sdtUoY43X14CuFHjb8tPI/auwdPkW8aHf4Em2N70kyRyjyqys1opRZtT5jmuwGbM ax7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Qo5J4U+Q68ZsJNKXsVEkx5dGaivBbdX8YxhpDqCCLf4=; b=cOi8rLrmad6Hfbzi2dzlEVmAdJACbevwwECR2fkLPHbIeB0EPMFVjO0Ib8LNgPyk5/ +tfpRaVmIFqEHHxl3v6CwFTctPXZKq8oyWXLaoXEHpvSRSSep0MR8x+gpgp9PQM9IcKR JjLWGJnbUgg5eh7szQlZSHCTyz5sFLMfFglAaYpgA8oIrzp5ezxrWTbDDtM9ig2JKZu7 ozQdZlZy/Wvu8CsLk6gBHiV5sVWHT9K21HKpDXPfydx9B2qy7fow22R1E6hW9LKwUiMS Ze0X/MgMz3YyfiM2Z86JifHhUE4jcizoLncIDcbmznThVvgBZUucPNxh8Ws+LaiEHCRN kB0Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id u23si229588wml.2.2019.11.25.02.30.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2019 02:30:38 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id xAPAUbMl028347 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Nov 2019 11:30:37 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.65]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xAPAUbp3031506; Mon, 25 Nov 2019 11:30:37 +0100 Date: Mon, 25 Nov 2019 11:30:35 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCH 05/17] base-apt: do not skip gpg check when it is signed Message-ID: <20191125113035.5e3fedbf@md1za8fc.ad001.siemens.net> In-Reply-To: <20191124153503.uycztnr2r3rwtrlr@yssyq.m.ilbers.de> References: <20191028170132.28072-1-henning.schild@siemens.com> <20191028170132.28072-6-henning.schild@siemens.com> <20191124153503.uycztnr2r3rwtrlr@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: uUcqmVx+GMme On Sun, 24 Nov 2019 16:35:04 +0100 Baurzhan Ismagulov wrote: > On Mon, Oct 28, 2019 at 06:01:20PM +0100, Henning Schild wrote: > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > ... > > -BASEAPTSRCS = "${WORKDIR}/base-apt-sources" > ... > > if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then > > - sed -e "s#{BASE_DISTRO}#"${BASE_DISTRO}"#g" \ > > - -e > > "s#{BASE_DISTRO_CODENAME}#"${BASE_DISTRO_CODENAME}"#g" \ > > - -i ${BASEAPTSRCS} > > + line="file:///base-apt/${BASE_DISTRO} > > ${BASE_DISTRO_CODENAME} main" > > + if [ -z "${BASE_REPO_KEY}" ]; then > > + line="[trusted=yes] ${line}" > > + fi > > + echo "deb ${line}" > > > "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list" > > + echo "deb-src ${line}" >> > > "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list" > > The same question w.r.t. hard-coding vs. operating on data depending > on the config. Suggest keeping base-apt-sources, renaming it to > base-apt-sources.in on this occasion. I guess you are talking about the template file vs. the echos? I am not sure the file can actually be overridden, because BASEAPTSRCS is assigned with "=". But a lot of things are possible within bitbake ... As far as i understand it, the template file was never supposed to be an interface for users to change things, but just an implementation of "hard-coding". But in an imho not very readable way. Since there is just one user i decided to pull it inside that one. If it is an interface to tweak, renaming the template to .in would also break expectations. Henning > With kind regards, > Baurzhan. >