From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6752900179667451904 X-Received: by 2002:adf:e40e:: with SMTP id g14mr9292529wrm.264.1574683434047; Mon, 25 Nov 2019 04:03:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6303:: with SMTP id i3ls2114757wru.13.gmail; Mon, 25 Nov 2019 04:03:53 -0800 (PST) X-Google-Smtp-Source: APXvYqyT/3gQi3K94Ql/4EFZT7SRBkyaK7HHDJ8MnGvwUBABh644ATpQ8ALQe0uAnkttk9VbNacn X-Received: by 2002:adf:dc86:: with SMTP id r6mr13874179wrj.68.1574683433442; Mon, 25 Nov 2019 04:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574683433; cv=none; d=google.com; s=arc-20160816; b=zmfqNRp9337xRGk1uzkGbLvM0A+dNhudPPKQRyG/E0LEeBfS2NqYNPncZdhaAUPZik 71J/kkke2uDYvLYBLJu+NHmkyPNDkKGT5BRX4NVcMiL6tiRgAiQt9hvfIx+kGZE3v3Pv vt0wtLs0AWaWsNFcUTU3waJY9+VyXwjqCaXhT2QeSGA3Uj8QxXsgC8adRLBrqdplyU2P V/PxIsb5iUdqN6Ypvist+Gq9J2p4IsHotl2Q0SWuiitgxkD7R/cUQ61JqJaNb0q0ATXB IZDW0zjNV+HIVPCmpwfUDfmM6YO32A05MyTs3d+ujqVYnoVB3XgOkDGfFdczzgzUqsUD oBiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=WkjZxejRqsf5vCKWWHarunF7ZBVyYy/CKQsFpFg3gcc=; b=bFjmqjw5xhbJyW8nSonU6ASIFnTy+6z+X6n2Ls+yuou8lyGczU/1xvE+dX97I+Nb78 DK4WT0DT7Kj5J9N4JGFtFYLnDB57Ju62+6dZOyTXnBLfOBxxCOIyv0i9bfI5H2SCyE4B Jkz4M/3VslYir5w+1tUXYSNIOa5EivejBo4hsRwMBO8e6nltgA77Pb0alqJ+PoYetQ1h 8diGKXIeDjiIzKgt8UU/a9sQXAiHk9GytNA86t47gUVnMCPT6kyMZW3P7sT+XsxDHjvr Rj7QoPi8m/A8+pnlO+1aVRfRO8A/bKVMpMTDwYky692cdvIfuUvH6Pc7gepFKQmc7+4V upvg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l23si323487wmg.0.2019.11.25.04.03.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2019 04:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id xAPC3qaM018212 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Nov 2019 13:03:53 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.65]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xAPC3qwC004406; Mon, 25 Nov 2019 13:03:53 +0100 Date: Mon, 25 Nov 2019 13:03:50 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCH 01/17] repository: new class to deal with repos Message-ID: <20191125130350.1daa3c41@md1za8fc.ad001.siemens.net> In-Reply-To: <20191124152918.md4sxwz7iqeu6ewu@yssyq.m.ilbers.de> References: <20191028170132.28072-1-henning.schild@siemens.com> <20191028170132.28072-2-henning.schild@siemens.com> <20191124152918.md4sxwz7iqeu6ewu@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: YgtSatGqevgE On Sun, 24 Nov 2019 16:29:18 +0100 Baurzhan Ismagulov wrote: > On Mon, Oct 28, 2019 at 06:01:16PM +0100, Henning Schild wrote: > > diff --git a/meta/classes/repository.bbclass > > b/meta/classes/repository.bbclass > ... > > +repo_create() { > ... > > + if [ ! -f "${dir}"/conf/distributions ]; then > > + mkdir -p "${dir}"/conf/ > > + cat < "${dir}"/conf/distributions > > +Codename: ${codename} > > +Architectures: i386 armhf arm64 amd64 mipsel source > > +Components: main > > +EOF > > I suggest to keep modifying distributions.in and avoid hard-coding > architectures and components that are specific to the current Debian. Same comment as before. As far as i know this is not a visible interface and was never meant to be changed by i.e. a layer. Distributing the code over multiple files, with just one place that uses it, is a layer of abstraction that just makes the code less readable. That is why i pulled that file in. Will keep it like that for the next series. Let us discuss further on how to proceed. Henning > With kind regards, > Baurzhan. >