From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6756899790246641664 X-Received: by 2002:ac2:59dd:: with SMTP id x29mr4585661lfn.95.1575538616100; Thu, 05 Dec 2019 01:36:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8ed1:: with SMTP id e17ls361214ljl.2.gmail; Thu, 05 Dec 2019 01:36:55 -0800 (PST) X-Google-Smtp-Source: APXvYqymyf1zHORf0GtOQxy/esKQGPwQ40XjRN4ORlqeKPxmoZdPQ78lduoAMRFDEG2M7Ff/lhe3 X-Received: by 2002:a2e:556:: with SMTP id 83mr5018089ljf.127.1575538615387; Thu, 05 Dec 2019 01:36:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575538615; cv=none; d=google.com; s=arc-20160816; b=Kp7TlQZra5WJ65WTHmuf2GHTe5HHBlhqlfSTcEU1FAPajgOaly+CpEGQ73uq9oNhBU g/c0PwaNGqp3UOtdtPs7sqHpXMD00Q4ZPILe4l7L1wEh5eb8FndoKvq9/JS341JWcFyo c/F60GZcEsUXEJmG9mlNZsJ39arAUHJjj5iRIVr/ZNURIVb7Tvl/rT6TmR+02BWOyhcY EZMm4uqS5HKOfKNaNnbOms9cgoZTOfh2ND5IUauJHYXnXrc+6WtVKAHO2O3J/zbpfzcH 04MZdFPnIYUrCTpzVNy0lfn1wq52ODXH+K/N3MxOy5Siq3qkfiDftMJ79Qh3/3LAhLin 3dWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=SMkQqIyun94m6b1coWKwGNRaeLtm/GlIoAK6FiyRdgw=; b=qAKFNJ2kti5qId1l2GhX8zt5C+IX4sPPHpyzTeqeO8OolV1XZyVSzoGHv2+a7uNH0d T0ST9IaNmrelwYuEKvptMp3aI/mBnBtdg3k+DeB//Rm+y4eSL7LvCbRYLMZmaqdWDioE Sr3h1keA1Kqtbp8DtkO2X2j5ORGQKCTbnBwn/AhDAeAbNb7pIjJsALyeex6DJcoB8skC fEiZhteVvcBws83plIyLdKd1+icllLd9M6WPpA/HpRRlzb5vUgvTnimFmbk3Rkp00Uzq bl95s1nf34n2zMyR/HXcl7nLQY0wcOTx++OwQo6ELY66jrQvgSA2lfGaIW9x32gcIRcs c0Mg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id o193si411182lff.4.2019.12.05.01.36.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Dec 2019 01:36:55 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xB59asoY023837 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Dec 2019 10:36:54 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.199]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xB59asGm013498; Thu, 5 Dec 2019 10:36:54 +0100 Date: Thu, 5 Dec 2019 10:36:53 +0100 From: Henning Schild To: vijai kumar Cc: isar-users Subject: Re: [PATCH v2] meta/classes: Make sure the files exists before copying Message-ID: <20191205103653.0d845df5@md1za8fc.ad001.siemens.net> In-Reply-To: <2f0e4ece-4ab7-4d5e-8db8-65d2fdb0ddc4@googlegroups.com> References: <20191108174148.GA9643@oxygen> <20191108174735.9998-1-Vijaikumar_Kangarajan@mentor.com> <2f0e4ece-4ab7-4d5e-8db8-65d2fdb0ddc4@googlegroups.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 8Mzu+66rvv6h i would say so Henning On Mon, 2 Dec 2019 21:33:11 -0800 vijai kumar wrote: > Can this be merged to next?? > > Thanks, > Vijai Kumar K > > On Friday, November 8, 2019 at 11:17:45 PM UTC+5:30, vijai kumar > wrote: > > > > From: Vijai Kumar K > > > > By default realpath doesnot check if the file exists and hence > > might return an invalid path. > > > > Check if file exists before copying. > > > > Signed-off-by: Vijai Kumar K > > --- > > Changes in v2: > > - Use -f in if condition instead of realpath -e to make code > > more readable. > > > > meta/classes/image.bbclass | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta/classes/image.bbclass > > b/meta/classes/image.bbclass index 8384b71..c845eab 100644 > > --- a/meta/classes/image.bbclass > > +++ b/meta/classes/image.bbclass > > @@ -129,12 +129,12 @@ EOF > > do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" > > do_copy_boot_files() { > > kernel="$(realpath -q '${IMAGE_ROOTFS}/${KERNEL_FILE}')" > > - if [ -n "$kernel" ]; then > > + if [ -f "$kernel" ]; then > > cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}' > > fi > > > > initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')" > > - if [ -n "$initrd" ]; then > > + if [ -f "$initrd" ]; then > > cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}' > > fi > > > > -- > > 2.17.1 > > > > >