From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6771003123014041600 X-Received: by 2002:a05:600c:291d:: with SMTP id i29mr7328744wmd.39.1580246564285; Tue, 28 Jan 2020 13:22:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:247:: with SMTP id 7ls2787552wmj.3.canary-gmail; Tue, 28 Jan 2020 13:22:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzFht0sQ4KcjyaQEPS+APIoookybwZG3VB6PuMPqZnC0YVkrQComVrEBqcma6PYGyTtxKVL X-Received: by 2002:a1c:9a56:: with SMTP id c83mr7179547wme.79.1580246563433; Tue, 28 Jan 2020 13:22:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580246563; cv=none; d=google.com; s=arc-20160816; b=Xkdcp4t/ugHbXuJei7G1Vp3EaBIzcoL/tQLiATV9grcgYDZCgFmXKuhOjRh8bm2e2Z 1mP9IPgItQAVLjaPP6YL7GFZMFyu0/KYweHNo6cNfKhonSDKEY9adIXbg7gvJhcX97RF QwReAGp6SKwyPbt9+C0/Q2gKJXjicfgGh94Y5tHts5aenuKAFIipHACNvkKdx66wJHwZ VUU2VrYyK0RUk8nO3Du0VRCbR9UA9VHqYWAw3scClx6CBiTaPX36ny7JQmaY9OU4Ppv2 vnNzqAWSNbhLUt1/0fihNy6NzE7FbiSeH6EkzUu7DFBLpUgzE5pIGIvZkyg17iweYsxG O7Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=oi5mRM9PpCUEK/g1ea4XadSwp9QC167c1WQQ/Ew43Vg=; b=FCKiTbAVvmtEr5JxPQE2gQkVGnvvkEUh6BVp0zKRRYk4rSPNaBhC4oNseAVO3OJery fhOqneYwdqr74BD+L1KRlok+4OLtrlszbXBR8ML13gY5aAHg7PS16gGsJSCc2376zUe1 v2aJeXWIRAo2vniB3SmaOQoS0mCQVT1cs8ThUdQwlz0uf3lb4w9PW1JHphME1NhJ9QbW z6s+WCvKR/c/8AQKwgsaKKGmphlxJWlans7MwT9QTdrFtI95yWYF7rYxtU4E806ofjvX Y0VJF1IqDT0t2ZYqLFmdPfkK6GPzuWwSEw5fWf/mldaq98Ki8Dd7rPd9OUd3fvo41zCq kAyw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id b9si69wrw.2.2020.01.28.13.22.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2020 13:22:43 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 00SLMgSF001037 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jan 2020 22:22:42 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.4.201]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 00SLMfGK010689; Tue, 28 Jan 2020 22:22:42 +0100 Date: Tue, 28 Jan 2020 22:22:40 +0100 From: Henning Schild To: vijai kumar Cc: isar-users Subject: Re: [PATCH v3 26/26] meta/recipes-kernel: Export KBUILD_DEPENDS to cache Message-ID: <20200128222240.3a72eb54@md1za8fc.ad001.siemens.net> In-Reply-To: <4f458566-c16e-4af0-9b08-174188b21ef8@googlegroups.com> References: <20200128154312.337e61f6@md1za8fc.ad001.siemens.net> <20200128154213.22353-1-vijaikumar.kanagarajan@gmail.com> <20200128154213.22353-27-vijaikumar.kanagarajan@gmail.com> <20200128175235.5645b10d@md1za8fc.ad001.siemens.net> <4f458566-c16e-4af0-9b08-174188b21ef8@googlegroups.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: AieN8GNpl3cD On Tue, 28 Jan 2020 11:45:18 -0800 vijai kumar wrote: > On Tuesday, January 28, 2020 at 10:22:37 PM UTC+5:30, Henning Schild > wrote: > > > > Thanks. > > > > On Tue, 28 Jan 2020 21:12:13 +0530 > > Vijai Kumar K > wrote: > > > > > From: Vijai Kumar K > > > > > > > linux-custom overrides do_dpkg_builddeps with its own variant. > > > Since deb-dl-dir* is not called KBUILD_DEPENDS is not cached. > > > > > > Call deb-dl-dir-import/deb-dl-dir-export to cache it. > > > > > > Signed-off-by: Vijai Kumar K > > > --- > > > meta/recipes-kernel/linux/linux-custom.inc | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > > > b/meta/recipes-kernel/linux/linux-custom.inc index > > > 17f8464..37eb3c2 100644 --- > > > a/meta/recipes-kernel/linux/linux-custom.inc +++ > > > b/meta/recipes-kernel/linux/linux-custom.inc @@ -41,6 +41,7 @@ > > > KERNEL_LIBC_DEV_DEPLOY ?= "0" do_install_builddeps() { > > > dpkg_do_mounts > > > E="${@ isar_export_proxies(d)}" > > > + deb_dl_dir_import "${BUILDCHROOT_DIR}" > > > sudo -E chroot ${BUILDCHROOT_DIR} \ > > > apt-get update \ > > > -o > > > Dir::Etc::SourceList="sources.list.d/isar-apt.list" \ @@ -50,6 > > > +51,7 @@ do_install_builddeps() { apt-get install \ > > > -y -o Debug::pkgProblemResolver=yes \ > > > --no-install-recommends > > > ${KBUILD_DEPENDS} > > > > In between here you will have to do the split from p8. Otherwise if > > you have post-install hooks to clear the caches the next statement > > will copy nothing. > > > > > Ah, I see. Will change that. It is not likely to have such a hook for the buildchroot but we can not rule it out for the image. Let us just follow the pattern for the buildchroot as well. > > > I guess it is ok to send just one patch and note that it is > > supposed to sit on top of my v2. > > > Sure. I could fold your improvements into the queue as regular review feedback. Or we make it a patch on top to give you credit for finding the problem with the custom kernel. One thing that needs to be done as well, is including a custom-kernel build into the ci tests. The rebuild tests not covering a custom-kernel is the reason you ran into the issue. If you decide to send an update of your patch on top of my patches, please make that ci change as well. Otherwise let me know if you are ok with me taking the review comment and doing all the required changes in a v4. In case the maintainer is actually reading all this ... did you have any other issues with this queue? I know you are including it into a rather complex layer. If that was the only finding a v4 might just be ready for a merge. regards, Henning > Thanks, > Vijai Kumar K > > > > > > > > Henning > > > > > + deb_dl_dir_export "${BUILDCHROOT_DIR}" > > > dpkg_undo_mounts > > > } > > > > > > > >