Re: [PATCH v3 26/26] meta/recipes-kernel: Export KBUILD_DEPENDS to cache

[Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>]

On Tue, Jan 28, 2020 at 10:22:40PM +0100, Henning Schild wrote:
> On Tue, 28 Jan 2020 11:45:18 -0800
> vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote:
> 
> > On Tuesday, January 28, 2020 at 10:22:37 PM UTC+5:30, Henning Schild
> > wrote:
> > >
> > > Thanks. 
> > >
> > > On Tue, 28 Jan 2020 21:12:13 +0530 
> > > Vijai Kumar K <vijaikumar...@gmail.com <javascript:>> wrote: 
> > >  
> > > > From: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> 
> > > > 
> > > > linux-custom overrides do_dpkg_builddeps with its own variant. 
> > > > Since deb-dl-dir* is not called KBUILD_DEPENDS is not cached. 
> > > > 
> > > > Call deb-dl-dir-import/deb-dl-dir-export to cache it. 
> > > > 
> > > > Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com
> > > > <javascript:>> --- 
> > > >  meta/recipes-kernel/linux/linux-custom.inc | 2 ++ 
> > > >  1 file changed, 2 insertions(+) 
> > > > 
> > > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc 
> > > > b/meta/recipes-kernel/linux/linux-custom.inc index
> > > > 17f8464..37eb3c2 100644 ---
> > > > a/meta/recipes-kernel/linux/linux-custom.inc +++
> > > > b/meta/recipes-kernel/linux/linux-custom.inc @@ -41,6 +41,7 @@
> > > > KERNEL_LIBC_DEV_DEPLOY ?= "0" do_install_builddeps() { 
> > > >          dpkg_do_mounts 
> > > >          E="${@ isar_export_proxies(d)}" 
> > > > +        deb_dl_dir_import "${BUILDCHROOT_DIR}" 
> > > >          sudo -E chroot ${BUILDCHROOT_DIR} \ 
> > > >                  apt-get update \ 
> > > >                          -o 
> > > > Dir::Etc::SourceList="sources.list.d/isar-apt.list" \ @@ -50,6
> > > > +51,7 @@ do_install_builddeps() { apt-get install \ 
> > > >                          -y -o Debug::pkgProblemResolver=yes \ 
> > > >                          --no-install-recommends
> > > > ${KBUILD_DEPENDS}   
> > >
> > > In between here you will have to do the split from p8. Otherwise if
> > > you have post-install hooks to clear the caches the next statement
> > > will copy nothing. 
> > >
> > >  
> > Ah, I see. Will change that.
> 
> It is not likely to have such a hook for the buildchroot but we can not
> rule it out for the image. Let us just follow the pattern for the
> buildchroot as well.
> 
> > 
> > > I guess it is ok to send just one patch and note that it is
> > > supposed to sit on top of my v2.  
> > 
> > 
> > Sure.
> 
> I could fold your improvements into the queue as regular review
> feedback. Or we make it a patch on top to give you credit for finding
> the problem with the custom kernel.
> 
> One thing that needs to be done as well, is including a custom-kernel
> build into the ci tests. The rebuild tests not covering a custom-kernel
> is the reason you ran into the issue. If you decide to send an update
> of your patch on top of my patches, please make that ci change as well.
> Otherwise let me know if you are ok with me taking the review comment
> and doing all the required changes in a v4.

No problem. Please go ahead.

Thanks,
Vijai Kumar K

> 
> In case the maintainer is actually reading all this ... did you have
> any other issues with this queue? I know you are including it into a
> rather complex layer. If that was the only finding a v4 might just be
> ready for a merge.
> 
> regards,
> Henning
> 
> > Thanks,
> > Vijai Kumar K
> >  
> > 
> > >
> > >
> > > Henning 
> > >  
> > > > +        deb_dl_dir_export "${BUILDCHROOT_DIR}" 
> > > >          dpkg_undo_mounts 
> > > >  } 
> > > >     
> > >
> > >  
> > 
>