From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6771003123014041600 X-Received: by 2002:a19:7711:: with SMTP id s17mr4541433lfc.164.1580275765421; Tue, 28 Jan 2020 21:29:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ec09:: with SMTP id b9ls2266017lfa.6.gmail; Tue, 28 Jan 2020 21:29:24 -0800 (PST) X-Google-Smtp-Source: APXvYqz4xtwrz+KEh3sCtQz/W47GchJNRrrz395L+ax4yxCgx/FMwZDQpklrJoQZS7NoaDwFz3AJ X-Received: by 2002:ac2:523c:: with SMTP id i28mr4480832lfl.104.1580275764315; Tue, 28 Jan 2020 21:29:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580275764; cv=none; d=google.com; s=arc-20160816; b=0hdh8X3y4uMvFrkuueVNFoj1AQuKMuiawJJzdzLOSpVAMAlmzIxIQTgg8wzg1F1pWT MDcFWEvE0vMZOndCsh5Fe9Bgc6xPbyQK+bbtffqg6oBfMgn6i5r61VeVigQWpJr0M+2R SEhsDFHzbtkmqzs5227YTKcrNzDUn2RPvGhq41qIZ8ih09kSwanYY8dCa3SIOJoqjYMA HpWh+wwdMwNVdhfaHZakFRnjoC/DbpvSjv/+gK0os+GTbfh+D6vvLmaVx8wnZ7tlzBLW UqCLpPHD5D//JrZqwd3ddVAbXPARhy7leFE9TwuK71fpYAnTw1/GOCqW+pANCR8vegds 32Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=zPyeUykmX49uugDSQZBVtGcq+iLSz7VX/w0EVsQkNnE=; b=sTgw95GqEwNaqlFhgfQuRhFnnYx3qSA5+vfzkUFPoksW6pLEvqyWo4TlzIg2t+SjiJ FiwI9AecpeRWUcoRBwrZeBPJlY6yd+epafVeVl3bjRuLnfAAZkDviTvprs4G7LByjZD4 OdlKGbl/uLKWgPWjvVzLvabqFXOnFilK2YB/KMzMok6kTNIqW7jLVh+sADpIvbks6RL2 wIBaAsV37jYeYGD9JEZN4892ckl/+hu+jwebiO+iYzL2Pv24QVs8oHwKIMXX41/zaqks DIv792NPAymfEnfYwXMYjyXxKA1/mRdj3Xo6OwmEJ8at57vIcex66VCJ6EEl707n2G6H tmOA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I97hTAT0; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::342 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com. [2a00:1450:4864:20::342]) by gmr-mx.google.com with ESMTPS id p12si40331lji.1.2020.01.28.21.29.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 21:29:24 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::342 as permitted sender) client-ip=2a00:1450:4864:20::342; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I97hTAT0; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::342 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x342.google.com with SMTP id s10so4846727wmh.3 for ; Tue, 28 Jan 2020 21:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zPyeUykmX49uugDSQZBVtGcq+iLSz7VX/w0EVsQkNnE=; b=I97hTAT0aKs6s/7Eh2y9M9n0GsbPxwsKf3X8KIWpE2xByOIlyth+uNlnyUen/j4L/f QQFKFUpf1DPXS3cvD+QAxeOwbsCrG7DrFfGPfg3u4uMH+ZnmOt7TDFi4xFvpLDOdKGaY A22UAMBXbhiCxSGsXU3Fy/dA/rsqHiaRlWopRiua4QWwMmFzwMwQmaOheXPzfxboUiHO yxW3fRaRJVeR/EBULXsyVeGpbu1Kuo/OqnAr/qmuz1zJw9axAJAuvqioQrpuF0Rx2Dkh L7tGoNI5bZ8LihiAd4K0X893LW1raLE4oYhRd5/ioulPXmHjRTlX/qxz5OI3TlDwHZxB fwTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zPyeUykmX49uugDSQZBVtGcq+iLSz7VX/w0EVsQkNnE=; b=Th/967yksUgUKkqKJwR2v17FY6T2HgrVdnH6Wi7zzcVdBh7sxFjesw1ajHf6hAlyPQ qdggU2rfe72grhP5Lqc5woJ6kRMC6SOaR/jgahL6IwyuXS5XDTfc0b3+2D6YpOz8DoRt LYmBhew1fBQUdN5EafMJ9vZFb8kpJ0PPtqA4VLgVMWOeG6yu4EZvuABHdjQVoEWzAFRo SlJmWjPRbgYYLFlmQ9KjS2ZUINxoupYagqH1St5VqW/KyuqdhkbA6MiJMF38kYw9KOOn RExOqJ//YE+MeZZc4wWzKto1p19jTJT5qXPhJjx+ICVWWwCEJSn+OLWMuvwdb9R5alQl UWVw== X-Gm-Message-State: APjAAAURYOgIvLzxfCLEjxUerLMmAeUMv7oPi5G0F4esmitQ6QLb1ZX0 jHoDG3b6atEVVW3fSWqafjXsOUEWEYs= X-Received: by 2002:a05:600c:2c0b:: with SMTP id q11mr8900651wmg.2.1580275763605; Tue, 28 Jan 2020 21:29:23 -0800 (PST) Return-Path: Received: from oxygen (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id d8sm1311958wrx.71.2020.01.28.21.29.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jan 2020 21:29:23 -0800 (PST) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Wed, 29 Jan 2020 10:59:18 +0530 To: Henning Schild Cc: vijai kumar , isar-users Subject: Re: [PATCH v3 26/26] meta/recipes-kernel: Export KBUILD_DEPENDS to cache Message-ID: <20200129052918.GA11866@oxygen> References: <20200128154312.337e61f6@md1za8fc.ad001.siemens.net> <20200128154213.22353-1-vijaikumar.kanagarajan@gmail.com> <20200128154213.22353-27-vijaikumar.kanagarajan@gmail.com> <20200128175235.5645b10d@md1za8fc.ad001.siemens.net> <4f458566-c16e-4af0-9b08-174188b21ef8@googlegroups.com> <20200128222240.3a72eb54@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200128222240.3a72eb54@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: 814ahz0LR9dg On Tue, Jan 28, 2020 at 10:22:40PM +0100, Henning Schild wrote: > On Tue, 28 Jan 2020 11:45:18 -0800 > vijai kumar wrote: > > > On Tuesday, January 28, 2020 at 10:22:37 PM UTC+5:30, Henning Schild > > wrote: > > > > > > Thanks. > > > > > > On Tue, 28 Jan 2020 21:12:13 +0530 > > > Vijai Kumar K > wrote: > > > > > > > From: Vijai Kumar K > > > > > > > > > linux-custom overrides do_dpkg_builddeps with its own variant. > > > > Since deb-dl-dir* is not called KBUILD_DEPENDS is not cached. > > > > > > > > Call deb-dl-dir-import/deb-dl-dir-export to cache it. > > > > > > > > Signed-off-by: Vijai Kumar K > > > > --- > > > > meta/recipes-kernel/linux/linux-custom.inc | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > > > > b/meta/recipes-kernel/linux/linux-custom.inc index > > > > 17f8464..37eb3c2 100644 --- > > > > a/meta/recipes-kernel/linux/linux-custom.inc +++ > > > > b/meta/recipes-kernel/linux/linux-custom.inc @@ -41,6 +41,7 @@ > > > > KERNEL_LIBC_DEV_DEPLOY ?= "0" do_install_builddeps() { > > > > dpkg_do_mounts > > > > E="${@ isar_export_proxies(d)}" > > > > + deb_dl_dir_import "${BUILDCHROOT_DIR}" > > > > sudo -E chroot ${BUILDCHROOT_DIR} \ > > > > apt-get update \ > > > > -o > > > > Dir::Etc::SourceList="sources.list.d/isar-apt.list" \ @@ -50,6 > > > > +51,7 @@ do_install_builddeps() { apt-get install \ > > > > -y -o Debug::pkgProblemResolver=yes \ > > > > --no-install-recommends > > > > ${KBUILD_DEPENDS} > > > > > > In between here you will have to do the split from p8. Otherwise if > > > you have post-install hooks to clear the caches the next statement > > > will copy nothing. > > > > > > > > Ah, I see. Will change that. > > It is not likely to have such a hook for the buildchroot but we can not > rule it out for the image. Let us just follow the pattern for the > buildchroot as well. > > > > > > I guess it is ok to send just one patch and note that it is > > > supposed to sit on top of my v2. > > > > > > Sure. > > I could fold your improvements into the queue as regular review > feedback. Or we make it a patch on top to give you credit for finding > the problem with the custom kernel. > > One thing that needs to be done as well, is including a custom-kernel > build into the ci tests. The rebuild tests not covering a custom-kernel > is the reason you ran into the issue. If you decide to send an update > of your patch on top of my patches, please make that ci change as well. > Otherwise let me know if you are ok with me taking the review comment > and doing all the required changes in a v4. No problem. Please go ahead. Thanks, Vijai Kumar K > > In case the maintainer is actually reading all this ... did you have > any other issues with this queue? I know you are including it into a > rather complex layer. If that was the only finding a v4 might just be > ready for a merge. > > regards, > Henning > > > Thanks, > > Vijai Kumar K > > > > > > > > > > > > > Henning > > > > > > > + deb_dl_dir_export "${BUILDCHROOT_DIR}" > > > > dpkg_undo_mounts > > > > } > > > > > > > > > > > > >